Re: JDK10 RFR: 8165437 Evaluate the use of gettimeofday in Networking code

2017-05-03 Thread Vyom Tewari
Hi David, I will look into the issue. Thanks, Vyom On Thursday 04 May 2017 06:29 AM, David Holmes wrote: please find the updated webrev(http://cr.openjdk.java.net/~vtewari/8165437/webrev0.7/index.html). This change is broken on 32-bit systems - JVM_Nanotime returns a jlong which is

Re: JDK10 RFR: 8165437 Evaluate the use of gettimeofday in Networking code

2017-05-03 Thread David Holmes
On 4/05/2017 2:07 PM, Vyom Tewari wrote: Hi David, I will look into the issue. Thanks. I filed: https://bugs.openjdk.java.net/browse/JDK-8179602 as you probably saw. David Thanks, Vyom On Thursday 04 May 2017 06:29 AM, David Holmes wrote: please find the updated

Re: JDK10 RFR: 8165437 Evaluate the use of gettimeofday in Networking code

2017-05-03 Thread David Holmes
please find the updated webrev(http://cr.openjdk.java.net/~vtewari/8165437/webrev0.7/index.html). This change is broken on 32-bit systems - JVM_Nanotime returns a jlong which is always 64-bit, but the code uses long for the nanotimeout values, which will be 32-bit on 32-bit systems! This