Re: RFR:8194298 Add support for per Socket configuration of TCP keepalive

2018-05-16 Thread vyom tewari
Hi, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8194298/webrev0.6/index.html). I renamed the macosx files to "MacOSXSocketOptions.java&MacOSXSocketOptions.c". Our internal tests are clean. Thanks, Vyom On Tuesday 15 May 2018 03:13 PM, Alan Bateman wrote: On 15/05/201

Re: EOF excption in HTTP 1.1 server interaction

2018-05-16 Thread Chris Hegarty
Bernd, > On 16 May 2018, at 00:43, Bernd Eckenfels wrote: > > ... > For the httpclient code, the following improvements are IMHO possible: > > • As you mentioned the EOF should contain the callsite and not be > transorted from a worker thread context. This can either be done by rethrwin

Re: EOF excption in HTTP 1.1 server interaction

2018-05-16 Thread Simon Roberts
Thanks for investigating this, Chris. I will put together a trivial node server and instructions on how to set it up (it's delightfully simple) Should be much less than an hour, if I can give it my un-distracted attention... On Wed, May 16, 2018 at 8:58 AM Chris Hegarty wrote: > Bernd, > > > On

Re: EOF excption in HTTP 1.1 server interaction

2018-05-16 Thread Simon Roberts
OK, here goes. 1) install node 8.11 from here: https://nodejs.org/ this should consist (though I could be wrong for mac or windows!) of expanding the archive, and adding the contained 'bin' directory to your path. You should be able to execute the commands: node --version (note two minus-signs. Sh

OT? reactive streams

2018-05-16 Thread Simon Roberts
Hi, apologies for the rather off topic inquiry, but I'm trying to find out more about the reactive streams features that are used inside the new httpClient. I tried to subscribe to what I think is the appropriate list but appeared to hit a "bug in mailman" (three times, so not, apparently, transien

Re: EOF excption in HTTP 1.1 server interaction

2018-05-16 Thread Daniel Fuchs
Hi Simon, I don't want to speculate, but the line termination for headers are supposed to be \r\n (CRLF) and the headers should be terminated by a 'blank' line (containing only \r\n). If the server isn't sending any CRLF, then the client might still be trying to reach the end of the headers bloc

Re: EOF excption in HTTP 1.1 server interaction

2018-05-16 Thread Joakim Erdfelt
Your node server lies about its Content-Length. That's the #1 reason for your issues, lack of truth about the Content-Length. When you under-send (Content-Length longer then actual response body content), you get the java.io.EOFException: EOF reached while reading from your initial message. When

Re: OT? reactive streams

2018-05-16 Thread James Roper
Hi Simon, This is the right place to talk about the new HTTP client. I wrote a blog post which has some hypothetical examples of integrating the HTTP client with other APIs (such as the servlet API) and their hypothetical future adoption of Reactive Streams: https://developer.lightbend.com/blog/