RE: RFR: 8223714: HTTPSetAuthenticatorTest could be made more resilient

2019-08-31 Thread Vyom Tewari26
Hi Jaikiran,   Code changes look OK to me , couple of minor comments 1-> you don't need "this" to access stop(this.stop) 2-> i think super.stop() should be the first line in the overridden stop method. 3-> it is matter of personal preference but my preference is use the new variable name 'running'

Re: RFR: 8223714: HTTPSetAuthenticatorTest could be made more resilient

2019-08-31 Thread Vyom Tiwari
Hi Jaikiran, Code changes look OK to me , couple of minor comments 1-> you don't need "this" to access stop(this.stop) 2-> i think super.stop() should be the first line in the overridden stop method. 3-> it is matter of personal preference but my preference is use the new variable name 'running' t

Re: RFR: 8171405: java/net/URLConnection/ResendPostBody.java failed with "Error while cleaning up threads after test"

2019-08-31 Thread Vyom Tewari26
Hi Julia,   Thanks for fixing this test issue, in your modified code server will get closed twice once in main thread(server.setFinished(true);) and once in server run method. Please  close server if it is already not closed(if (!server.isClosed()) { server.close();}) or remove server.close() from