Hi Jaikiran,
Code changes look OK to me , couple of minor comments
1-> you don't need "this" to access stop(this.stop)
2-> i think super.stop() should be the first line in the overridden stop method.
3-> it is matter of personal preference but my preference is use the new variable name 'running'
Hi Jaikiran,
Code changes look OK to me , couple of minor comments
1-> you don't need "this" to access stop(this.stop)
2-> i think super.stop() should be the first line in the overridden stop
method.
3-> it is matter of personal preference but my preference is use the new
variable name 'running' t
Hi Julia,
Thanks for fixing this test issue, in your modified code server will get closed twice once in main thread(server.setFinished(true);) and once in server run method. Please close server if it is already not closed(if (!server.isClosed()) { server.close();}) or remove server.close() from