Re: RFR[8230159]: Add test to verify that com.sun.net.httpserver.BasicAuthenticator constructors throw expected exceptions

2019-09-03 Thread Daniel Fuchs
Thanks for the new test Patrick! It looks good to me. best regards, -- daniel On 02/09/2019 11:23, Patrick Concannon wrote: https://bugs.openjdk.java.net/browse/JDK-8230159 

Webrev for fix: http://cr.openjdk.java.net/~dfuchs/pconcann/8230159/webrevs/webrev.2/

Re: RFR: 8171405: java/net/URLConnection/ResendPostBody.java failed with "Error while cleaning up threads after test"

2019-09-03 Thread Daniel Fuchs
That looks good to me Julia! best regards, -- daniel On 02/09/2019 16:44, Julia Boes wrote: Hi, Thanks for the review, Michael and Vyom. I removed server.close() from the run method. Updated webrev: http://cr.openjdk.java.net/~dfuchs/jboes/8171405/webrev.03/ Regards, Julia

Re: [testsabilization] RFR: 8230435: Replace wildcard address with loopback or local host in tests - part 22

2019-09-03 Thread Michael McMahon
Looks fine to me Daniel. - Michael. On 02/09/2019, 14:00, Daniel Fuchs wrote: Hi, (cc-ing security dev for the changes in test/jdk/javax/net/ssl/templates/SSLSocketTemplate.java which is updated to allow for binding on a specific IP Address) Please find below a patch for: 8230435: Replace

RE: RFR[8230159]: Add test to verify that com.sun.net.httpserver.BasicAuthenticator constructors throw expected exceptions

2019-09-03 Thread Vyom Tewari26
Hi Patrick,   New test looks good to me, minor bit jtreg tag order in not correct ,  generally @run tag comes last.   Thanks, Vyom   - Original message -From: Daniel Fuchs Sent by: "net-dev" To: Patrick Concannon , OpenJDK Network Dev list Cc:Subject: [EXTERNAL] Re: RFR[8230159]: Add test

[RFR] 8219640: UnresolvedAddressException not thrown for incorrect hostname

2019-09-03 Thread Rob McKenna
Hi folks, Assuming the premise of this bug is correct, could I get a review for the following: https://bugs.openjdk.java.net/browse/JDK-8219640 http://cr.openjdk.java.net/~robm/8219640/webrev.01/ Windows rejects a lookup for "127.0.0.1 test" where getaddrinfo on non-Windows platforms resolves

Re: RFR: 8223714: HTTPSetAuthenticatorTest could be made more resilient

2019-09-03 Thread Daniel Fuchs
Hi Jaikiran, Tests were successful and I pushed it... best regards, -- daniel On 02/09/2019 12:29, Daniel Fuchs wrote: On 02/09/2019 12:23, Jaikiran Pai wrote: This does look better. I have updated the code to use this construct and the new webrev is at

Re: [RFR] 8219640: UnresolvedAddressException not thrown for incorrect hostname

2019-09-03 Thread Alan Bateman
On 03/09/2019 15:59, Rob McKenna wrote: Hi folks, Assuming the premise of this bug is correct, could I get a review for the following: https://bugs.openjdk.java.net/browse/JDK-8219640 http://cr.openjdk.java.net/~robm/8219640/webrev.01/ Windows rejects a lookup for "127.0.0.1 test" where

Re: [RFR] 8219640: UnresolvedAddressException not thrown for incorrect hostname

2019-09-03 Thread Chris Hegarty
On 3 Sep 2019, at 16:49, Alan Bateman wrote: > > On 03/09/2019 15:59, Rob McKenna wrote: >> Hi folks, >> >> Assuming the premise of this bug is correct, could I get a review for >> the following: >> >> https://bugs.openjdk.java.net/browse/JDK-8219640 >>

Re: [RFR] 8219640: UnresolvedAddressException not thrown for incorrect hostname

2019-09-03 Thread Chris Hegarty
> On 3 Sep 2019, at 17:29, Chris Hegarty wrote: > ... > Welcome to Ubuntu 16.04.6 LTS (GNU/Linux 4.15.0-54-generic x86_64) > > * Documentation: https://help.ubuntu.com > * Management: https://landscape.canonical.com > * Support:https://ubuntu.com/advantage > ... > $ uname -a >

Re: [RFR] 8219640: UnresolvedAddressException not thrown for incorrect hostname

2019-09-03 Thread Alan Bateman
On 03/09/2019 17:35, Chris Hegarty wrote: : From the same Linux system: $ ldd --version ldd (Ubuntu GLIBC 2.23-0ubuntu11) 2.23 Copyright (C) 2016 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or

Re: [RFR] 8219640: UnresolvedAddressException not thrown for incorrect hostname

2019-09-03 Thread Rob McKenna
Thanks for the pointer to the passing host Alan. With that I was able to track down: https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=108bc4049f8ae82710aec26a92ffdb4b439c83fd So it looks like this has recently been fixed in glibc. -Rob On 03/09/19 17:47, Alan Bateman wrote: > On

Re: RFR: 8223714: HTTPSetAuthenticatorTest could be made more resilient

2019-09-03 Thread Jaikiran Pai
Thank you Daniel. -Jaikiran On 03/09/19 10:20 PM, Daniel Fuchs wrote: > Hi Jaikiran, > > Tests were successful and I pushed it... > > best regards, > > -- daniel > > On 02/09/2019 12:29, Daniel Fuchs wrote: >> On 02/09/2019 12:23, Jaikiran Pai wrote: >>> This does look better. I have updated the