Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-02 Thread Vyom Tewari
please find the updated webrev http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.2/ Thanks, Vyom On 3/2/2016 2:36 PM, Chris Hegarty wrote: On 2 Mar 2016, at 08:19, Alan Bateman wrote: On

Re: RFR 8150521: Test test/java/net/InetAddress/getOriginalHostName.java fails to load JavaNetInetAddressAccess from SharedSecrets

2016-03-02 Thread Vyom Tewari
incorporated the review comment, updated webrev in place. http://cr.openjdk.java.net/~nkumar/vyom/8150521/webrev0.1/index.html Vyom On 3/2/2016 1:45 PM, Alan Bateman wrote: On 02/03/2016 07:44, vyom wrote: Hi Chris,

RFC3986 URI

2016-03-02 Thread Peter Firmstone
I haven't had time, but at one time I had planned to assist upgrading java.net.URI to RFC3986. I'm not the sole author of the Uri class which can be found here, however since it has a similar public api to java.net.URI, it could be used as a drop in replacement for testing the feasibility and

Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-02 Thread Chris Hegarty
> On 2 Mar 2016, at 08:19, Alan Bateman wrote: > > > > On 02/03/2016 06:47, vyom wrote: >> Hi Chris/Alan, >> >> Thanks for review, please find the updated >> webrev(http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.1/index.html >>

Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-02 Thread Alan Bateman
On 02/03/2016 06:47, vyom wrote: Hi Chris/Alan, Thanks for review, please find the updated webrev(http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.1/index.html ). This looks much better. I see the test is

Re: RFR 8150521: Test test/java/net/InetAddress/getOriginalHostName.java fails to load JavaNetInetAddressAccess from SharedSecrets

2016-03-02 Thread Alan Bateman
On 02/03/2016 07:44, vyom wrote: Hi Chris, Thanks for review please find the updated webrev(http://cr.openjdk.java.net/~nkumar/vyom/8150521/webrev0.1/index.html ). This looks okay to me. Style wide, can you put a space

Re: RFR 8150521: Test test/java/net/InetAddress/getOriginalHostName.java fails to load JavaNetInetAddressAccess from SharedSecrets

2016-03-02 Thread Chris Hegarty
> On 2 Mar 2016, at 07:44, vyom wrote: > > Hi Chris, > > Thanks for review please find the updated > webrev(http://cr.openjdk.java.net/~nkumar/vyom/8150521/webrev0.1/index.html > ). Looks good to