Fwd: Preliminary RFR JDK-8159053: Improve onPing/onClose behavior

Sorry for the wrong method. There should've been onPing instead of onPong. What's wrong with these two? /** * Receives a Ping message. * * A Ping message may be sent or received by either client or * server. It may serve either as a keepalive or as a means to verify * that the remote

Preliminary RFR JDK-8159053: Improve onPing/onClose behavior

Hi, Could you please [*] review the following change for the upcoming JDK-8159053? This change addresses: 1. Listener.onClose/onPing behaviour, making the implementation fully* responsible of protocol compliance. So reactions on onClose/onPing cannot be overridden/redefined in a Listener 2.

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

+1 Thanks, Roger On 6/17/2016 10:27 AM, Chris Hegarty wrote: On 17/06/16 15:09, Vyom Tewari wrote: Hi, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8071660/webrev0.3/index.html ). I fixed the typo along

Re: RFR: 8159745: Remove java.net.Parts

On 2016-06-17 16:26, Chris Hegarty wrote: On 17/06/16 15:05, Claes Redestad wrote: On 2016-06-17 16:04, Alan Bateman wrote: On 17/06/2016 14:43, Claes Redestad wrote: Hi, URL.java defines a package-private class Parts, which can be trivially inlined in the one place where it's

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

On 17/06/16 15:09, Vyom Tewari wrote: Hi, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8071660/webrev0.3/index.html ). I fixed the typo along with spaces issue. Thanks Vyom. Looks good. -Chris.

Re: RFR: 8159745: Remove java.net.Parts

On 17/06/16 15:05, Claes Redestad wrote: On 2016-06-17 16:04, Alan Bateman wrote: On 17/06/2016 14:43, Claes Redestad wrote: Hi, URL.java defines a package-private class Parts, which can be trivially inlined in the one place where it's currently used. Webrev:

Re: RFR: 8159745: Remove java.net.Parts

On 2016-06-17 16:04, Alan Bateman wrote: On 17/06/2016 14:43, Claes Redestad wrote: Hi, URL.java defines a package-private class Parts, which can be trivially inlined in the one place where it's currently used. Webrev: http://cr.openjdk.java.net/~redestad/8159745/webrev.01/ Bug:

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

Hi, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8071660/webrev0.3/index.html ). I fixed the typo along with spaces issue. Thanks, Vyom On Friday 17 June 2016 06:34 PM, Roger Riggs wrote: Hi Vyom,

Re: RFR: 8159745: Remove java.net.Parts

On 17/06/2016 14:43, Claes Redestad wrote: Hi, URL.java defines a package-private class Parts, which can be trivially inlined in the one place where it's currently used. Webrev: http://cr.openjdk.java.net/~redestad/8159745/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8159745 I

RFR: 8159745: Remove java.net.Parts

Hi, URL.java defines a package-private class Parts, which can be trivially inlined in the one place where it's currently used. Webrev: http://cr.openjdk.java.net/~redestad/8159745/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8159745 Thanks! /Claes

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

Hi Vyom, URLPermissionTest.java: line 125: it looks odd to assign the same variable twice with the same value. Perhaps it should have been assigning this.url2 = url2. line 330-332: please add a space after "," in argument lists. Roger On 6/17/2016 8:42 AM, Daniel Fuchs wrote: On

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

On 17/06/16 13:25, Vyom Tewari wrote: Hi Daniel, thanks for review please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8071660/webrev0.2/index.html ) . I added some more tests where base url is different. Thanks

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

Hi Daniel, thanks for review please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8071660/webrev0.2/index.html ) . I added some more tests where base url is different. Thanks, Vyom On Friday 17 June 2016 04:57

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

On 17/06/16 09:21, Vyom Tewari wrote: Hi All, Please find the new webrev(http://cr.openjdk.java.net/~vtewari/8071660/webrev0.1/index.html ). I addressed the review comments given by Daniel. Hi Vyom, Looks good to me - but

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

Hi All, Please find the new webrev(http://cr.openjdk.java.net/~vtewari/8071660/webrev0.1/index.html ). I addressed the review comments given by Daniel. Thanks, Vyom On Sunday 12 June 2016 02:04 PM, Daniel Fuchs wrote: