RE: [9] RFR: 8164592: java/net/MulticastSocket/NoLoopbackPackets.java tests may leave a daemon thread

2016-08-22 Thread Langer, Christoph
Hi Artem, looks good - Unfortunately I'm no reviewer. Best regards Christoph > -Original Message- > From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Artem > Smotrakov > Sent: Dienstag, 23. August 2016 04:03 > To: Net Dev OpenJDK > Subject:

[9] RFR: 8164592: java/net/MulticastSocket/NoLoopbackPackets.java tests may leave a daemon thread

2016-08-22 Thread Artem Smotrakov
Hello, Please review the following patch for NoLoopbackPackets.java test. The test starts a daemon thread which has an infinite loop. If jtreg uses the same JVM to run multiple tests (agent VM), then this thread will be keep running until the agent VM stops. This is not good, it would be

Re: RFR 8005068: HttpCookie does not correctly handle negative maxAge values

2016-08-22 Thread Svetlana Nikandrova
Kindly reminder On 19.08.2016 16:30, Svetlana Nikandrova wrote: Hello, please review this fix. Javadoc for HttpCookie setMaxAge states that " A negative value means that cookie is not stored persistently" and "max age is unspecified", but hasExpired only checks for "-1" as possible negative

RE: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-08-22 Thread Langer, Christoph
Hi Vyom, the build on AIX was successful. Best regards Christoph > -Original Message- > From: Langer, Christoph > Sent: Montag, 22. August 2016 14:40 > To: 'Vyom Tewari' ; net-dev d...@openjdk.java.net> > Subject: RE: RFR 8075484:SocketInputStream.socketRead0

RE: RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-08-22 Thread Langer, Christoph
Hi Vyom, to me the change looks good, apart from a few minor cosmetical remarks: in SocketInputStream.c (new): line 71: if (_timeout > 0) { -> I think the if is indented by one space too much line 109: LABEL: if (_timeout) { -> as the length of "LABEL: " is more than 4 chars and hence the if is

RFR 8075484:SocketInputStream.socketRead0 can hang even with soTimeout set

2016-08-22 Thread Vyom Tewari
Hi All, Please review the code changes for below issue. Bug : https://bugs.openjdk.java.net/browse/JDK-8075484 webrev: http://cr.openjdk.java.net/~vtewari/8075484/webrev0.0/index.html This issue is

JDK 9 RFR of JDK-8164545: Mark java/net/URLPermission/nstest/lookup.sh as intermittently failing

2016-08-22 Thread Amy Lu
java/net/URLPermission/nstest/lookup.sh This test is known to fail intermittently (JDK-8156504), this patch is to mark the test accordingly with keyword 'intermittent'. bug: https://bugs.openjdk.java.net/browse/JDK-8164545 webrev: http://cr.openjdk.java.net/~amlu/8164545/webrev.00/ Thanks,

HTTP client API

2016-08-22 Thread Michael McMahon
There is an updated version of the HTTP client API doc [1] and a specdiff [2] showing the changes proposed from the current version in JDK9 dev. The main changes are: 1) The request and response processors are now based on Flow.Publisher and Flow.Subscriber 2) Response bodies are retrieved