Re: RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

Hi Arno, I suggest you to call "CHECK_NULL_RETURN" after below line in DefaultProxySelector.c // create an empty LinkedList to add the Proxy objects. + proxyList = (*env)->NewObject(env, list_class, list_ctrID); in windows/native/libnet/DefaultProxySelector.c file you remove the couple of

RFR(M): 8167457: Fixes for InetAddressImpl native coding on Windows

Hi again, after pushing the change for 8171077 (http://hg.openjdk.java.net/jdk9/dev/jdk/rev/24f8703890b2), I have updated my patch for 8167457 and I have also updated the bug description to reflect the reduced scope. Bug: https://bugs.openjdk.java.net/browse/JDK-8167457 Webrev:

RFR(M): 8167420: Fixes for InetAddressImpl native coding on Linux/Unix platforms

Hi, after pushing the change for 8171075 (http://hg.openjdk.java.net/jdk9/dev/jdk/rev/3edecfdfe4de), I have updated my patch for 8167420 and I have also updated the bug description to reflect the reduced scope. Bug: https://bugs.openjdk.java.net/browse/JDK-8167420 Webrev:

Re: RFR 8168840: InetAddress.getByName() throws java.net.UnknownHostException no such interface when used with virtual interfaces on Solaris

Hi Chris, i will do the change( *colonP = '\0';') before pushing still i have to run the jprt. Once it is done and clean i will do the suggested change and push the code. thanks, Vyom On 12/21/2016 7:23 PM, Chris Hegarty wrote: Vyom, Thank you for the explanation. Makes sense. Your

Re: RFR 8168840: InetAddress.getByName() throws java.net.UnknownHostException no such interface when used with virtual interfaces on Solaris

Vyom, Thank you for the explanation. Makes sense. Your changes look fine as are, but maybe '250 *colonP = '\0';' would be clearer ( though I do note that we do *name_colonP = 0; elsewhere in this file ). -Chris. On 21/12/16 13:41, Vyom Tewari wrote: Hi Chris, If you create the

Re: RFR 8168840: InetAddress.getByName() throws java.net.UnknownHostException no such interface when used with virtual interfaces on Solaris

Hi Chris, If you create the Inet6Address using the following constructor "Inet6Address (String , byte[], String )" then it will call the following private method " initstr (hostName, addr, ifname);" and it you see the implementation of this method then you will see the below code.

RE: RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

Hi Arno, this looks good. I had already reviewed your change. Just as for one thing that Volker mentioned: >- DefaultProxySelector.java > >322 return proxyList == null ? Arrays.asList(Proxy.NO_PROXY) : >proxyList; > >Not sure if it would make sense to preallocate a static List with a

RE: RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

Hi Volker, thanks for your valuable comments! I have a new patch ready that should address your issues and contains also a forgotten change to the map file... New webrev: http://cr.openjdk.java.net/~clanger/webrevs/8170868.1/ >- make/lib/NetworkingLibraries.gmk ... >Have you tried to use

Re: RFR 8168840: InetAddress.getByName() throws java.net.UnknownHostException no such interface when used with virtual interfaces on Solaris

Hi Vyom, Sorry, I'm missing the connection between Inet6Address and NetworkInterface.getByName, how do these interact? -Chris. On 21/12/16 10:20, Vyom Tewari wrote: incorporated the comments(http://cr.openjdk.java.net/~vtewari/8168840/webrev0.2/index.html

Re: RFR 8168840: InetAddress.getByName() throws java.net.UnknownHostException no such interface when used with virtual interfaces on Solaris

Hi All, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8168840/webrev0.1/index.html ). Thanks, Vyom On Tuesday 13 December 2016 01:38 PM, Langer, Christoph wrote: Hi Vyom, thanks for looking at this.