Re: JDK10 RFR: 8165437 Evaluate the use of gettimeofday in Networking code

On Wednesday 12 April 2017 11:05 PM, Vyom Tewari wrote: Hi Roger, thanks for review, please see my comment inline. Vyom On Wednesday 12 April 2017 08:17 PM, Roger Riggs wrote: Hi Vyom, Thanks for taking this on. I have a few comments and questions. In aix_close.c line 547 The code

Re: JDK10 RFR: 8165437 Evaluate the use of gettimeofday in Networking code

Hi Roger, thanks for review, please see my comment inline. Vyom On Wednesday 12 April 2017 08:17 PM, Roger Riggs wrote: Hi Vyom, Thanks for taking this on. I have a few comments and questions. In aix_close.c line 547 The code for if (nanoTimeout >= NSEC_PER_MSEC) seems ineffective.

Re: RFR [9] 8177536: Avoid Apple Peer-to-Peer interfaces in networking tests

Hi Chris, Looks good, nice use of streams. B6558853.java: 28: an extra "*" A few tests do nothing unless an interface is found; they could use either output that says what interface is tested or a message that no interface was available. (In case someone is reviewing the logs and wants to

Re: JDK10 RFR: 8165437 Evaluate the use of gettimeofday in Networking code

Hi Vyom, Thanks for taking this on. I have a few comments and questions. In aix_close.c line 547 The code for if (nanoTimeout >= NSEC_PER_MSEC) seems ineffective. The update of nanoTime at 549-550 ensures the timeout is > NSEC_PER_MSEC if it loops. On the first pass through the code if

RFR [9] 8177536: Avoid Apple Peer-to-Peer interfaces in networking tests

This is a tests only change. Several networking tests appear to fail intermittently on recent Mac machines. In most cases an Apple Peer-to-Peer, awdl0, interface, has been seen to be chosen by the test, for some operation or other, when enumerating the set of network interfaces on the machine.