Hi Thomas,

fix look good to me, but i am not jdk10 reviewer.

Thanks,

Vyom


On Tuesday 16 May 2017 06:20 PM, Thomas Stüfe wrote:
Hi all,

may I have a review for this tiny fix:

Issue: https://bugs.openjdk.java.net/browse/JDK-8180424
webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8180424-another-build-issue-on-aix-after-8034174/webrev.00/webrev/ <http://cr.openjdk.java.net/%7Estuefe/webrevs/8180424-another-build-issue-on-aix-after-8034174/webrev.00/webrev/>

The prototypes for NET_RecvFrom and NET_Accept do not match their implementations for AIX since 8034174. This did not lead to an error in jdk9 because there, the header (net_util_md.h) was not included by aix_close.c. In JDK10, it is included and therefore does not build.

I believe this did not lead to a runtime error on jdk9, at least not for the typical values involved; the mismatch is between int* and unsigned int* (native socklen_t).

Kind Regards, Thomas

Reply via email to