RE: httpserver does not close connections when RejectedExecutionException occurs

[Langer, Christoph]

Hi Yuji,

looks good.

Best regards
Christoph

> -Original Message-
> From: KUBOTA Yuji [mailto:kubota.y...@gmail.com]
> Sent: Donnerstag, 8. März 2018 03:57
> To: Daniel Fuchs 
> Cc: Langer, Christoph ; Yasumasa Suenaga
> ; OpenJDK Network Dev list  d...@openjdk.java.net>
> Subject: Re: httpserver does not close connections when
> RejectedExecutionException occurs
> 
> Hi Daniel,
> 
> Thank you for your sponsoring!
> 
> 2018-03-08 0:56 GMT+09:00 Daniel Fuchs :
> > Could you prepare a final changeset with a properly formatted
> > comment [1], use jcheck [2] to verify that your changeset conforms
> > to the OpenJDK rules (no trailing whitespaces, no tabs etc...),
> > and upload it somewhere to http://cr.openjdk.java.net/~ykubota/8169358
> ?
> 
> My final changeset is below. (no jcheck error from webrev.04)
> http://cr.openjdk.java.net/~ykubota/8169358/final_changeset_jckecked
> 
> If Christoph could not check webrev.04, please use the following changeset.
> http://cr.openjdk.java.net/~ykubota/8169358/final_changeset_jckecked-
> two-reviewers
> 
> Best regards
> Yuji

Re: httpserver does not close connections when RejectedExecutionException occurs

[KUBOTA Yuji]

Hi Daniel,

Thank you for your sponsoring!

2018-03-08 0:56 GMT+09:00 Daniel Fuchs :
> Could you prepare a final changeset with a properly formatted
> comment [1], use jcheck [2] to verify that your changeset conforms
> to the OpenJDK rules (no trailing whitespaces, no tabs etc...),
> and upload it somewhere to http://cr.openjdk.java.net/~ykubota/8169358 ?

My final changeset is below. (no jcheck error from webrev.04)
http://cr.openjdk.java.net/~ykubota/8169358/final_changeset_jckecked

If Christoph could not check webrev.04, please use the following changeset.
http://cr.openjdk.java.net/~ykubota/8169358/final_changeset_jckecked-two-reviewers

Best regards
Yuji

Re: httpserver does not close connections when RejectedExecutionException occurs

[Chris Hegarty]

On 07/03/18 01:07, KUBOTA Yuji wrote:

..
Nice catch! I removed this unused variable.
http://cr.openjdk.java.net/~ykubota/8169358/webrev.04/

I think is good. Thanks.

-Chris.

Re: httpserver does not close connections when RejectedExecutionException occurs

[Daniel Fuchs]

Hi Yuji,

On 07/03/2018 01:07, KUBOTA Yuji wrote:

Nice catch! I removed this unused variable.
http://cr.openjdk.java.net/~ykubota/8169358/webrev.04/

Best regards
Yuji



This looks good to me as well. I have imported your patch
and sent it to our test system and things are looking fine.

Could you prepare a final changeset with a properly formatted
comment [1], use jcheck [2] to verify that your changeset conforms
to the OpenJDK rules (no trailing whitespaces, no tabs etc...),
and upload it somewhere to http://cr.openjdk.java.net/~ykubota/8169358 ?

If there aren't any other review feedback in the mean time, I'll
be happy to sponsor your changes when that's ready.

best regards,

-- daniel
[1] http://openjdk.java.net/guide/producingChangeset.html
[2] http://openjdk.java.net/projects/code-tools/jcheck/

Re: RFE: Add PATCH to the list of the supported HTTP methods

[Andrej Golovnin]

Hi Chris,

> The JDK HTTP Client has:
>   `HttpRequest.Builder::method(String method, BodyPublisher publisher)`
>
>  ,so it is currently possible to use the `PATCH` method.
>
> Is `PATCH` sufficiently popular to warrant its own self-named
> method in the request builder?

I don't know how popular is it. We have just started to use it with
one of our services and discovered that we cannot use it with
HttpURLConnection at all. And I thought when we add the support for
PATCH to HttpURLConnection, then it would be nice to have it in HTTP
Client too. When you decided not to add it to HTTP Client, then it is
OK for me too. But I think that HttpURLConnection should be changed.

Best regards,
Andrej Golovnin