Re: RFR:8194298 Add support for per Socket configuration of TCP keepalive

On Saturday 12 May 2018 04:14 PM, Ivan Gerasimov wrote: Thanks Vyom! I like it much better now. The last minorish comment: src/jdk.net/share/classes/jdk/net/ExtendedSocketOptions.java Set options = new HashSet<>(5); Please note that the constructor of HashSet wants the

Re: RFR:8194298 Add support for per Socket configuration of TCP keepalive

Thanks Vyom! I like it much better now. The last minorish comment: src/jdk.net/share/classes/jdk/net/ExtendedSocketOptions.java Set options = new HashSet<>(5); Please note that the constructor of HashSet wants the initial capacity as the argument, not the expected number of

Re: RFR:8194298 Add support for per Socket configuration of TCP keepalive

Hi Ivan, Thanks for review, please find the updated webrev(http://cr.openjdk.java.net/~vtewari/8194298/webrev0.4/index.html). Please find my answers in-line. Thanks, vyom On Saturday 12 May 2018 11:15 AM, Ivan Gerasimov wrote: Hi Vyom! 1)