Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v9]

2021-02-03 Thread Xue-Lei Andrew Fan
On Tue, 2 Feb 2021 01:19:01 GMT, Clive Verghese wrote: >> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears >> to not be fully fixed >> >> This also fixes JDK-8259516: Alerts sent by peer may not be received >> correctly during TLS handshake > > Clive Verghese has

Re: RFR: JDK-8241995: Clarify InetSocketAddress::toString specification [v2]

2021-02-03 Thread Julia Boes
On Wed, 3 Feb 2021 14:19:27 GMT, Alan Bateman wrote: >> Julia Boes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> small adjustment > > src/java.base/share/classes/java/net/InetSocketAddress.java line 387: > >> 385: * To retrieve

Re: RFR: 8235139: Remove the socket impl factory mechanism

2021-02-03 Thread Alan Bateman
On Wed, 3 Feb 2021 11:03:51 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my proposed changeset for JDK-8235139: '`Remove > the socket impl factory mechanism`' ? > > These changes propose to deprecate (for the eventual removal) the API points > for statically

Re: RFR: JDK-8241995: Clarify InetSocketAddress::toString specification [v2]

2021-02-03 Thread Alan Bateman
On Wed, 3 Feb 2021 14:17:58 GMT, Julia Boes wrote: >> This change clarifies the InetSocketAddress::toString specification, which >> was recently updated to reflect an implementation change [1]. The >> specification is not changed, but it is enhanced with two examples and some >> more

Re: RFR: JDK-8241995: Clarify InetSocketAddress::toString specification [v2]

2021-02-03 Thread Julia Boes
> This change clarifies the InetSocketAddress::toString specification, which > was recently updated to reflect an implementation change [1]. The > specification is not changed, but it is enhanced with two examples and some > more verbiage, as per earlier suggestions on the net-dev mailing list

Integrated: JDK-8241995: Clarify InetSocketAddress::toString specification

2021-02-03 Thread Julia Boes
On Tue, 2 Feb 2021 15:55:40 GMT, Julia Boes wrote: > This change clarifies the InetSocketAddress::toString specification, which > was recently updated to reflect an implementation change [1]. The > specification is not changed, but it is enhanced with two examples and some > more verbiage, as

Re: RFR: JDK-8241995: Clarify InetSocketAddress::toString specification

2021-02-03 Thread Michael McMahon
On Tue, 2 Feb 2021 15:55:40 GMT, Julia Boes wrote: > This change clarifies the InetSocketAddress::toString specification, which > was recently updated to reflect an implementation change [1]. The > specification is not changed, but it is enhanced with two examples and some > more verbiage, as

Re: RFR: JDK-8241995: Clarify InetSocketAddress::toString specification

2021-02-03 Thread Chris Hegarty
On Tue, 2 Feb 2021 15:55:40 GMT, Julia Boes wrote: > This change clarifies the InetSocketAddress::toString specification, which > was recently updated to reflect an implementation change [1]. The > specification is not changed, but it is enhanced with two examples and some > more verbiage, as

Re: RFR: JDK-8241995: Clarify InetSocketAddress::toString specification

2021-02-03 Thread Jaikiran Pai
On Wed, 3 Feb 2021 11:36:28 GMT, Julia Boes wrote: >> Maybe could say "rather than parsing the output of toString()" instead of >> "rather than parsing the string representation". Might be clearer? > > Ok, how about this: "rather than parsing the string returned by this > toString() method"?

Re: RFR: 8235139: Remove the socket impl factory mechanism

2021-02-03 Thread Daniel Fuchs
On Wed, 3 Feb 2021 11:36:23 GMT, Daniel Fuchs wrote: >> Hi, >> >> Could someone please review my proposed changeset for JDK-8235139: '`Remove >> the socket impl factory mechanism`' ? >> >> These changes propose to deprecate (for the eventual removal) the API points >> for statically

Re: RFR: JDK-8241995: Clarify InetSocketAddress::toString specification

2021-02-03 Thread Julia Boes
On Tue, 2 Feb 2021 16:14:10 GMT, Michael McMahon wrote: >> This change clarifies the InetSocketAddress::toString specification, which >> was recently updated to reflect an implementation change [1]. The >> specification is not changed, but it is enhanced with two examples and some >> more

Re: RFR: 8235139: Remove the socket impl factory mechanism

2021-02-03 Thread Daniel Fuchs
On Wed, 3 Feb 2021 11:03:51 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my proposed changeset for JDK-8235139: '`Remove > the socket impl factory mechanism`' ? > > These changes propose to deprecate (for the eventual removal) the API points > for statically

RFR: 8235139: Remove the socket impl factory mechanism

2021-02-03 Thread Patrick Concannon
Hi, Could someone please review my proposed changeset for JDK-8235139: '`Remove the socket impl factory mechanism`' ? These changes propose to deprecate (for the eventual removal) the API points for statically configuring a system-wide factory for the `Socket`, `ServerSocket`, and