On Fri, 26 Feb 2021 10:59:01 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a change that fixes "no comment" warnings generated by
>> `javadoc -Xdoclint` for `java.base/java.net`
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last
On Thu, 25 Feb 2021 15:38:02 GMT, Conor Cleary wrote:
>> A number of net tests use a
>> **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)**
>> to verify either the functionality of
On Thu, 25 Feb 2021 22:59:23 GMT, Jonathan Gibbons wrote:
> Please review some simple doc fixes in the `java.base` module. Two were
> reported by doclint; the spelling error was detected by the IDE.
This pull request has now been integrated.
Changeset: 3088e1e6
Author:Jonathan Gibbons
On Wed, 17 Feb 2021 07:20:27 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.java.net/browse/JDK-8260366?
>
> The issue relates to the concurrent classloading of
> `sun.net.ext.ExtendedSocketOptions` and
On Wed, 24 Feb 2021 15:41:53 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reduce the scope of the synchronized block in getInstance() and enhance
>> the testcase to be more robust in catching
On Thu, 25 Feb 2021 22:59:23 GMT, Jonathan Gibbons wrote:
> Please review some simple doc fixes in the `java.base` module. Two were
> reported by doclint; the spelling error was detected by the IDE.
Marked as reviewed by lancea (Reviewer).
-
PR:
On Fri, 26 Feb 2021 10:59:01 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a change that fixes "no comment" warnings generated by
>> `javadoc -Xdoclint` for `java.base/java.net`
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last
> Hi,
>
> Please find here a change that fixes "no comment" warnings generated by
> `javadoc -Xdoclint` for `java.base/java.net`
Daniel Fuchs has updated the pull request incrementally with one additional
commit since the last revision:
Fixed @throws to conform to the style of other
On Fri, 26 Feb 2021 10:44:04 GMT, Rahul Yadav wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed comment
>
> LGTM!
Ran the changes through `-Xdoclint:missing` and there were no warnings
outputted so looks
On Thu, 25 Feb 2021 11:05:07 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a change that fixes "no comment" warnings generated by
>> `javadoc -Xdoclint` for `java.base/java.net`
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last
On Thu, 25 Feb 2021 22:59:23 GMT, Jonathan Gibbons wrote:
> Please review some simple doc fixes in the `java.base` module. Two were
> reported by doclint; the spelling error was detected by the IDE.
LGTM
-
Marked as reviewed by dfuchs (Reviewer).
PR:
On Thu, 25 Feb 2021 15:38:02 GMT, Conor Cleary wrote:
>> A number of net tests use a
>> **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)**
>> to verify either the functionality of
On Thu, 25 Feb 2021 22:59:23 GMT, Jonathan Gibbons wrote:
> Please review some simple doc fixes in the `java.base` module. Two were
> reported by doclint; the spelling error was detected by the IDE.
Marked as reviewed by chegar (Reviewer).
-
PR:
13 matches
Mail list logo
