Re: RFR: JDK-8243376: java.net.SocketPermission.implies(Permission p) spec is mismatching with implementation [v9]

2021-03-10 Thread Jayashree S Kumar
> Issue > > https://bugs.openjdk.java.net/browse/JDK-8243376 > > Problem > > The scenario is: > - Some specified target hostname resolves to two IP addresses (always the > same address pair). > - The DNS resolved order of the two ip addresses changes (a usual > LoadBalancer type behavior).

Re: RFR: JDK-8243376: java.net.SocketPermission.implies(Permission p) spec is mismatching with implementation [v6]

2021-03-10 Thread Jayashree S Kumar
On Fri, 5 Mar 2021 15:08:03 GMT, Michael McMahon wrote: >> Jayashree S Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Code Review: Incorporated Indention correction, added getIP and updated >> try-catch inside for loop > >

Re: RFR: JDK-8243376: java.net.SocketPermission.implies(Permission p) spec is mismatching with implementation [v8]

2021-03-10 Thread Jayashree S Kumar
> Issue > > https://bugs.openjdk.java.net/browse/JDK-8243376 > > Problem > > The scenario is: > - Some specified target hostname resolves to two IP addresses (always the > same address pair). > - The DNS resolved order of the two ip addresses changes (a usual > LoadBalancer type behavior).

Re: RFR: JDK-8243376: java.net.SocketPermission.implies(Permission p) spec is mismatching with implementation [v7]

2021-03-10 Thread Jayashree S Kumar
> Issue > > https://bugs.openjdk.java.net/browse/JDK-8243376 > > Problem > > The scenario is: > - Some specified target hostname resolves to two IP addresses (always the > same address pair). > - The DNS resolved order of the two ip addresses changes (a usual > LoadBalancer type behavior).

Re: RFR: JDK-8243376: java.net.SocketPermission.implies(Permission p) spec is mismatching with implementation [v6]

2021-03-10 Thread Jayashree S Kumar
On Fri, 5 Mar 2021 15:47:43 GMT, Vyom Tewari wrote: >> Changes requested by michaelm (Reviewer). > > As you change equal & hashCode method, if possible can you please add some > additional tests in "jdk/java/net/SocketPermission/Equals.java" just to make > sure we test every corner case. I

Re: RFR: 8263080: Obsolete relationship in MulticastSocket API documentation. [v3]

2021-03-10 Thread Daniel Fuchs
> Now that DatagramSocket has been updated by JDK-8237352 to support joining > multicast group, this sentence in the API class level documentation of > MulticastSocket is obsolete and should be removed: > > "A MulticastSocket is a (UDP) DatagramSocket, with additional capabilities for >

Re: RFR: 8263080: Obsolete relationship in MulticastSocket API documentation. [v2]

2021-03-10 Thread Daniel Fuchs
On Wed, 10 Mar 2021 09:52:10 GMT, Patrick Concannon wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improved first sentence > > src/java.base/share/classes/java/net/MulticastSocket.java line 42: > >> 40: * that

Integrated: 8263233: Update java.net and java.nio to use instanceof pattern variable

2021-03-10 Thread Patrick Concannon
On Tue, 9 Mar 2021 11:07:07 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.net` > and `java.nio` packages to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick This pull request has now been integrated.

Re: RFR: 8263233: Update java.net and java.nio to use instanceof pattern variable [v3]

2021-03-10 Thread Michael McMahon
On Tue, 9 Mar 2021 19:56:25 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.net` >> and `java.nio` packages to make use of the `instanceof` pattern variable? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the

Re: RFR: 8263080: Obsolete relationship in MulticastSocket API documentation. [v2]

2021-03-10 Thread Patrick Concannon
On Tue, 9 Mar 2021 18:13:24 GMT, Daniel Fuchs wrote: >> Now that DatagramSocket has been updated by JDK-8237352 to support joining >> multicast group, this sentence in the API class level documentation of >> MulticastSocket is obsolete and should be removed: >> >> "A MulticastSocket is a

Re: RFR: 8263233: Update java.net and java.nio to use instanceof pattern variable [v3]

2021-03-10 Thread Chris Hegarty
On Tue, 9 Mar 2021 20:52:19 GMT, Mark Sheppard wrote: >> The disadvantage is that it would add another level of braces. > > maybe ... I find it would provide an easier flow to code ... an "easy on the > eye" call flow linkage - the variable is declared and then used instead > of the