Re: RFR: 8267990: Revisit some uses of `synchronized` in the HttpClient API [v2]

2021-05-31 Thread Daniel Fuchs
> The Utils.remaining(List list) method assumes that it can and > should synchronize on the given list to prevent concurrent modification. In > 99% of the cases this assumption is wrong. There's only one such list (the > SSLFlowDelegate writeList) that requires this synchronization. > > Also

Re: RFR: 8267990: Revisit some uses of `synchronized` in the HttpClient API

2021-05-31 Thread Chris Hegarty
On Mon, 31 May 2021 16:21:29 GMT, Daniel Fuchs wrote: > The Utils.remaining(List list) method assumes that it can and > should synchronize on the given list to prevent concurrent modification. In > 99% of the cases this assumption is wrong. There's only one such list (the > SSLFlowDelegate

RFR: 8267990: Revisit some uses of `synchronized` in the HttpClient API

2021-05-31 Thread Daniel Fuchs
The Utils.remaining(List list) method assumes that it can and should synchronize on the given list to prevent concurrent modification. In 99% of the cases this assumption is wrong. There's only one such list (the SSLFlowDelegate writeList) that requires this synchronization. Also the

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v6]

2021-05-31 Thread Lance Andersen
On Mon, 31 May 2021 15:02:57 GMT, Weijun Wang wrote: >> Please review this implementation of [JEP >> 411](https://openjdk.java.net/jeps/411). >> >> The code change is divided into 3 commits. Please review them one by one. >> >> 1. >>

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v6]

2021-05-31 Thread Weijun Wang
On Mon, 31 May 2021 15:02:57 GMT, Weijun Wang wrote: >> Please review this implementation of [JEP >> 411](https://openjdk.java.net/jeps/411). >> >> The code change is divided into 3 commits. Please review them one by one. >> >> 1. >>

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v6]

2021-05-31 Thread Weijun Wang
> Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. > https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1 > The essential change for this JEP,