Re: RFR: 8267840: Improve URLStreamHandler.parseURL() [v3]

2021-08-04 Thread Daniel Fuchs
On Mon, 5 Jul 2021 13:42:15 GMT, Сергей Цыпанов wrote: >> There is an optimization opportunity for the widespread use-case when a >> resource is read from classpath using >> `getClass().getClassLoader().getResource()` or >> `getClass().getClassLoader().getResourceAsStream()`. >> >> Pay

Re: RFR: 8270903: sun.net.httpserver.HttpConnection: Improve toString

2021-08-04 Thread Daniel Fuchs
On Wed, 4 Aug 2021 12:43:43 GMT, Chris Hegarty wrote: >> src/jdk.httpserver/share/classes/sun/net/httpserver/HttpConnection.java line >> 69: >> >>> 67: >>> 68: public String toString() { >>> 69: final var sb = new >>> StringBuilder(HttpConnection.class.getSimpleName()); >> >>

Re: RFR: 8267840: Improve URLStreamHandler.parseURL() [v3]

2021-08-04 Thread Daniel Fuchs
On Mon, 5 Jul 2021 13:42:15 GMT, Сергей Цыпанов wrote: >> There is an optimization opportunity for the widespread use-case when a >> resource is read from classpath using >> `getClass().getClassLoader().getResource()` or >> `getClass().getClassLoader().getResourceAsStream()`. >> >> Pay

Re: RFR: 8270903: sun.net.httpserver.HttpConnection: Improve toString

2021-08-04 Thread Chris Hegarty
On Wed, 4 Aug 2021 10:54:10 GMT, Daniel Fuchs wrote: >> This is a minor change that updates >> `sun.net.httpserver.HttpConnection::toString` to never return null. >> >> Testing: tier 1-3 all clear > > src/jdk.httpserver/share/classes/sun/net/httpserver/HttpConnection.java line > 69: > >> 67:

Re: RFR: 8270903: sun.net.httpserver.HttpConnection: Improve toString

2021-08-04 Thread Chris Hegarty
On Thu, 29 Jul 2021 10:22:51 GMT, Julia Boes wrote: > This is a minor change that updates > `sun.net.httpserver.HttpConnection::toString` to never return null. > > Testing: tier 1-3 all clear Marked as reviewed by chegar (Reviewer). - PR:

Re: RFR: 8270903: sun.net.httpserver.HttpConnection: Improve toString

2021-08-04 Thread Daniel Fuchs
On Thu, 29 Jul 2021 10:22:51 GMT, Julia Boes wrote: > This is a minor change that updates > `sun.net.httpserver.HttpConnection::toString` to never return null. > > Testing: tier 1-3 all clear src/jdk.httpserver/share/classes/sun/net/httpserver/HttpConnection.java line 69: > 67: > 68: