Re: RFR: 8276848: sun.net.httpserver.simpleserver.CommandLinePositiveTest: test does not specify port

2021-11-11 Thread Jaikiran Pai
On Thu, 11 Nov 2021 17:08:37 GMT, Julia Boes wrote: > This change corrects the server configuration in `testBindAllInterfaces` to > specify the port. Additionally, a manual test is added for the case where the > port is not specified and the server uses the default port 8000, which might >

Re: RFR: 8276848: sun.net.httpserver.simpleserver.CommandLinePositiveTest: test does not specify port

2021-11-11 Thread Daniel Fuchs
On Thu, 11 Nov 2021 17:08:37 GMT, Julia Boes wrote: > This change corrects the server configuration in `testBindAllInterfaces` to > specify the port. Additionally, a manual test is added for the case where the > port is not specified and the server uses the default port 8000, which might >

Re: RFR: 8277016: Use blessed modifier order in httpserver

2021-11-11 Thread Daniel Fuchs
On Thu, 11 Nov 2021 14:58:45 GMT, Magnus Ihse Bursie wrote: > I ran bin/blessed-modifier-order.sh on source in jdk.httpserver. This scripts > verifies that modifiers are in the "blessed" order, and fixes it otherwise. I > have manually checked the changes made by the script to make sure they

RFR: 8276848: sun.net.httpserver.simpleserver.CommandLinePositiveTest: test does not specify port

2021-11-11 Thread Julia Boes
This change corrects the server configuration in `testBindAllInterfaces` to specify the port. Additionally, a manual test is added for the case where the port is not specified and the server uses the default port 8000, which might already be in use by another test. To avoid this scenario and

RFR: 8277016: Use blessed modifier order in httpserver

2021-11-11 Thread Magnus Ihse Bursie
I ran bin/blessed-modifier-order.sh on source in jdk.httpserver. This scripts verifies that modifiers are in the "blessed" order, and fixes it otherwise. I have manually checked the changes made by the script to make sure they are sound. - Commit messages: - 8277016: Use blessed

Integrated: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI

2021-11-11 Thread Aleksei Efimov
On Tue, 5 Oct 2021 12:00:15 GMT, Aleksei Efimov wrote: > This change implements a new service provider interface for host name and > address resolution, so that java.net.InetAddress API can make use of > resolvers other than the platform's built-in resolver. > > The following API classes are

Re: RFR: 8276559: (httpclient) Consider adding an HttpRequest.Builder.HEAD method to build a HEAD request.

2021-11-11 Thread Jaikiran Pai
On Thu, 11 Nov 2021 12:05:49 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which implements the enhancement > noted in https://bugs.openjdk.java.net/browse/JDK-8276559? > > The commit in this PR introduces a new `HEAD()` method on the > `HttpRequest.Builder` interface.

RFR: 8276559: (httpclient) Consider adding an HttpRequest.Builder.HEAD method to build a HEAD request.

2021-11-11 Thread Jaikiran Pai
Can I please get a review for this change which implements the enhancement noted in https://bugs.openjdk.java.net/browse/JDK-8276559? The commit in this PR introduces a new `HEAD()` method on the `HttpRequest.Builder` interface. Given that this is a public interface on a public class of a

Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v13]

2021-11-11 Thread Aleksei Efimov
> This change implements a new service provider interface for host name and > address resolution, so that java.net.InetAddress API can make use of > resolvers other than the platform's built-in resolver. > > The following API classes are added to `java.net.spi` package to facilitate > this: >

Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v12]

2021-11-11 Thread Chris Hegarty
On Wed, 3 Nov 2021 13:23:36 GMT, Aleksei Efimov wrote: >> This change implements a new service provider interface for host name and >> address resolution, so that java.net.InetAddress API can make use of >> resolvers other than the platform's built-in resolver. >> >> The following API classes