RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770

2019-05-16 Thread Ao Qi
Hi, I found build is failed on CentOS 7.6, because of loop initial declarations. Could I please get reviews for this? Bug: https://bugs.openjdk.java.net/browse/JDK-8224028 Webrev: http://cr.openjdk.java.net/~aoqi/8224028/webrev.00/ Tested: linux-x86_64-server-release tier1 Thanks, Ao Qi

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

2019-05-16 Thread Ao Qi
> Thanks, > David > > On 16/05/2019 7:41 pm, Daniel Fuchs wrote: > > Hi Ao Qi, > > > > I'm adding serviceability-dev, since this is for jdwp. > > > > The proposed changes look good to me - but please get > > someone from the serviceability team to

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

2019-05-16 Thread Ao Qi
On Fri, May 17, 2019 at 12:44 AM [email protected] wrote: > > Hi Ao Qi, > > Thank you for the update. > It looks good to me. Thanks! > > Do you need a sponsor for integration? Yes:) > > Thanks, > Serguei > > > On 5/16/19 09:38, Alex Menkov wro

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

2019-05-17 Thread Ao Qi
Hi, Aleksey has helped to push: http://hg.openjdk.java.net/jdk/jdk/rev/3205f4c40716. Thank you all! Cheers, Ao Qi On Fri, May 17, 2019 at 8:19 AM David Holmes wrote: > > On 17/05/2019 9:14 am, Martin Buchholz wrote: > > On Thu, May 16, 2019 at 4:05 PM David Holmes > &l

RFR: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines

2021-09-30 Thread Ao Qi
When we do fastdebug testing with -Xcomp, sun/net/ftp/TestFtpTimeValue.java timed out on slow machines. The parameter of setSoTimeout in the test should be set larger. - Commit messages: - 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines Changes: https://git.o

Re: RFR: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines [v2]

2021-09-30 Thread Ao Qi
> When we do fastdebug testing with -Xcomp, sun/net/ftp/TestFtpTimeValue.java > timed out on slow machines. The parameter of setSoTimeout in the test should > be set larger. Ao Qi has updated the pull request incrementally with one additional commit since the last revision: update

Re: RFR: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines

2021-09-30 Thread Ao Qi
On Thu, 30 Sep 2021 11:37:41 GMT, Jie Fu wrote: >> When we do fastdebug testing with -Xcomp, sun/net/ftp/TestFtpTimeValue.java >> timed out on slow machines. The parameter of setSoTimeout in the test should >> be set larger. > > The copyright year? Updated. Thanks, @DamonFool :) -

Re: RFR: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines

2021-09-30 Thread Ao Qi
On Thu, 30 Sep 2021 11:37:41 GMT, Jie Fu wrote: >> When we do fastdebug testing with -Xcomp, sun/net/ftp/TestFtpTimeValue.java >> timed out on slow machines. The parameter of setSoTimeout in the test should >> be set larger. > > The copyright year? Thanks, @DamonFool @dfuch ! - P

Integrated: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines

2021-10-01 Thread Ao Qi
On Thu, 30 Sep 2021 11:14:18 GMT, Ao Qi wrote: > When we do fastdebug testing with -Xcomp, sun/net/ftp/TestFtpTimeValue.java > timed out on slow machines. The parameter of setSoTimeout in the test should > be set larger. This pull request has now been integrated. Changeset: b7b78f