Original Message
Subject: Re: Suppress creation of SocksSocketImpl in SocketAdaptor's
constructor
Date: Fri, 18 Nov 2011 16:38:28 +0800
From: Krystal Mok rednaxel...@gmail.com
To: 撒迦 sa...@taobao.com
CC: jdk8-...@openjdk.java.net jdk8-...@openjdk.java.net
Oops, looks like my
Hi Kris,
I think this change should be fine, but I would like Alan to comment also.
Thanks,
-Chris.
On 11/18/11 10:44 AM, Chris Hegarty wrote:
Original Message
Subject: Re: Suppress creation of SocksSocketImpl in SocketAdaptor's
constructor
Date: Fri, 18 Nov 2011 16:38
On 11/22/11 09:27 AM, Neil Richards wrote:
Hi Chris,
Thank you for creating the bug id for this issue.
I've now pushed the change [1].
However, I've just realised I've foolishly pushed a previous version of
the change, and not the final agreed version. (aargh!)
No problem. This happens
This CR is simply to cleanup the style of the java.net.HttpCookie source
code. This has bugged me for a while!
1) Remove extraneous newlines
2) Use consistent javadoc comment style
3) Fix typos in public specification, specifically:
http-HTTP, url-URL, seperated-separated, llegal-illegal
On 25/11/2011 05:58, Sean Chou wrote:
Yes. ping 0.0.0.0 on linux works; while windows report not reachable.
Right, so InetAddress.isReachable is reporting the same result as the
native ping command. Is this an issue for you guys?
-Chris.
On Tue, Nov 22, 2011 at 9:22 PM, Alan Bateman
Changeset: 387190e1f782
Author:chegar
Date: 2011-11-25 10:34 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/387190e1f782
7115150: java.net.HttpCookie code cleanup, style, formatting, typos
Reviewed-by: michaelm
! src/share/classes/java/net/HttpCookie.java
Changeset: e5ecbf555679
Author:chegar
Date: 2011-11-25 13:46 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e5ecbf555679
7115586: Suppress creation of SocketImpl in SocketAdaptor's constructor
Reviewed-by: chegar, alanb
Contributed-by: sa...@taobao.com
!
On 01/12/2011 10:21, Alan Bateman wrote:
On 01/12/2011 01:13, Charles Lee wrote:
Yes. In the customer scenario, the return value is 169.254.*.*/16 address.
Sorry for all the questions but I'm still scratching my head as to how
the lookup of the current host's name ends up with a list that
Changeset: 3b8186aee592
Author:chegar
Date: 2011-12-01 11:09 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b8186aee592
7116722: Miscellaneous warnings sun.misc ( and related classes )
Reviewed-by: alanb, darcy, forax, hawtin, lancea
!
Changeset: 37f6e294759f
Author:chegar
Date: 2011-12-02 14:17 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/37f6e294759f
7116957: javax.script.ScriptEngineManager should use java.util.ServiceLoader to
lookup service providers
Reviewed-by: alanb, lancea
!
Changeset: f352dd3cdff8
Author:dl
Date: 2011-12-05 13:58 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f352dd3cdff8
7117360: Warnings in java.util.concurrent.atomic package
Reviewed-by: chegar, dholmes
! src/share/classes/java/util/concurrent/atomic/AtomicBoolean.java
!
this issue? What is the
actual local system name? Is this name resolvable in the configured name
service ( DNS ) ?
Thanks,
-Chris.
On 12/ 2/11 07:45 AM, Charles Lee wrote:
On 12/01/2011 06:46 PM, Chris Hegarty wrote:
On 01/12/2011 10:21, Alan Bateman wrote:
On 01/12/2011 01:13, Charles Lee wrote
On 07/12/2011 11:12, Alan Bateman wrote:
On 07/12/2011 08:11, Charles Lee wrote:
:
I'd like to raise this issue again. The patch is on the [1]:
When a loopback network interface is bound to sendto and connect, in
some linuxes it will throw an EINVAL errno, in other linuxes (AIX,
iSeries) it
On 08/12/2011 03:16, Charles Lee wrote:
Hi Alan, hi Chris,
Thank you for reviewing this and creating a bug id for me. I have put a
revised webrev at http://cr.openjdk.java.net/~littlee/7118907/webrev.00/
http://cr.openjdk.java.net/%7Elittlee/7118907/webrev.00/ .
Looks fine to me.
Let
CR 7095980: Ensure HttpURLConnection (and supporting APIs) don't expose
HttpOnly cookies
The changes use the internal/private java.net.HttpCookie parsing
implementation to filter out HttpOnly cookies from the Set-Cookie and
Set-Cookie2 headers returned in the HTTP protocol handler. With this
Changeset: 33ac7a057b9c
Author:chegar
Date: 2011-12-16 16:09 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/33ac7a057b9c
7095980: Ensure HttpURLConnection (and supporting APIs) don't expose HttpOnly
cookies
Reviewed-by: michaelm
! src/share/classes/java/net/HttpCookie.java
During some of the warning cleanups the method declaration of the public
platform API java.net.ContentHandler.getContent(URLConnection, Class[])
was incorrectly changed. This CR proposes to revert this change fix
appropriate subclasses, so as not to re-introduce warnings in this area.
Thanks Alan. My editor was not showing these indentation issues. I will fix
them before pushing.
-Chris
Alan Bateman alan.bate...@oracle.com wrote:
On 28/12/2011 09:38, chris hegarty wrote:
During some of the warning cleanups the method declaration of the
public platform API
Changeset: 5aeefe0e5d8c
Author:chegar
Date: 2012-01-01 09:24 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5aeefe0e5d8c
7125055: ContentHandler.getContent API changed in error
Reviewed-by: alanb
! src/share/classes/java/net/ContentHandler.java
!
On 01/ 4/12 06:28 PM, Brandon Passanisi wrote:
Resending...
Sorry, I missed this first time round.
The change looks fine to me. Thanks for the contribution.
-Chris.
Hello net-dev. I was wondering if somebody could please review the
following proposed fix for 7123415:
Webrev URL:
Changeset: d72de8b3fe36
Author:chegar
Date: 2012-01-10 10:57 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d72de8b3fe36
7123415: Some cases of network interface indexes being read incorrectly
Reviewed-by: chegar
Contributed-by: brandon.passan...@oracle.com
!
Changeset: bba276a6aa0d
Author:chegar
Date: 2012-01-10 12:48 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bba276a6aa0d
7128584: Typo in sun.misc.VM's private directMemory field comment
Reviewed-by: forax, chegar
Contributed-by: Krystal Mok sa...@taobao.com
!
Since the integration of the HTTPOnly changes, CR 7095980, the map
returned by HttpURLConnection.getHeaderFields is not unmodifiable.
This is contradaction to the API specification.
URLConnection.getHeaderFields() : Returns an unmodifiable Map of the
header fields. The Map keys are Strings
Changeset: 31a1fc60a895
Author:chegar
Date: 2012-01-11 10:52 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31a1fc60a895
7128648: HttpURLConnection.getHeaderFields should return an unmodifiable Map
Reviewed-by: michaelm
!
The system-wide CookieHandler is read and stored in the
sun.net.www.http(s) HttpClient/HttpsClient instance. Since this
HttpClient/HttpsClient instance is cached and reused (where possible) as
part of the persistent/keep-alive connection implementation, it will not
reflect any changes made to
Changeset: e8a143213c65
Author:chegar
Date: 2012-01-16 18:05 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8a143213c65
7129083: CookieManager does not store cookies if url is read before setting
cookie manager
Reviewed-by: michaelm
!
Changeset: 40d699d7f6a1
Author:chegar
Date: 2012-01-17 14:10 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40d699d7f6a1
6671616: TEST_BUG: java/io/File/BlockIsDirectory.java fails when /dev/dsk empty
(sol)
Reviewed-by: alanb
! test/ProblemList.txt
-
Thanks for taking care of this Andrew.
-Chris.
On 23/01/2012 12:21, Xuelei Fan wrote:
Webrev: http://cr.openjdk.java.net/~xuelei/7132248/webrev.00/
In JDK 8, the regression tests of JSSE (HTTP/TLS) run in agentvm mode.
In agentvm mode, multiple threads may share the thread pool. SunJSSE
I'm OK with this as it, but here are a few comments:
The logic around the initial setting of the timeout seems a little
unnecessary (and the additional pointer), but not wrong.
The comments should also be updated.
Given this problem should the build be setting USE_SELECT?
-Chris.
On
Thanks the explanations. As I said, I'm fine with the change as is.
-Chris.
On 01/24/12 10:41 AM, Michael McMahon wrote:
On 24/01/12 10:23, Chris Hegarty wrote:
I'm OK with this as it, but here are a few comments:
The logic around the initial setting of the timeout seems a little
unnecessary
Michael,
Is it possible to initialize connectDisabled at the Java level using the
os.name system property, rather than in native. We do this in other
places in the impls ( albeit not for Mac yet ).
-Chris.
On 30/01/2012 09:49, Alan Bateman wrote:
.
I have updated this webrev because
Looks good, Thanks Michael.
-Chris.
On 30/01/2012 11:52, Michael McMahon wrote:
Chris,
Yes, that is more readable. I've updated the webrev here:
http://cr.openjdk.java.net/~michaelm/7122794/webrev.4/
Thanks
Michael.
On 30/01/12 10:27, Chris Hegarty wrote:
Michael,
Is it possible
Changeset: f9fb8c4b4550
Author:dl
Date: 2012-01-30 11:44 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9fb8c4b4550
7132378: Race in FutureTask if used with explicit set ( not Runnable )
Reviewed-by: chegar, dholmes
! src/share/classes/java/util/concurrent/FutureTask.java
Looks ok to me.
-Chris.
On 30/01/2012 09:48, Michael McMahon wrote:
Can I get the following webrev reviewed please?
http://cr.openjdk.java.net/~michaelm/7139770/webrev.1/
There are two issues. In DatagramSocket the change uses the peekData()
api when available, instead of peek(), which in
Looks good.
-Chris.
On 02/ 2/12 03:36 PM, Michael McMahon wrote:
Can I get the following change reviewed please?
http://cr.openjdk.java.net/~michaelm/7142123/webrev.1/
The fix for 7141335 (on Mac) caused a regression on all platforms
breaking the fix fo 6737819. This was testing a very
Changeset: bbadb6605a1c
Author:chegar
Date: 2012-02-04 07:29 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bbadb6605a1c
7041778: Move SCTP implementation out of sun.nio.ch and into its own package
Reviewed-by: alanb
! make/com/sun/nio/sctp/Exportedfiles.gmk
!
Changeset: c64c815974ff
Author:chegar
Date: 2012-02-08 11:16 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c64c815974ff
7105929: java/util/concurrent/FutureTask/BlockingTaskExecutor.java fails on
solaris sparc
Reviewed-by: dholmes
!
This seems to be an oversight in HttpURLConnection where the system-wide
ResponseCache handler is used to store responses even if getUsesCaches
returns false.
I guess this was never really noticed before since the cached response
will not be used if getUsesCaches returns false for future
Thanks for reporting this Jon.
I filed CR 7145043: HttpServerProvider.java:81: warning -
@code(httpServerProvider) is an unknown tag
You see quite a few of these type of RuntimePermission links through out
the core area. The intent is to link to RuntimePermission and show the
appropriate
Trivially, I don't think getDefaultScopeID needs it's implementation to
be ifdef'ed with MACOSX, at all. Then won't need the 'else return 0;'.
It is just a general utility method to get the value of the defaultIndex
field of NetworkInterace. Yes, the value will be 0 on all platforms
other
Looks fine to me.
-Chris.
On 02/14/12 07:12 PM, Kurchi Hazra wrote:
Updated webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.02/
- Kurchi
On 2/14/2012 12:58 AM, Chris Hegarty wrote:
Trivially, I don't think getDefaultScopeID needs it's implementation
to be ifdef'ed with MACOSX
Would it not make sense to fix the individual tests that are trying to
connect to 0.0.0.0, so they connect to the appropriate address/hostname?
The tests you changed use 127.0.0.1 rather than the localhost. Does
InetAddress.getLocalHost().getHostAddress() not return an appropriate
address? Or
OK, thanks.
I don't have a problem with this changes to get this working, but we
should probably review any tests that are trying to connect to 0.0.0.0.
-Chris.
On 02/17/12 02:41 PM, Michael McMahon wrote:
Chris,
On 17/02/12 13:45, Chris Hegarty wrote:
Would it not make sense to fix
Changeset: f67ff7b0f6ae
Author:chegar
Date: 2012-03-04 07:41 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f67ff7b0f6ae
7145043: HttpServerProvider.java:81: warning - @code(httpServerProvider) is
an unknown tag
Reviewed-by: michaelm
!
Changeset: e0bf958097e2
Author:chegar
Date: 2012-03-13 09:33 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e0bf958097e2
7152796: TEST_BUG: java/net/Socks/SocksV4Test.java does not terminate
Reviewed-by: alanb
! test/java/net/Socks/SocksServer.java
!
Changeset: 68efc74309f9
Author:chegar
Date: 2012-03-14 15:14 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68efc74309f9
7152948: DatagramDispatcher.c should memset msghdr to make it portable to other
platforms
Reviewed-by: alanb, chegar
Contributed-by: Shi Jun Zhang
Thanks Kurchi, the change look good to me.
This is a corner case and already covered by JCK, but it may be useful
to amend an existing test to check for this. Maybe
test/java/net/CookieHandler/NullUriCookieTest.java
CookieStore cookieStore = (new CookieManager()).getCookieStore();
+
Thanks Kurchi, looks good.
-Chris.
Kurchi Hazra kurchi.subhra.ha...@oracle.com wrote:
Hi Chris,
Updated webrev: http://cr.openjdk.java.net/~khazra/7045655/webrev.02/
- Kurchi
On 3/15/2012 2:49 AM, Chris Hegarty wrote:
Thanks Kurchi, the change look good to me.
This is a corner case
On 14/04/12 16:53, Alan Bateman wrote:
On 13/04/2012 17:59, Kurchi Hazra wrote:
Hi,
This test was failing on Windows since it was using the HttpServer in
test/sun/net/www/httptest. The HttpServer implementation
there is buggy and does not close the connection properly, resulting
in the test
Dmeetry,
Since this is non-normative text, and already in jdk6, I think we can
safely remove it.
For the record, I really hate these examples here. Sometime in the
future we should try cleaning up this spec, or make it very clear what
they are referring to.
Thanks,
-Chris.
On 16/04/2012
of
the headers ( just before the response body ) marked by CRLF CRLF. Is
OutputStreamWriter somehow appending a new line?
Sorry, I think at one time I pointed you to another test that may not
have been sending a valid HTTP response.
-Chris.
Thanks,
Kurchi
On 4/15/2012 12:35 AM, Chris Hegarty
needs an http server to handle LF gracefully,
although it expects a CRLF, and that is how this is working.
It is a small change, I will anyway correct it.
- Kurchi
On 4/17/12 3:24 AM, Chris Hegarty wrote:
On 16/04/12 22:18, Kurchi Hazra wrote:
Hi,
Thanks for the reviews. Here is an updated
On 17/04/12 19:47, Kurchi Hazra wrote:
Hi,
In Windows Vista and later, InterfaceAddress.getBroadcast() returns
0.0.0.0 , since these platforms return IF_TYPE_IEEE80211 instead of
MIB_IF_TYPE_ETHERNET for wireless interface type now. The fix is to
handle IF_TYPE_IEEE80211 in the relevant switch
On 17/04/12 20:14, Alan Bateman wrote:
On 17/04/2012 19:47, Kurchi Hazra wrote:
Hi,
In Windows Vista and later, InterfaceAddress.getBroadcast() returns
0.0.0.0 , since these platforms return IF_TYPE_IEEE80211 instead of
MIB_IF_TYPE_ETHERNET for wireless interface type now. The fix is to
handle
%29.aspx
Thanks,
Kurchi
On 4/17/2012 12:24 PM, Chris Hegarty wrote:
On 17/04/12 20:14, Alan Bateman wrote:
On 17/04/2012 19:47, Kurchi Hazra wrote:
Hi,
In Windows Vista and later, InterfaceAddress.getBroadcast() returns
0.0.0.0 , since these platforms return IF_TYPE_IEEE80211 instead
Kurchi,
The change looks fine to me. Thanks for forward porting.
Trivially, the indentation of getDefaultScopeID looks a little off.
Specifically, L121 in the new file:
ni_defaultIndexID = (*env)-GetStaticFieldID(env, c,
defaultIndex, I);
And
On 02/05/2012 19:10, Alan Bateman wrote:
On 27/04/2012 10:30, Deven You wrote:
Hi Alan,
I have updated the patch and test[1] for ::0. Please review it.
[1] http://cr.openjdk.java.net/~littlee/OJDK-217/webrev.03/
Thanks a lot!
Minor indentation issues, Inet4AddressImpl.c L684 and
On 03/05/2012 08:51, Alan Bateman wrote:
On 03/05/2012 08:46, Chris Hegarty wrote:
On the test, it would be good to run with it with
-Djava.net.preferIPv4Stack=true too, but ::0 should not be reachable.
I guess the test should check if preferIPv4Stack=true and skip testing
with ::0. Or only
Thanks Rob, this looks fine to me.
-Chris.
On 05/05/12 18:47, Rob McKenna wrote:
Hi folks,
A typo in the MacOSX work led to a regression in b11 of 7u4. Specifically:
http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/diff/5cca2f1a37da/src/solaris/native/java/net/Inet6AddressImpl.c
As per the bug
Changeset: abe465d6a9b8
Author:chegar
Date: 2012-06-08 09:55 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abe465d6a9b8
7175413: Typo in comments of JVM_SupportsCX8 in jvm.h
Reviewed-by: chegar
Contributed-by: Krystal Mok sa...@taobao.com
! src/share/javavm/export/jvm.h
On 13/06/2012 09:51, Alan Bateman wrote:
On 13/06/2012 09:38, Weijun Wang wrote:
Hi All
I have a test that basically looks like:
int p = new ServerSocket(0).getLocalPort();
//
new Socket(localhost, p);
Recently it's failing on solaris-i586, and after some investigation, I
realize that
itself or excessive resource hogging on the
system. But if you are really against it, I can live with what you have
;-)
-Chris.
Thanks
Max
On 06/13/2012 05:08 PM, Chris Hegarty wrote:
On 13/06/2012 09:51, Alan Bateman wrote:
On 13/06/2012 09:38, Weijun Wang wrote:
Hi All
I have a test
Changeset: efc2791d7c5d
Author:chegar
Date: 2012-06-19 10:20 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/efc2791d7c5d
6901992: InvalidJarIndexException due to bug in sun.misc.JarIndex.merge()
Reviewed-by: chegar
Contributed-by: dbel...@gmail.com
!
Looks fine to me.
-Chris.
On 20/06/2012 15:59, Michael McMahon wrote:
Could I get the following small change reviewed for 7u6?
http://cr.openjdk.java.net/~michaelm/7146564/webrev.1/
The change has been in 8 already for some time.
Thanks
Michael.
Sean,
The updated error messages look fine to me.
Are these all the possibly native OOM throw sites in the networking
area, or just some you came across?
-Chris.
On 21/06/2012 06:41, Sean Chou wrote:
Hi all,
We did some modification in these error messages because of some
user
Changeset: 4a4a04bfeece
Author:chegar
Date: 2012-06-25 14:19 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4a4a04bfeece
7176784: Windows authentication not working on some computers
Reviewed-by: michaelm
!
to error message
To: Chris Hegarty chris.hega...@oracle.com
Cc: net-dev@openjdk.java.net
Hi Chris,
They are not all native OOMs, I made a new one which includes all of
them. Please take a look.
webrev: http://cr.openjdk.java.net/~zhouyx/OJDK-528/webrev.01/
On Thu, Jun 21, 2012 at 5:23 PM, Chris
Seems like a reasonable candidate for a backport. Are you encountering it in 7?
-Chris
On 4 Jul 2012, at 15:19, Neil Richards neil.richa...@ngmr.net wrote:
On Fri, 2011-09-30 at 10:08 -0700, Kurchi Hazra wrote:
Hi,
The CookieStore.add() method throws a Null Pointer Exception when
On 17/07/2012 10:17, Michael McMahon wrote:
Hi,
Could I get the following change reviewed please?
http://cr.openjdk.java.net/~michaelm/7183292/webrev.1/
Since 7u4, we are parsing all incoming cookies via the HttpCookie class.
This class has had a restriction on cookie names that is causing
.
So, maybe we should just leave that out as well - assuming that it is
being used in places
(albeit in contravention of the older RFC). What do you think?
OK, if this change is intentional then that's fine. It just looked like
a side effect.
-Chris.
- Michael
On 17/07/2012 14:18, Chris
). What do you think?
- Michael
On 17/07/2012 14:18, Chris Hegarty wrote:
On 17/07/2012 10:17, Michael McMahon wrote:
Hi,
Could I get the following change reviewed please?
http://cr.openjdk.java.net/~michaelm/7183292/webrev.1/
Since 7u4, we are parsing all incoming cookies via the HttpCookie
Changeset: 2c2e4ecc8f7e
Author:chegar
Date: 2012-07-19 18:19 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c2e4ecc8f7e
7081476: test/java/net/InetSocketAddress/B6469803.java failing intermittently
Reviewed-by: chegar
Contributed-by: Eric Wang yiming.w...@oracle.com
!
[cc'ing net-dev mailing list]
Thanks for reporting this issue.
This looks like 7089443 [1], fixed in jdk8 via 7112670 [2]. Looks like
icetea needs to sync up, or maybe they are based against the jdk7 repo.
If so, this could be a good candidate to backport from jdk8 to jdk7 (
then I think
On 02/08/12 16:47, Andrew Hughes wrote:
- Original Message -
Thanks for the cross post David. Yes, net-dev is the best place to
discuss this issue ( bcc'ing off jdk7u-dev ).
Thanks for reporting this issue Christian. I haven't looked at the
proposed patch yet, but I agree we may want
On 08/08/2012 07:25, Sean Chou wrote:
Is it possible to have methods like
public abstract HTMLDocument getResponse(String request) in class
HttpClient ?
Hi Sean,
I think what you are suggesting is content specific convenience methods,
something akin to URLConnection.getContent(), right?
On 09/08/12 00:00, Jed Wesley-Smith wrote:
Michael McMahon michael.x.mcmahon@... writes:
A new revision of the Http client API planned for jdk 8 can be viewed
at the following link
http://cr.openjdk.java.net/~michaelm/httpclient/v0.3/
We would like to review the api on this mailing list.
So,
( not
necessarily a problem ), just need to think through the implications.
-Chris
On Wed, Aug 8, 2012 at 5:52 PM, Chris Hegarty chris.hega...@oracle.com
mailto:chris.hega...@oracle.com wrote:
On 08/08/2012 07:25, Sean Chou wrote:
Is it possible to have methods like
public
Wow, Mike. Great feedback.
I just scanned your comments, and agree/understand most of them. I'll
help Michael to feed them back into the API. Though, there'll probably
be a few follow up mails to answers your direct questions and seek
further clarification before the new rev of the API.
Michael,
Looking good, some comments.
1) Why the use of CookieManager, rather than CookieHandler? I would
expect that CookieHandler would be a cleaner API
2) What is the impact on the sendHeader, setBody for HEAD requests?
3) I think HttpClient could be an interface and move the create
the sanity builds and tests.
Thanks
-Shirish
On 8/9/2012 7:52 PM, Chris Hegarty wrote:
On 09/08/12 14:16, Shirish Kuncolienkar wrote:
I agree there is no general documentation available, AIX defines vipa
interface flag as 0x8000
In which case I don't see any problems with your proposed
On 10/08/12 17:28, Alan Bateman wrote:
On 10/08/2012 17:10, Chris Hegarty wrote:
Christian,
I finally got back to this.
Since init() is only ever called from the class initializer it is
implicitly single threaded, so we only need to add the synchronized
keyword to getSystemProxy().
I also
Changeset: e7d125f2575b
Author:chegar
Date: 2012-08-12 22:56 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7d125f2575b
7188755: Crash due to missing synchronization on gconf_client in
DefaultProxySelector.c
Reviewed-by: chegar
Contributed-by: Christian Schulte
Changeset: 399c2adf3ad6
Author:chegar
Date: 2012-08-13 13:41 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/399c2adf3ad6
7190254: NetworkInterface getFlags implementation should support full integer
bit range for flags value
Reviewed-by: chegar
Contributed-by: Shirish
On 14/08/12 13:11, Alan Bateman wrote:
On 14/08/2012 04:11, Frank Ding wrote:
On 8/7/2012 1:46 PM, Frank Ding wrote:
:
Could anybody take a look at my patch below and make comment?
http://cr.openjdk.java.net/~youdwei/ojdk-533/webrev.00/
Thanks Best regards,
Frank
Hi all,
Is there
confined to Franks's particular problem.
-Chris.
[1] http://bugs.sun.com/view_bug.do?bug_id=4742177
-Dmitry
On 2012-08-16 13:21, Frank Ding wrote:
On 8/14/2012 10:42 PM, Chris Hegarty wrote:
On 14/08/12 13:11, Alan Bateman wrote:
On 14/08/2012 04:11, Frank Ding wrote:
On 8/7/2012 1:46
On 16/08/12 10:21, Frank Ding wrote:
Hi Chris and Alan,
Thank you for taking time to help this issue. I have built using
latest openjdk 8 repo on Windows 64 and Linux 32/64. Since it's a macro
change in path src/solaris, I only did jtreg tests for Linux 32 and 64
build. The jtreg
Shirish,
Oooh, I'm not sure that any change to URL of this kind would be
compatible. It may have been desirable to have this kind of behavior
when URL was being originally created, but it is a legacy class, now
replaced with URI, and I'm not sure a change like this could be done in
a way to
Michael what you have looks good.
But, I think what Sam is suggesting ( or maybe not, but I like it ;-) ),
is something like this. (I'd need to think more about what effect this
has on the different modes, async/blocking )
class HttpResponse {
HttpResponse onHeaders(BlockHttpResponse);
On 22/08/12 21:05, Michael McMahon wrote:
On 22/08/12 15:29, Chris Hegarty wrote:
Michael what you have looks good.
But, I think what Sam is suggesting ( or maybe not, but I like it ;-)
), is something like this. (I'd need to think more about what effect
this has on the different modes, async
Paul,
All good feedback, and I will leave it to Michael to reply to the
specifics. On thought I had on separation of modes is something list this:
interface HeaderHandler {
onHeaders(HttpResponse);
}
interface ErrorHandler {
onError(HttpResponse, Throwable);
}
interface
Hi,
This is a request for approval to backport the fix for 7188755 from JDK8
to 7u8.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7188755
7188755: Crash due to missing synchronization on gconf_client in
DefaultProxySelector.c
JDK8 changeset:
Xuelei,
This looks very good. Just a few minor comments:
- SNIServerName hexes could be UPPERCASE, since it is a constant.
- Trivially, SNIHostName(String) calls IDN.toASCII(hostname) twice
It is not clear to me from this constructor whether it should
pass a hostname as understood by
Xuelei,
Thanks for addressing my comments. This looks fine to me.
-Chris.
On 04/09/12 06:01, Xuelei Fan wrote:
webrev: http://cr.openjdk.java.net/~xuelei/7068321/webrev_spec.10/
On 9/3/2012 9:22 PM, Chris Hegarty wrote:
Xuelei,
This looks very good. Just a few minor comments
Looks fine to me Eric.
-Chris.
On 05/09/2012 11:05, Eric Wang wrote:
Hi All,
Please help to review the fix below for bug 7032247
http://monaco.us.oracle.com/detail.jsf?cr=7032247.
http://dl.dropbox.com/u/90659131/fixes/7032247/webrev/index.html
As discussed, the test should pass silently if
Changeset: d5d24c08f0dc
Author:chegar
Date: 2012-09-07 14:00 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5d24c08f0dc
7032247: java/net/InetAddress/GetLocalHostWithSM.java fails if hostname
resolves to loopback address
Summary: TESTBUG
Reviewed-by: chegar, alanb
Changeset: 3857114d8255
Author:chegar
Date: 2012-09-07 15:30 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3857114d8255
6354758: rename old test HttpServer classes
Reviewed-by: chegar, michaelm, khazra
Contributed-by: John Zavgren john.zavg...@oracle.com
!
This CR is as a result of the changes for 6354758. The test needs to be
updated to use the new internal HTTP Server name, or better still remove
its dependency on the internal HTTP Server.
Also (while there) remove the script and extract the jar contents
programatically.
Changeset: e095be3820ee
Author:chegar
Date: 2012-09-13 11:17 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e095be3820ee
7197203: sun/misc/URLClassPath/ClassnameCharTest.sh failed, compile error
Reviewed-by: alanb
! test/sun/misc/URLClassPath/ClassnameCharTest.java
-
Changeset: 5d064862376d
Author:jgish
Date: 2012-09-19 08:52 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d064862376d
4722265: (spec str) StringBuffer.ensureCapacity() should mention that capacity
is mutable
Summary: add usage note to AbstractStringBuilder
Changeset: f5229879ea40
Author:chegar
Date: 2012-09-20 09:36 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f5229879ea40
7193520: Removed references to Linux kernel version 2.2
Summary: Linux kernel version 2.2 isn't supported anymore.
Reviewed-by: chegar, dsamersoff, alanb
201 - 300 of 1795 matches
Mail list logo
