Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-20 Thread Severin Gehwolf
Adding in net-dev. On Mon, 2015-04-20 at 14:02 +0200, Severin Gehwolf wrote: > Hi, > > Could I please get a review and a sponsor for the following patch? > > The issue is that JDK's internal /etc/resolv.conf nameserver parsing > does not properly account for IPv6 address

Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-20 Thread Severin Gehwolf
On Mon, 2015-04-20 at 12:24 -0400, Andrew Hughes wrote: > - Original Message - > > Adding in net-dev. > > > > On Mon, 2015-04-20 at 14:02 +0200, Severin Gehwolf wrote: > > > Hi, > > > > > > Could I please get a review and a sponsor for the

Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-22 Thread Severin Gehwolf
On Tue, 2015-04-21 at 16:09 +0100, Alan Bateman wrote: > On 21/04/2015 16:04, Michael McMahon wrote: > > On 21/04/15 14:56, Alan Bateman wrote: > >> : > >>> > >> Can the test be moved to jdk/test/com/sun/jndi/dns as that seems to > >> be where the other tests are? Also I assume this will need a >

Re: Bug in HttpClient

2018-07-20 Thread Severin Gehwolf
Adding net-dev On Fri, 2018-07-20 at 08:52 +0200, Thomas Lußnig wrote: > Hi, > i found an bug in JDK 10 with the new HttpClient. It does not handle > responses wihtout contentlength correctly. > Normally i would expect that the content is returned even without > content length. Since i can not ope

[8u] RFR: 8226928: [TESTBUG] test/java/net/NetworkInterface/IPv4Only.java fails intermittently on AIX

2019-06-28 Thread Severin Gehwolf
Hi, Please review this trivial test fix for JDK 8u. JDK 11u's version of the same test sets the property on the command line which doesn't have the issue on AIX. This patch makes JDK 11u and 8u aligned when it comes to IPv4Only.java test. I didn't backport the 11 change, as that's been part of a h

Re: [8u] RFR: 8226928: [TESTBUG] test/java/net/NetworkInterface/IPv4Only.java fails intermittently on AIX

2019-06-28 Thread Severin Gehwolf
On Fri, 2019-06-28 at 09:23 +, Langer, Christoph wrote: > Hi Severin, > > looks good, ship it 😊 Thanks, Christoph! Cheers, Severin > Thanks > Christoph > > > -Original Message- > > From: net-dev On Behalf Of Severin > > Gehwolf > >

Re: [11u] RFR: 8216562: UnknownBodyLength sometimes fails due to "Connection reset by peer"

2019-08-06 Thread Severin Gehwolf
Hi Christoph, On Tue, 2019-08-06 at 08:58 +, Langer, Christoph wrote: > Hi, > > please review the jdk11u backport of another fix for test > java/net/httpclient/UnknownBodyLengthTest.java. The patch did apply > mostly clean but needed some help in the import directives. Now the > change looks

[8u] RFR(XS): 8244461: [JDK 8u] Build fails with glibc 2.32

2020-05-08 Thread Severin Gehwolf
Hi, Please review this OpenJDK 8u (and 7u) specific patch which fixes a build failure with upcoming glibc 2.32 release. This isn't an issue in later JDKs because headers got cleaned up by JDK-8167481. Bringing this back into OpenJDK 8u together with dependencies for this two liner fix seems overki

Re: [8u] RFR(XS): 8244461: [JDK 8u] Build fails with glibc 2.32

2020-05-08 Thread Severin Gehwolf
Hi Andrew, On Fri, May 8, 2020 at 2:53 PM Andrew Haley wrote: > > On 5/8/20 9:07 AM, Severin Gehwolf wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8244461 > > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8244461/01/webrev/ > > > > Testi

[8u] RFR(m): 8194298: Add support for per Socket configuration of TCP keepalive

2020-06-25 Thread Severin Gehwolf
Hi, Please review this OpenJDK 8u backport of JDK-8194298 which adds socket configuration options for TCP keepalive. It's one of the Oracle JDK parity patches. As with the OpenJDK 11u change, this includes Linux and Mac only changes. This backport is pretty much a rewrite as the JDK 11u codebase

Re: [8u] RFR(m): 8194298: Add support for per Socket configuration of TCP keepalive

2020-06-26 Thread Severin Gehwolf
Hi, On Thu, 2020-06-25 at 23:55 +, Bernd Eckenfels wrote: > This would be a great addition. Thanks. > I do not understand why it does not support the options available for > Windows. Especially given the fact that it actually implements 6 > native methods to print "Unsupported". > > But I g

Re: [8u] RFR(m): 8194298: Add support for per Socket configuration of TCP keepalive

2020-06-29 Thread Severin Gehwolf
s "setTcpKeepAliveTime0 and > setTcpKeepAliveTime" for all three socket options ? Not really, other than keeping the backport aligned to the JDK 11u patch. I've updated it in the latest webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8194298/jdk8/05/webrev/ Than

Re: [8u] RFR(m): 8194298: Add support for per Socket configuration of TCP keepalive

2020-06-29 Thread Severin Gehwolf
relevant systems steps up to do it. > Please do let me know if i am missing something. FWIW, those options are only enabled on Linux/Mac for JDK 11u and jdk/jdk. Those changes would have to be done there first and then backported. Thanks, Severin > > On Mon, Jun 29, 2020 at 2:25 PM Seve

Re: [8u] RFR(m): 8194298: Add support for per Socket configuration of TCP keepalive

2020-06-29 Thread Severin Gehwolf
leError(env, rv, "get option " > SOCK_OPT_NAME_KEEPIDLE_STR " failed"); > +return optval; > + } > +#else > +JNU_ThrowByName(env, > "java/lang/UnsupportedOperationException", "unsupported socket > option"); > +#endif > +} >