Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v10]

2021-02-15 Thread Maurizio Cimadamore
On Mon, 15 Feb 2021 18:33:00 GMT, Andrey Turbanov wrote: >> 8080272 Refactor I/O stream copying to use >> InputStream.transferTo/readAllBytes and Files.copy > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8080272: Ref

Re: RFR: 8263561: Re-examine uses of LinkedList

2021-05-21 Thread Maurizio Cimadamore
On Fri, 21 May 2021 14:22:47 GMT, Daniel Fuchs wrote: >> The usage of `LinkedList` is senseless and can be replaced with either >> `ArrayList` or `ArrayDeque` which are both more compact and effective. >> >> jdk:tier1 and jdk:tier2 are both ok > > I don't remember all the comments you have rece

hg: jdk7/tl/langtools: 5 new changesets

2008-10-23 Thread maurizio . cimadamore
Changeset: 6508d7e812e1 Author:mcimadamore Date: 2008-10-23 17:59 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6508d7e812e1 6732484: Bound error on wildcard code Summary: Check.checkExtends should cope with captured type-variables Reviewed-by: jjg ! src/share/classes

hg: jdk7/tl/langtools: 4 new changesets

2008-10-24 Thread maurizio . cimadamore
Changeset: 5e54a59bcee7 Author:mcimadamore Date: 2008-10-24 12:45 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5e54a59bcee7 6680106: StackOverFlowError for Cyclic inheritance in TypeParameters with ArrayType Bounds Summary: Javac ends up in an infinite loop while att

hg: jdk7/tl/langtools: 6763518: Impossible to suppress raw-type warnings

2008-10-28 Thread maurizio . cimadamore
Changeset: 4f7b344a1ce0 Author:mcimadamore Date: 2008-10-28 14:05 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4f7b344a1ce0 6763518: Impossible to suppress raw-type warnings Summary: Check.validate(Type) should be invoked after -Xlint is augmented in Attr.visitVarDef

hg: jdk7/tl/langtools: 6768932: Add support for multiline diagnostics

2008-11-12 Thread maurizio . cimadamore
Changeset: 4cdaaf4c5dca Author:mcimadamore Date: 2008-11-12 14:17 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4cdaaf4c5dca 6768932: Add support for multiline diagnostics Summary: Added basic support for multiline/tabular diagnostics Reviewed-by: jjg ! src/share/clas

hg: jdk7/tl/langtools: 6776289: Regression: javac7 doesnt resolve method calls properly

2008-11-26 Thread maurizio . cimadamore
Changeset: 1d1f34b36535 Author:mcimadamore Date: 2008-11-26 11:07 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/1d1f34b36535 6776289: Regression: javac7 doesnt resolve method calls properly Summary: Superclass' private methods shouldn't be considered during method res

hg: jdk7/tl/langtools: 4 new changesets

2009-01-13 Thread maurizio . cimadamore
Changeset: 905e151a185a Author:mcimadamore Date: 2009-01-13 13:27 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/905e151a185a 6765045: Remove rawtypes warnings from langtools Summary: Removed all occurrences of rawtypes warnings from langtools Reviewed-by: jjg, bpatel

hg: jdk7/tl/langtools: 2 new changesets

2009-01-20 Thread maurizio . cimadamore
Changeset: 83c59a9d4b94 Author:mcimadamore Date: 2009-01-20 17:49 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/83c59a9d4b94 6795580: parser confused by square brackets in qualified generic cast Summary: Parser rejects cast with qualified generic array types Reviewed-b

hg: jdk7/tl/langtools: 3 new changesets

2009-01-29 Thread maurizio . cimadamore
Changeset: 1aa81917016a Author:mcimadamore Date: 2009-01-29 12:17 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/1aa81917016a 6315770: javac inference allows creation of strange types: Integer & Runnable Summary: Javac does not apply glb correctly as per JLS3 15.12.2.8

hg: jdk7/tl/langtools: 6769027: Source line should be displayed immediately after the first diagnostic line

2009-02-13 Thread maurizio . cimadamore
Changeset: 6ada6122dd4f Author:mcimadamore Date: 2009-02-13 11:57 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6ada6122dd4f 6769027: Source line should be displayed immediately after the first diagnostic line Summary: Added support for customizing diagnostic output v

hg: jdk7/tl/langtools: 4 new changesets

2009-03-05 Thread maurizio . cimadamore
Changeset: 850869f70213 Author:mcimadamore Date: 2009-03-05 17:24 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/850869f70213 6467183: javac fails to raise unchecked warning on cast of parameterized generic subclass Summary: cleanup code for generating unchecked cast w

hg: jdk7/tl/langtools: 3 new changesets

2009-03-25 Thread maurizio . cimadamore
Changeset: 5caa6c45936a Author:mcimadamore Date: 2009-03-25 10:28 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5caa6c45936a 6182950: methods clash algorithm should not depend on return type Summary: fixed code that checks for duplicate method declarations Reviewed-by:

hg: jdk7/tl/langtools: 6722234: javac diagnostics need better integration with the type-system

2009-05-21 Thread maurizio . cimadamore
Changeset: d402db1005ad Author:mcimadamore Date: 2009-05-21 10:56 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d402db1005ad 6722234: javac diagnostics need better integration with the type-system Summary: Added RichDiagnosticFormatter which provides better formatting

hg: jdk7/tl/langtools: 4 new changesets

2009-06-16 Thread maurizio . cimadamore
Changeset: a9c04a57a39f Author:mcimadamore Date: 2009-06-16 10:45 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a9c04a57a39f 6845686: basic and raw formatters do not display captured var id properly when javac runs in -XDoldDiags mode Summary: Basic and raw formatters

hg: jdk7/tl/langtools: 3 new changesets

2009-06-24 Thread maurizio . cimadamore
Changeset: 18e0269f25e3 Author:mcimadamore Date: 2009-06-24 10:50 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/18e0269f25e3 6822637: ResolveError hierarchy needs to be refactored Summary: Break ResolveError class into a hierarchy representing different kinds of resol

hg: jdk7/tl/langtools: 6846972: cannot access member of raw type when erasure change overriding into overloading

2009-07-15 Thread maurizio . cimadamore
Changeset: ad07b7ea9685 Author:mcimadamore Date: 2009-07-15 10:25 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ad07b7ea9685 6846972: cannot access member of raw type when erasure change overriding into overloading Summary: fix of 6400189 caused a nasty problem in met

hg: jdk7/tl/langtools: 6860795: NullPointerException when compiling a negative java source

2009-07-15 Thread maurizio . cimadamore
Changeset: 90d40dd5cfc7 Author:mcimadamore Date: 2009-07-15 17:01 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/90d40dd5cfc7 6860795: NullPointerException when compiling a negative java source Summary: Rich formatter shouldn't propagate visits on method symbols that ha

hg: jdk7/tl/langtools: 4 new changesets

2009-07-30 Thread maurizio . cimadamore
Changeset: 85fecace920b Author:mcimadamore Date: 2009-07-30 10:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/85fecace920b 6827648: Extremely slow compilation time for visitor pattern code + generics Summary: Javac unnecessarily recomputates type-substitutions multip

hg: jdk7/tl/langtools: 7 new changesets

2009-08-10 Thread maurizio . cimadamore
Changeset: d5f6c475f475 Author:mcimadamore Date: 2009-08-11 01:11 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d5f6c475f475 6806876: ClassCastException occurs in assignment expressions without any heap pollutions Summary: intersection types should be considered as no

hg: jdk7/tl/langtools: 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')

2009-08-27 Thread maurizio . cimadamore
Changeset: 8109aa93b212 Author:mcimadamore Date: 2009-08-27 13:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8109aa93b212 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond') Summary: diamond operator implementation (simple a

hg: jdk7/tl/langtools: 6650759: Inference of formal type parameter (unused in formal parameters) is not performed

2009-09-01 Thread maurizio . cimadamore
Changeset: dda7e13f09fb Author:mcimadamore Date: 2009-09-01 14:53 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/dda7e13f09fb 6650759: Inference of formal type parameter (unused in formal parameters) is not performed Summary: propagate inference constraints from 15.12.

hg: jdk7/tl/langtools: 2 new changesets

2010-04-14 Thread maurizio . cimadamore
Changeset: 396b117c1743 Author:mcimadamore Date: 2010-04-14 12:23 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/396b117c1743 6939618: Revert 'simple' diamond implementation Summary: backout changeset for 6840638 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac

hg: jdk7/tl/langtools: 6730476: invalid "unchecked generic array" warning

2010-04-21 Thread maurizio . cimadamore
Changeset: 04cf82179fa7 Author:mcimadamore Date: 2010-04-21 12:24 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/04cf82179fa7 6730476: invalid "unchecked generic array" warning Summary: Reifiable-ness of varargs element type should be checked after JLS3 15.12.2.8 Revie

hg: jdk7/tl/langtools: 4 new changesets

2010-05-19 Thread maurizio . cimadamore
Changeset: e9ef849ae0ed Author:mcimadamore Date: 2010-05-19 16:41 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e9ef849ae0ed 6880344: Recursive type parameters do not compile Summary: Issue in type-variable substitution causes valid code to be rejected Reviewed-by: jjg

hg: jdk7/tl/langtools: 6945418: Project Coin: Simplified Varargs Method Invocation

2010-06-10 Thread maurizio . cimadamore
Changeset: 46cf751559ae Author:mcimadamore Date: 2010-06-10 09:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/46cf751559ae 6945418: Project Coin: Simplified Varargs Method Invocation Summary: Add new mandatory warning for unsafe vararg method declaration. Warning ca

hg: jdk7/tl/langtools: 2 new changesets

2010-07-15 Thread maurizio . cimadamore
Changeset: b49b0d72c071 Author:mcimadamore Date: 2010-07-15 16:31 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b49b0d72c071 6967002: JDK7 b99 javac compilation error (java.lang.AssertionError) Summary: bug in JavacParser related to parsing of type annotations in varar

hg: jdk7/tl/langtools: 3 new changesets

2010-07-29 Thread maurizio . cimadamore
Changeset: 36c4ec4525b4 Author:mcimadamore Date: 2010-07-29 15:56 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/36c4ec4525b4 6938454: Unable to determine generic type in program that compiles under Java 6 Summary: a redundant dubtyping check causes spurious inference f

hg: jdk7/tl/langtools: 2 new changesets

2010-08-05 Thread maurizio . cimadamore
Changeset: 0fe472f4a332 Author:mcimadamore Date: 2010-08-05 09:44 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0fe472f4a332 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException Summary: default annotation value is not attributed Rev

hg: jdk7/tl/langtools: 2 new changesets

2010-08-10 Thread maurizio . cimadamore
Changeset: a2d8c7071f24 Author:mcimadamore Date: 2010-08-10 14:52 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a2d8c7071f24 6975275: diamond implementation needs some cleanup Summary: resolution issues during diamond inference should be reported through Resolve.logRe

hg: jdk7/tl/langtools: 2 new changesets

2010-08-16 Thread maurizio . cimadamore
Changeset: 27bae58329d5 Author:mcimadamore Date: 2010-08-16 14:56 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/27bae58329d5 6976649: javac does not enforce required annotation elements in arrays Summary: type annotation should take advantage of recursive annotation ch

hg: jdk7/tl/langtools: 3 new changesets

2010-08-19 Thread maurizio . cimadamore
Changeset: c655e0280bdc Author:mcimadamore Date: 2010-08-19 11:50 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c655e0280bdc 6886247: regression: javac crashes with an assertion error in Attr.java Summary: capture conversion does not work on nested types Reviewed-by: j

hg: jdk7/tl/langtools: 2 new changesets

2010-08-23 Thread maurizio . cimadamore
Changeset: 995bcdb9a41d Author:mcimadamore Date: 2010-08-23 16:59 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/995bcdb9a41d 6932571: Compiling Generics causing Inconvertible types Summary: Types.rewriteQuantifiers() does not work well with recursive type-variable bou

hg: jdk7/tl/langtools: 4 new changesets

2010-09-07 Thread maurizio . cimadamore
Changeset: 7ae4016c5938 Author:mcimadamore Date: 2010-09-07 17:31 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7ae4016c5938 6337171: javac should create bridge methods when type variable bounds restricted Summary: javac should add synthetic overrides for inherited abs

hg: jdk7/tl/langtools: 2 new changesets

2010-09-18 Thread maurizio . cimadamore
Changeset: 50f9ac2f4730 Author:mcimadamore Date: 2010-09-18 09:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/50f9ac2f4730 6980862: too aggressive compiler optimization causes stale results of Types.implementation() Summary: use a scope counter in order to determine

hg: jdk7/tl/langtools: 6863465: javac doesn't detect circular subclass dependencies via qualified names

2010-09-18 Thread maurizio . cimadamore
Changeset: 0c1ef2af7a8e Author:mcimadamore Date: 2010-09-18 14:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0c1ef2af7a8e 6863465: javac doesn't detect circular subclass dependencies via qualified names Summary: class inheritance circularity check should look at tre

hg: jdk7/tl/langtools: 6991980: polymorphic signature calls don't share the same CP entries

2010-10-18 Thread maurizio . cimadamore
Changeset: 493ecc8111ba Author:mcimadamore Date: 2010-10-18 19:14 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/493ecc8111ba 6991980: polymorphic signature calls don't share the same CP entries Summary: wrong use of attr env in Infer.java prevents sharing of CP entries

hg: jdk7/tl/langtools: 2 new changesets

2010-11-02 Thread maurizio . cimadamore
Changeset: 20659c8c917d Author:mcimadamore Date: 2010-11-02 12:00 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/20659c8c917d 6996415: Override bridges causes compiler-generated code to end up with synthetic infinite loop Summary: temporarily disable fix for override b

hg: jdk7/tl/langtools: 2 new changesets

2010-11-04 Thread maurizio . cimadamore
Changeset: f2048d9c666e Author:mcimadamore Date: 2010-11-04 12:57 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f2048d9c666e 6993963: Project Coin: Use precise exception analysis for effectively final catch parameters Summary: More precise rethrow analysis should be e

hg: jdk7/tl/langtools: 6996914: Diamond inference: problem when accessing protected constructor

2010-11-10 Thread maurizio . cimadamore
Changeset: bce19889597e Author:mcimadamore Date: 2010-11-10 12:37 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/bce19889597e 6996914: Diamond inference: problem when accessing protected constructor Summary: special resolution scheme for diamond inference needs to open

hg: jdk7/tl/langtools: 3 new changesets

2010-11-12 Thread maurizio . cimadamore
Changeset: 58ceeff50af8 Author:mcimadamore Date: 2010-11-12 12:32 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/58ceeff50af8 6598108: com.sun.source.util.Trees.isAccessible incorrect Summary: JavacTrees' version of isAccessible should take into account enclosing class

hg: jdk7/tl/langtools: 2 new changesets

2010-11-15 Thread maurizio . cimadamore
Changeset: a7ea58fa3e9a Author:mcimadamore Date: 2010-11-15 13:50 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a7ea58fa3e9a 6985719: Alike methods in interfaces (Inheritance and Overriding) Summary: javac should report error when interface inherits unrelated method w

hg: jdk7/tl/langtools: 6995200: JDK 7 compiler crashes when type-variable is inferred from expected primitive type

2010-11-23 Thread maurizio . cimadamore
Changeset: 2536dedd897e Author:mcimadamore Date: 2010-11-23 11:08 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2536dedd897e 6995200: JDK 7 compiler crashes when type-variable is inferred from expected primitive type Summary: 15.12.2.8 should use boxing when expected

hg: jdk7/tl/langtools: 2 new changesets

2010-12-03 Thread maurizio . cimadamore
Changeset: 9359f4222545 Author:mcimadamore Date: 2010-12-03 16:31 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9359f4222545 6956758: NPE in com.sun.tools.javac.code.Symbol - isSubClass Summary: Use of TransTypes.cast() instead of TransTypes.coerce() causes NPE in Low

hg: jdk7/tl/langtools: 3 new changesets

2010-12-06 Thread maurizio . cimadamore
Changeset: 5fb14e67c371 Author:mcimadamore Date: 2010-12-06 11:49 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5fb14e67c371 7003744: Compiler error concerning final variables Summary: Flow analysis does not cleanup init/uninint bit masks after for-loop Reviewed-by: jj

hg: jdk7/tl/langtools: 3 new changesets

2010-12-09 Thread maurizio . cimadamore
Changeset: 5ef88773462b Author:mcimadamore Date: 2010-12-09 15:50 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5ef88773462b 7005095: Cast: compile reject sensible cast from final class to interface Summary: a previous fix to cast conversion has made the compiler too s

hg: jdk7/tl/langtools: 2 new changesets

2010-12-10 Thread maurizio . cimadamore
Changeset: 2ca5866a8dfb Author:mcimadamore Date: 2010-12-10 15:23 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2ca5866a8dfb 7005671: Regression: compiler accepts invalid cast from X[] to primitive array Summary: regression in type conversion after 292 changes Reviewed

hg: jdk7/tl/langtools: 7006109: Add test library to simplify the task of writing automated type-system tests

2010-12-13 Thread maurizio . cimadamore
Changeset: 2199365892b1 Author:mcimadamore Date: 2010-12-13 14:56 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2199365892b1 7006109: Add test library to simplify the task of writing automated type-system tests Summary: Types.java needs to be more stress-tested Review

hg: jdk7/tl/langtools: 7010194: several langtools regression failures after JSR 292 changes (b123)

2011-01-05 Thread maurizio . cimadamore
Changeset: 15484cb7e5ae Author:mcimadamore Date: 2011-01-05 09:59 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/15484cb7e5ae 7010194: several langtools regression failures after JSR 292 changes (b123) Summary: Some regression tests rely on unsupported JSR 292 features

hg: jdk7/tl/langtools: 3 new changesets

2011-01-14 Thread maurizio . cimadamore
Changeset: 2d5aff89aaa3 Author:mcimadamore Date: 2011-01-14 09:45 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2d5aff89aaa3 6992698: JSR 292: remove support for transient syntax in polymorphic signature calls Summary: special syntax to denote indy return type through

hg: jdk7/tl/langtools: 5 new changesets

2011-01-24 Thread maurizio . cimadamore
Changeset: 19c900c703c6 Author:mcimadamore Date: 2011-01-24 15:44 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/19c900c703c6 6943278: spurious error message for inference and type-variable with erroneous bound Summary: type-inference should ignore erroneous bounds Rev

hg: jdk7/tl/langtools: 3 new changesets

2011-01-28 Thread maurizio . cimadamore
Changeset: 2088e674f0e0 Author:mcimadamore Date: 2011-01-28 12:01 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2088e674f0e0 6910550: javac 1.5.0_17 fails with incorrect error message Summary: multiple clashing members declared in same class should be added to the cla

hg: jdk7/tl/langtools: 4 new changesets

2011-02-03 Thread maurizio . cimadamore
Changeset: 899f7c3d9426 Author:mcimadamore Date: 2011-02-03 09:35 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/899f7c3d9426 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable Summary: Lint warnings generated during MemberEnter migh

hg: jdk7/tl/langtools: 2 new changesets

2011-02-07 Thread maurizio . cimadamore
Changeset: 3aa269645199 Author:mcimadamore Date: 2011-02-07 18:09 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3aa269645199 7017414: before the move of JSR 292 to package java.lang.invoke, javac must recognize the new package Summary: added support for future 292 pac

hg: jdk7/tl/langtools: 2 new changesets

2011-02-15 Thread maurizio . cimadamore
Changeset: 351027202f60 Author:mcimadamore Date: 2011-02-15 11:49 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/351027202f60 7017664: Add listeners infrastracture to javac scopes Summary: Add listeners to javac scopes, added CompoundScope and correct invalidation logi

hg: jdk7/tl/langtools: 7020043: Project Coin: diamond allowed on non-generic type

2011-02-18 Thread maurizio . cimadamore
Changeset: 4ce95dc0b908 Author:mcimadamore Date: 2011-02-18 12:28 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4ce95dc0b908 7020043: Project Coin: diamond allowed on non-generic type Summary: Diamond oerator should be disallowed on non-generic class types (i.e. Strin

hg: jdk7/tl/langtools: 7020626: diamond: add diagnostic test for diamond and non-generic classes

2011-02-18 Thread maurizio . cimadamore
Changeset: 51e643f41a3a Author:mcimadamore Date: 2011-02-18 16:17 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/51e643f41a3a 7020626: diamond: add diagnostic test for diamond and non-generic classes Summary: Fix failure in regression test CheckExamples Reviewed-by: jjg

hg: jdk7/tl/langtools: 2 new changesets

2011-02-23 Thread maurizio . cimadamore
Changeset: 015dc9a63efc Author:mcimadamore Date: 2011-02-23 14:16 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/015dc9a63efc 7020657: Javac rejects a fairly common idiom with raw override and interfaces Summary: name clash should not be reported if subinterface/impleme

hg: jdk7/tl/langtools: 2 new changesets

2011-02-28 Thread maurizio . cimadamore
Changeset: 9286a5d1fae3 Author:mcimadamore Date: 2011-02-28 11:48 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9286a5d1fae3 7015430: Incorrect thrown type determined for unchecked invocations Summary: Thrown types do not get updated after 15.12.2.8, and do not get era

hg: jdk7/tl/langtools: 6541876: "Enclosing Instance" error new in 1.6

2011-03-02 Thread maurizio . cimadamore
Changeset: 02b699d97a55 Author:mcimadamore Date: 2011-03-02 10:56 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/02b699d97a55 6541876: "Enclosing Instance" error new in 1.6 Summary: unqualified 'this' should not be selected in a qualified super() call in a default cons

hg: jdk7/tl/langtools: 7023233: False positive for -Xlint:try with nested try with resources blocks

2011-03-03 Thread maurizio . cimadamore
Changeset: e9b8fbb30f5a Author:mcimadamore Date: 2011-03-03 09:43 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e9b8fbb30f5a 7023233: False positive for -Xlint:try with nested try with resources blocks Summary: Wrong lint warning issued about unused resource when neste

hg: jdk7/tl/langtools: 2 new changesets

2011-03-03 Thread maurizio . cimadamore
Changeset: c15d788cb381 Author:mcimadamore Date: 2011-03-03 17:32 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c15d788cb381 7023703: Valid code doesn't compile Summary: leftovers cause problems when analyzing loops in Flow.java Reviewed-by: jjg ! src/share/classes/co

hg: jdk7/tl/langtools: 7024212: TestWarnErrorCount fails

2011-03-03 Thread maurizio . cimadamore
Changeset: 8fb48a9ac9ec Author:mcimadamore Date: 2011-03-03 18:05 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8fb48a9ac9ec 7024212: TestWarnErrorCount fails Summary: TestWarnErrorCount should be executed with -Xlint:all,-path to avoid spurious failures Reviewed-by:

hg: jdk7/tl/langtools: 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes

2011-03-07 Thread maurizio . cimadamore
Changeset: ca32f2986301 Author:mcimadamore Date: 2011-03-07 14:31 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ca32f2986301 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes Summary: Disallow diamond on anonymous innner class creation ex

hg: jdk7/tl/langtools: 7024568: Very long method resolution causing OOM error

2011-03-07 Thread maurizio . cimadamore
Changeset: 74f0c05c51eb Author:mcimadamore Date: 2011-03-07 14:11 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/74f0c05c51eb 7024568: Very long method resolution causing OOM error Summary: Resolve.findMethod scans same receiver type more than once in certain inheritan

hg: jdk7/tl/langtools: 7025988: Test test/tools/javac/file/zip/T6836682.java takes too long to complete

2011-03-09 Thread maurizio . cimadamore
Changeset: 4fd20d5b7295 Author:mcimadamore Date: 2011-03-09 16:47 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4fd20d5b7295 7025988: Test test/tools/javac/file/zip/T6836682.java takes too long to complete Summary: added @ignore tag to temporarily disable the test Revi

hg: jdk7/tl/langtools: 6558548: The compiler needs to be aligned with clarified specification of throws

2011-03-16 Thread maurizio . cimadamore
Changeset: 5b29f2a85085 Author:mcimadamore Date: 2011-03-16 11:12 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5b29f2a85085 6558548: The compiler needs to be aligned with clarified specification of throws Summary: Javac should issue unconditional warnings when 'dead'

hg: jdk7/tl/langtools: 4 new changesets

2011-03-29 Thread maurizio . cimadamore
Changeset: 2007998f89f2 Author:mcimadamore Date: 2011-03-29 16:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2007998f89f2 7030687: Diamond: compiler accepts erroneous code where diamond is used with non-generic inner class Summary: Diamond accepts non-parameterized

hg: jdk7/tl/langtools: 7032633: javac -Xlint:all warns about flush() within try on an auto-closeable resource

2011-04-01 Thread maurizio . cimadamore
Changeset: b945b846c979 Author:mcimadamore Date: 2011-04-01 12:30 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b945b846c979 7032633: javac -Xlint:all warns about flush() within try on an auto-closeable resource Summary: missing name check before calling MethodSymbol.

hg: jdk7/tl/langtools: 2 new changesets

2011-04-12 Thread maurizio . cimadamore
Changeset: f00986f55961 Author:mcimadamore Date: 2011-04-12 20:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f00986f55961 7034511: Loophole in typesafety Summary: Type-variable substutution takes upper bound of replaced captured type-variable Reviewed-by: dlsmith

hg: jdk7/tl/langtools: 7036906: Scope: CompoundScope.getElements() doesn't pass scope filter to subscopes

2011-04-19 Thread maurizio . cimadamore
Changeset: 671bb63f3ed5 Author:mcimadamore Date: 2011-04-19 13:57 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/671bb63f3ed5 7036906: Scope: CompoundScope.getElements() doesn't pass scope filter to subscopes Summary: CompoundScope.getElements() is not filtering elemen

hg: jdk7/tl/langtools: 4 new changesets

2011-04-29 Thread maurizio . cimadamore
Changeset: 4c03383f6529 Author:mcimadamore Date: 2011-04-29 16:05 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4c03383f6529 7040104: javac NPE on Object a[]; Object o = (a=null)[0]; Summary: When a null literal is found on top of stack, if expected type is 1-dimensio

hg: jdk7/tl/langtools: 7039931: Project Coin: diamond inference fail with generic constructor explicit type-arguments

2011-04-30 Thread maurizio . cimadamore
Changeset: 4caf17560ae0 Author:mcimadamore Date: 2011-04-30 11:57 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4caf17560ae0 7039931: Project Coin: diamond inference fail with generic constructor explicit type-arguments Summary: diamond should be disallowed in cases w

hg: jdk7/tl/langtools: 7040883: Compilation error: "length in Array is defined in an inaccessible class or interface"

2011-05-02 Thread maurizio . cimadamore
Changeset: 384ea9a98912 Author:mcimadamore Date: 2011-05-02 12:05 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/384ea9a98912 7040883: Compilation error: "length in Array is defined in an inaccessible class or interface" Summary: Fix of 7034511 (now backed out) is caus

hg: jdk7/tl/langtools: 2 new changesets

2011-05-11 Thread maurizio . cimadamore
Changeset: a2d422d480cb Author:mcimadamore Date: 2011-05-11 13:10 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a2d422d480cb 7042566: Regression: new ambiguity between varargs method Summary: Erroneous ambiguity error when choosing most specific varargs method Reviewed

hg: jdk7/tl/langtools: 7043922: Regression: internal compiler error for nested anonymous inner class featuring varargs constructor

2011-05-16 Thread maurizio . cimadamore
Changeset: 5faa9eedc44e Author:mcimadamore Date: 2011-05-16 09:38 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5faa9eedc44e 7043922: Regression: internal compiler error for nested anonymous inner class featuring varargs constructor Summary: Attributing a constructor

hg: jdk7/tl/langtools: 7046348: Regression: javac complains of missing classfile for a seemingly unrelated interface

2011-05-23 Thread maurizio . cimadamore
Changeset: 6bb526ccf5ff Author:mcimadamore Date: 2011-05-23 11:55 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6bb526ccf5ff 7046348: Regression: javac complains of missing classfile for a seemingly unrelated interface Summary: Types.implementation forces unnecessary

hg: jdk8/tl/langtools: 3 new changesets

2011-07-27 Thread maurizio . cimadamore
Changeset: 0b5beb9562c6 Author:mcimadamore Date: 2011-07-27 19:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0b5beb9562c6 7062745: Regression: difference in overload resolution when two methods are maximally specific Summary: Fix most specific when two methods are

hg: jdk8/tl/langtools: 2 new changesets

2011-08-31 Thread maurizio . cimadamore
Changeset: b86277584776 Author:mcimadamore Date: 2011-08-31 16:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b86277584776 7085024: internal error; cannot instantiate Foo Summary: Types.isConvertible does not handle erroneous types correctly Reviewed-by: jjg ! src/s

hg: jdk8/tl/langtools: 7086261: javac doesn't report error as expected, it only reports ClientCodeWrapper$DiagnosticSourceUnwrapper

2011-09-02 Thread maurizio . cimadamore
Changeset: ec27e5befa53 Author:mcimadamore Date: 2011-09-02 17:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec27e5befa53 7086261: javac doesn't report error as expected, it only reports ClientCodeWrapper$DiagnosticSourceUnwrapper Summary: Missing override for toSt

hg: jdk8/tl/langtools: 3 new changesets

2011-09-13 Thread maurizio . cimadamore
Changeset: ed338593b0b6 Author:mcimadamore Date: 2011-09-13 14:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ed338593b0b6 7086595: Error message bug: name of initializer is 'null' Summary: Implementation of MethodSymbol.location() should take into account static/in

hg: jdk8/tl/langtools: 7086586: Inference producing null type argument

2011-09-16 Thread maurizio . cimadamore
Changeset: c0835c8489b0 Author:mcimadamore Date: 2011-09-16 14:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c0835c8489b0 7086586: Inference producing null type argument Summary: Inference should fail in 15.12.2.7 when inference variables with 'nulltype' upper boun

hg: jdk8/tl/langtools: 7090499: missing rawtypes warnings in anonymous inner class

2011-10-06 Thread maurizio . cimadamore
Changeset: 47147081d5b4 Author:mcimadamore Date: 2011-10-06 18:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/47147081d5b4 7090499: missing rawtypes warnings in anonymous inner class Summary: javac does not detect raw types inside anonymous inner classes Reviewed-by:

hg: jdk8/tl/langtools: 2 new changesets

2011-10-17 Thread maurizio . cimadamore
Changeset: b5d0b8effc85 Author:mcimadamore Date: 2011-10-17 12:54 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b5d0b8effc85 7097436: Project Coin: duplicate varargs warnings on method annotated with @SafeVarargs Summary: Duplicate aliasing check during subtyping lead

hg: jdk8/tl/langtools: 7102515: javac running very very long and not returning

2011-10-19 Thread maurizio . cimadamore
Changeset: 366c233eb838 Author:mcimadamore Date: 2011-10-19 16:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/366c233eb838 7102515: javac running very very long and not returning Summary: Verbose resolution diagnostics slow down with operator resolution Reviewed-by:

hg: jdk8/tl/langtools: 2 new changesets

2011-10-24 Thread maurizio . cimadamore
Changeset: d346ab55031b Author:mcimadamore Date: 2011-10-24 13:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d346ab55031b 7096014: Javac tokens should retain state Summary: Refactor javac tokens from enum constants to stateful instances (to keep track of position,

hg: jdk8/tl/langtools: 7104618: MessageInfo.java is failing after lexer changes

2011-10-25 Thread maurizio . cimadamore
Changeset: b73a9be0b993 Author:mcimadamore Date: 2011-10-25 15:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b73a9be0b993 7104618: MessageInfo.java is failing after lexer changes Summary: Two langtools regression tests cannot be built due to a bad import statement

hg: jdk8/tl/langtools: 7104201: Refactor DocCommentScanner

2011-11-04 Thread maurizio . cimadamore
Changeset: 56830d5cb5bb Author:mcimadamore Date: 2011-11-04 12:36 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/56830d5cb5bb 7104201: Refactor DocCommentScanner Summary: Add new Comment helper class to parse contents of comments in source code Reviewed-by: jjg ! src/

hg: jdk8/tl/langtools: 2 new changesets

2011-11-24 Thread maurizio . cimadamore
Changeset: c896d95e7469 Author:mcimadamore Date: 2011-11-24 13:36 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c896d95e7469 7115046: Add AST node for lambda expressions Summary: Add tree nodes for representing lambda expressions and update relevant visitors interface

hg: jdk8/tl/langtools: 2 new changesets

2011-11-28 Thread maurizio . cimadamore
Changeset: 9448fe783fd2 Author:mcimadamore Date: 2011-11-28 15:56 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9448fe783fd2 7115050: Add parser support for lambda expressions Summary: Add support for parsing lambda expressions to JavacParser Reviewed-by: jjg ! src/sh

hg: jdk8/tl/jdk: 7116954: Misc warnings in java.beans/java.beans.context

2011-12-01 Thread maurizio . cimadamore
Changeset: 89130611b178 Author:mcimadamore Date: 2011-12-01 18:34 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89130611b178 7116954: Misc warnings in java.beans/java.beans.context Summary: Remove generic warnings form java.beans and java.beans.context Reviewed-by: alanb, ch

hg: jdk8/tl/langtools: 7120266: javac fails to compile hotspot code

2011-12-11 Thread maurizio . cimadamore
Changeset: e55270a7a022 Author:mcimadamore Date: 2011-12-11 17:48 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e55270a7a022 7120266: javac fails to compile hotspot code Summary: Parser changes for method references cause bad intercation with method call syntax Review

hg: jdk8/tl/langtools: 7120463: Fix method reference parser support in order to avoid ambiguities

2011-12-19 Thread maurizio . cimadamore
Changeset: 1ae5988e201b Author:mcimadamore Date: 2011-12-19 12:07 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1ae5988e201b 7120463: Fix method reference parser support in order to avoid ambiguities Summary: Add lookahead routine to disambiguate between method referen

hg: jdk8/tl/langtools: 7126754: Generics compilation failure casting List to List

2012-01-11 Thread maurizio . cimadamore
Changeset: 70d92518063e Author:mcimadamore Date: 2012-01-11 18:23 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/70d92518063e 7126754: Generics compilation failure casting List to List Summary: Problems with Types.rewriteQuantifiers not preserving variance Reviewed-by:

hg: jdk8/tl/langtools: 7123100: javac fails with java.lang.StackOverflowError

2012-01-12 Thread maurizio . cimadamore
Changeset: 133744729455 Author:mcimadamore Date: 2012-01-12 15:28 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/133744729455 7123100: javac fails with java.lang.StackOverflowError Summary: Inference of under-constrained type-variables creates erroneous recursive wildc

hg: jdk8/tl/langtools: 7129801: Merge the two method applicability routines

2012-01-24 Thread maurizio . cimadamore
Changeset: 51fb17abfc32 Author:mcimadamore Date: 2012-01-24 17:52 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/51fb17abfc32 7129801: Merge the two method applicability routines Summary: Resolve.java and Infer.java should reuse the same method applicability check rout

hg: jdk8/tl/langtools: 7142086: performance problem in Check.checkOverrideClashes(...)

2012-02-14 Thread maurizio . cimadamore
Changeset: 84b61130cbed Author:mcimadamore Date: 2012-02-14 15:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/84b61130cbed 7142086: performance problem in Check.checkOverrideClashes(...) Summary: Code in Check.checkOverrideClashes() causes too many calls to MethodSy

hg: jdk8/tl/langtools: 3 new changesets

2012-03-02 Thread maurizio . cimadamore
Changeset: 161230ec7c73 Author:mcimadamore Date: 2012-03-02 12:57 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/161230ec7c73 7132880: Resolve should support nested resolution contexts Summary: Overload resolution routine should be updated so that it can be called recu

hg: jdk8/tl/langtools: 3 new changesets

2012-03-06 Thread maurizio . cimadamore
Changeset: dda6a5b15580 Author:mcimadamore Date: 2012-03-06 13:26 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dda6a5b15580 7148622: Some diagnostic methods do not go through Log.report Summary: Deferred lint diagnostics ignore Log settings such as deferred diagnosti

hg: jdk8/tl/langtools: 2 new changesets

2012-03-06 Thread maurizio . cimadamore
Changeset: c2234816495f Author:mcimadamore Date: 2012-03-06 16:48 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c2234816495f 7151070: NullPointerException in Resolve.isAccessible Summary: Spurious accessibility check in TransTypes Reviewed-by: jjg ! src/share/classes/

  1   2   >