RE: RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache

2017-10-19 Thread Langer, Christoph
et-dev@openjdk.java.net Subject: Re: RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache Hi Christoph, Right, my mistake, I meant CME. My point was that ArrayDeque does not throw CME from remove(). It is not multi-thread safe and does not check for CME. That remove might hav

Re: RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache

2017-10-18 Thread Roger Riggs
. Oktober 2017 17:28 *To:* Langer, Christoph <christoph.lan...@sap.com>; net-dev@openjdk.java.net *Subject:* Re: RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache Hi Christoph, Looks ok. The comment in remove() about CCE can be removed. ArrayDeque is not

RE: RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache

2017-10-18 Thread Langer, Christoph
...@oracle.com] Sent: Mittwoch, 18. Oktober 2017 17:28 To: Langer, Christoph <christoph.lan...@sap.com>; net-dev@openjdk.java.net Subject: Re: RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache Hi Christoph, Looks ok. The comment in remove() about CCE can be r

Re: RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache

2017-10-18 Thread Roger Riggs
et-dev-boun...@openjdk.java.net] *On Behalf Of *Roger Riggs *Sent:* Dienstag, 17. Oktober 2017 16:53 *To:* net-dev@openjdk.java.net *Subject:* Re: RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache Hi, Keep the synchronized, it will be low overhead since the

RE: RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache

2017-10-18 Thread Langer, Christoph
-boun...@openjdk.java.net] On Behalf Of Roger Riggs Sent: Dienstag, 17. Oktober 2017 16:53 To: net-dev@openjdk.java.net Subject: Re: RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache Hi, Keep the synchronized, it will be low overhead since the Vector operations

Re: RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache

2017-10-17 Thread Roger Riggs
*From:*net-dev [mailto:net-dev-boun...@openjdk.java.net] *On Behalf Of *vyom tewari *Sent:* Montag, 16. Oktober 2017 10:27 *To:* net-dev@openjdk.java.net *Subject:* Re: RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache Hi Christoph, Thanks for doing this, i

RE: RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache

2017-10-16 Thread Langer, Christoph
nt: Montag, 16. Oktober 2017 10:27 To: net-dev@openjdk.java.net Subject: Re: RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache Hi Christoph, Thanks for doing this, i think you don't need to synchronize the "remove(HttpClient h)". This remove is get cal

Re: RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache

2017-10-16 Thread vyom tewari
Hi Christoph, Thanks for doing this, i think you don't need to synchronize the "remove(HttpClient h)".  This remove is get called from synchronize "remove (HttpClient h, Object obj)" and the underline data structure is which is java.util.Vector(ClientVector extends java.util.Stack) is also

RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache

2017-10-16 Thread Langer, Christoph
Hi, Here is a proposal for a fix for bug 8155590. I already made this fix a while ago in our JDK clone and I'd like to contribute this. Bug: https://bugs.openjdk.java.net/browse/JDK-8155590 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8155590.0/ Please review. Thanks Christoph