Re: RFR: 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head [v4]

2021-03-24 Thread Chris Hegarty
On Tue, 23 Mar 2021 13:45:06 GMT, Michael McMahon wrote: >> Could I get the following simple fix reviewed please? >> >> The bug is jdk.internal.net.http.AuthenticationFilter throws an NPE wrapped >> in an IOException if it receives a HTTP response containing a >> WWW-Authenticate header with

Re: RFR: 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head [v3]

2021-03-24 Thread Daniel Fuchs
On Wed, 24 Mar 2021 11:06:47 GMT, Michael McMahon wrote: >> test/jdk/java/net/httpclient/EmptyAuthenticate.java line 63: >> >>> 61: //run client: >>> 62: try { >>> 63: HttpClient httpClient = HttpClient.newHttpClient(); >> >> Hmmm... Does this happen even when

Re: RFR: 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head [v4]

2021-03-24 Thread Daniel Fuchs
On Tue, 23 Mar 2021 13:45:06 GMT, Michael McMahon wrote: >> Could I get the following simple fix reviewed please? >> >> The bug is jdk.internal.net.http.AuthenticationFilter throws an NPE wrapped >> in an IOException if it receives a HTTP response containing a >> WWW-Authenticate header with

Re: RFR: 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head [v3]

2021-03-24 Thread Michael McMahon
On Mon, 22 Mar 2021 10:31:19 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix whitespace error > > test/jdk/java/net/httpclient/EmptyAuthenticate.java line 63: > >> 61: //run

Re: RFR: 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head [v3]

2021-03-24 Thread Daniel Fuchs
On Mon, 22 Mar 2021 10:06:08 GMT, Michael McMahon wrote: >> Could I get the following simple fix reviewed please? >> >> The bug is jdk.internal.net.http.AuthenticationFilter throws an NPE wrapped >> in an IOException if it receives a HTTP response containing a >> WWW-Authenticate header with

Re: RFR: 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head [v3]

2021-03-22 Thread Michael McMahon
> Could I get the following simple fix reviewed please? > > Thanks, > Michael. Michael McMahon has updated the pull request incrementally with one additional commit since the last revision: fix whitespace error - Changes: - all:

Re: RFR: 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head [v2]

2021-03-22 Thread Michael McMahon
On Mon, 22 Mar 2021 09:40:43 GMT, Chris Hegarty wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >>

Re: RFR: 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head [v2]

2021-03-22 Thread Michael McMahon
> Could I get the following simple fix reviewed please? > > Thanks, > Michael. Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four

Re: RFR: 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head

2021-03-22 Thread Chris Hegarty
On Mon, 22 Mar 2021 09:26:08 GMT, Michael McMahon wrote: > Could I get the following simple fix reviewed please? > > Thanks, > Michael. test/jdk/java/net/httpclient/EmptyAuthenticate.java line 44: > 42: > 43: public static void main(String[] args) throws IOException, >

RFR: 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head

2021-03-22 Thread Michael McMahon
Could I get the following simple fix reviewed please? Thanks, Michael. - Commit messages: - Initial fix Changes: https://git.openjdk.java.net/jdk/pull/3113/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3113=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263899