Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v2]

2021-06-02 Thread Patrick Concannon
On Wed, 2 Jun 2021 09:13:44 GMT, Chris Hegarty wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8268056: Reverted changes to URLDecoder; reformatted change to FileTime > >

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v2]

2021-06-02 Thread Chris Hegarty
On Tue, 1 Jun 2021 17:20:38 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.net` >> and `java.nio` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v2]

2021-06-01 Thread Alan Bateman
On Tue, 1 Jun 2021 17:16:59 GMT, Patrick Concannon wrote: >> src/java.base/share/classes/java/nio/file/attribute/FileTime.java line 256: >> >>> 254: nanos = (int) Math.floorMod(value, >>> NANOS_PER_SECOND); >>> 255: } >>> 256: default ->

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v2]

2021-06-01 Thread Daniel Fuchs
On Tue, 1 Jun 2021 17:20:38 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.net` >> and `java.nio` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v2]

2021-06-01 Thread Patrick Concannon
On Tue, 1 Jun 2021 16:56:39 GMT, Alan Bateman wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8268056: Reverted changes to URLDecoder; reformatted change to FileTime > >

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v2]

2021-06-01 Thread Patrick Concannon
On Tue, 1 Jun 2021 16:56:36 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8268056: Reverted changes to URLDecoder; reformatted change to FileTime > >

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v2]

2021-06-01 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.net` > and `java.nio` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision: