Re: RFR[10]: JDK-8023649 - java.net.NetworkInterface.getInterfaceAddresses() call flow clean up

2017-09-13 Thread Mark Sheppard
Hi Vyom,    thanks for the feedback ...  interesting question and at a more general level is it safe to release a local reference if there is a pending exception ...looking at the logic in getByName0 function, it would appear that it is possible to release the name_utf reference before the

Re: RFR[10]: JDK-8023649 - java.net.NetworkInterface.getInterfaceAddresses() call flow clean up

2017-09-12 Thread vyom tewari
Hi Mark, Thanks for doing this, i see that "createNetworkInterface" method is getting called from multiple places in NetworkInterface.c there is pending JNI Exception at line 695 in NetworkInterface.c. I am not sure if it is safe to call "(*env)->ReleaseStringUTFChars" even if there is