Re: RFR 8114860: Behavior of java.net.URLPermission.getActions() contradicts spec

2016-06-21 Thread Pavel Rappo
Looks good to me. Thanks. > On 21 Jun 2016, at 08:10, Vyom Tewari wrote: > > Hi Pavel, > > Please find the updated > webrev(http://cr.openjdk.java.net/~vtewari/8114860/webrev0.2/index.html > ). I >

Re: RFR 8114860: Behavior of java.net.URLPermission.getActions() contradicts spec

2016-06-21 Thread Vyom Tewari
Hi Pavel, Please find the updated webrev(http://cr.openjdk.java.net/~vtewari/8114860/webrev0.2/index.html ). I reverted the commented "hashtest" test. Thanks, Vyom On Monday 20 June 2016 10:53 PM, Pavel Rappo wrote: Same

Re: RFR 8114860: Behavior of java.net.URLPermission.getActions() contradicts spec

2016-06-20 Thread Pavel Rappo
Same here. I got this only after I had a look at the history of changes. > On 20 Jun 2016, at 17:53, Vyom Tewari wrote: > > I was not expecting that hashcodetest is testing NPE by comparing the > "hardcoded" hash values.

Re: RFR 8114860: Behavior of java.net.URLPermission.getActions() contradicts spec

2016-06-20 Thread Vyom Tewari
Hi, Please find the updated webrev(http://cr.openjdk.java.net/~vtewari/8114860/webrev0.1/index.html ). I incorporated the review comments and remove the "HashCodeTest" where it compares the hashcode with hard coded hashcode.

Re: RFR 8114860: Behavior of java.net.URLPermission.getActions() contradicts spec

2016-06-20 Thread Pavel Rappo
Hi Vyom, thanks for looking into this! 0. * Copyright (c) 2013,2016 Oracle and/or its affiliates. All rights reserved. If I understand correctly, we're not required to update years in the header manually. But if you decided to do so, please follow the established pattern (in both files you've

RFR 8114860: Behavior of java.net.URLPermission.getActions() contradicts spec

2016-06-10 Thread vyom
Hi All, Please review the below fix. Bug : JDK-8114860 Behavior of java.net.URLPermission.getActions() contradicts spec Webrev : http://cr.openjdk.java.net/~vtewari/8114860/webrev0.0/index.html