Re: RFR 8151788: NullPointerException from ntlm.Client.type3

2016-07-13 Thread Wang Weijun
Change looks fine to me. Thanks Max > 在 2016年7月13日，14:52，Vyom Tewari 写道： > > Hi All, > > Please find the updated > webrev(http://cr.openjdk.java.net/%7Evtewari/8151788/webrev0.1/index.html). I > addressed the review comments. > > Thanks, > Vyom > > >> On Tuesday

Re: RFR 8151788: NullPointerException from ntlm.Client.type3

2016-07-13 Thread Vyom Tewari
Hi All, Please find the updated webrev(http://cr.openjdk.java.net/%7Evtewari/8151788/webrev0.1/index.html). I addressed the review comments. Thanks, Vyom On Tuesday 12 July 2016 08:25 PM, Weijun Wang wrote: On 7/12/2016 22:34, Pavel Rappo wrote: What's the difference between no security

Re: RFR 8151788: NullPointerException from ntlm.Client.type3

2016-07-12 Thread Weijun Wang
On 7/12/2016 22:34, Pavel Rappo wrote: What's the difference between no security buffer and an empty one (from the com.sun.security.ntlm.Client#type3's perspective)? I quickly browse through the NTLM protocol and yes they look like the same in each case. (Except for one which I am not sure,

Re: RFR 8151788: NullPointerException from ntlm.Client.type3

2016-07-12 Thread Pavel Rappo
What's the difference between no security buffer and an empty one (from the com.sun.security.ntlm.Client#type3's perspective)? > On 12 Jul 2016, at 15:25, Wang Weijun wrote: > > When there is no offset, there is no security buffer at all. When the length > is zero, the

Re: RFR 8151788: NullPointerException from ntlm.Client.type3

2016-07-12 Thread Wang Weijun
The fix looks fine to me. The readSecurityBuffer() is correct. When there is no offset, there is no security buffer at all. When the length is zero, the security buffer is an empty byte array. Here I think the customer encountered a server-side error. The fix is for interop with this

Re: RFR 8151788: NullPointerException from ntlm.Client.type3

2016-07-12 Thread Vyom Tewari
gentile reminder. Vyom On Thursday 30 June 2016 02:16 PM, Vyom Tewari wrote: Hi All, Please review the below simple fix. Bug: JDK-8151788 NullPointerException from ntlm.Client.type3 Webrev : http://cr.openjdk.java.net/~vtewari/8151788/webrev0.0/index.html

RFR 8151788: NullPointerException from ntlm.Client.type3

2016-06-30 Thread Vyom Tewari
Hi All, Please review the below simple fix. Bug: JDK-8151788 NullPointerException from ntlm.Client.type3 Webrev : http://cr.openjdk.java.net/~vtewari/8151788/webrev0.0/index.html Thanks, Vyom