On Sat, 1 Oct 2022 00:48:03 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this test-only change which proposes to
>> improve the test run duration of `java/net/vthread/HttpALot.java` test, on
>> Linux? This relates to https://bugs.openjdk.org/browse/JDK-8294610
>>
>> Experiments ha
On Fri, 30 Sep 2022 13:32:13 GMT, Daniel Fuchs wrote:
>> I think adding the original 8284161 is sufficient, but remove 8294610 as the
>> convention has been not to include a test fix bugid in the @bug statement
>> ... this is a correction I've had to apply in the past
>
> I agree with Mark. The
> Can I please get a review for this test-only change which proposes to improve
> the test run duration of `java/net/vthread/HttpALot.java` test, on Linux?
> This relates to https://bugs.openjdk.org/browse/JDK-8294610
>
> Experiments have shown that on Linux, due to delayed TCP ACKs from the cli
On Fri, 30 Sep 2022 10:39:37 GMT, Claes Redestad wrote:
> Move a simple utility method from `URL` to the shared `sun.net.util.URLUtil`
> class, rename it for clarity and enhance it so that it returns the string
> literal if the protocol matches one of the tested variants. This helps reduce
> d
On Fri, 30 Sep 2022 09:11:30 GMT, KIRIYAMA Takuya wrote:
>> I fixed sun.net.www.ParseUtil.decode().
>>
>> ParseUtil.decode() always tries to decode after parsing '%', so if '%' is
>> located at the end of the String, IndexOutOfBoundsException is thrown. Also,
>> if '%' is shown after decodable
On Fri, 30 Sep 2022 12:18:51 GMT, Mark Sheppard wrote:
>> Hello Mark, it hasn't always been clear to me when to update the `@bug`. The
>> contribution guide isn't completely clear either. So I usually update the
>> bug id if the test change is substantial (in the way it affects the test).
>> I
On Fri, 30 Sep 2022 12:38:26 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes sure KeepAliveCache does not block all
>> threads while closing sockets.
>>
>> Changes:
>> - get operation no longer closes sockets; if there's no socket that is
>> recent enough, get returns null a
On Fri, 30 Sep 2022 12:36:10 GMT, Сергей Цыпанов wrote:
>> Claes Redestad has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Cleanups
>> - Revert accidental import mangling
>
> src/java.base/share/classes/java/net/URL.java line 1388:
>
> Please review this patch that makes sure KeepAliveCache does not block all
> threads while closing sockets.
>
> Changes:
> - get operation no longer closes sockets; if there's no socket that is recent
> enough, get returns null and lets the cleaner thread close the sockets
> - put operation cl
On Fri, 30 Sep 2022 11:46:39 GMT, Claes Redestad wrote:
>> Move a simple utility method from `URL` to the shared `sun.net.util.URLUtil`
>> class, rename it for clarity and enhance it so that it returns the string
>> literal if the protocol matches one of the tested variants. This helps
>> redu
On Fri, 30 Sep 2022 11:51:34 GMT, Jaikiran Pai wrote:
>> Good point. The JBS issue should be marked with `noreg-self` too.
>
> Hello Mark, it hasn't always been clear to me when to update the `@bug`. The
> contribution guide isn't completely clear either. So I usually update the bug
> id if the
On Fri, 30 Sep 2022 11:06:40 GMT, Claes Redestad wrote:
> `URLUtil` already exists, is used during bootstrap from non-java.net packages
> and would profit from reusing this lower case method. Making the method in
> `URL` public is a non-starter. I'd love having module-scoped visibility
> modif
On Fri, 30 Sep 2022 11:46:39 GMT, Claes Redestad wrote:
>> Move a simple utility method from `URL` to the shared `sun.net.util.URLUtil`
>> class, rename it for clarity and enhance it so that it returns the string
>> literal if the protocol matches one of the tested variants. This helps
>> redu
On Fri, 30 Sep 2022 10:59:39 GMT, Daniel Fuchs wrote:
>> JEP 425 added a lot of new tests but missed in `@bug` tag in many cases. It
>> should be `@bug 8284161` (not 8294610). We can add 8294610 to the list,
>> which I think is what you are saying.
>
> Good point. The JBS issue should be marked
> Can I please get a review for this test-only change which proposes to improve
> the test run duration of `java/net/vthread/HttpALot.java` test, on Linux?
> This relates to https://bugs.openjdk.org/browse/JDK-8294610
>
> Experiments have shown that on Linux, due to delayed TCP ACKs from the cli
On Fri, 30 Sep 2022 11:36:01 GMT, Claes Redestad wrote:
>> Move a simple utility method from `URL` to the shared `sun.net.util.URLUtil`
>> class, rename it for clarity and enhance it so that it returns the string
>> literal if the protocol matches one of the tested variants. This helps
>> redu
> Move a simple utility method from `URL` to the shared `sun.net.util.URLUtil`
> class, rename it for clarity and enhance it so that it returns the string
> literal if the protocol matches one of the tested variants. This helps reduce
> dependencies from bootstrap code on `Locale` while improvin
On Fri, 30 Sep 2022 11:43:15 GMT, Claes Redestad wrote:
>> Move a simple utility method from `URL` to the shared `sun.net.util.URLUtil`
>> class, rename it for clarity and enhance it so that it returns the string
>> literal if the protocol matches one of the tested variants. This helps
>> redu
On Fri, 30 Sep 2022 11:31:00 GMT, Daniel Fuchs wrote:
>> Claes Redestad has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Cleanups
>> - Revert accidental import mangling
>
> src/java.base/share/classes/java/net/URL.java line 35:
>
>> 3
> Move a simple utility method from `URL` to the shared `sun.net.util.URLUtil`
> class, rename it for clarity and enhance it so that it returns the string
> literal if the protocol matches one of the tested variants. This helps reduce
> dependencies from bootstrap code on `Locale` while improvin
On Fri, 30 Sep 2022 10:40:28 GMT, Michael McMahon wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Describe oldClient
>
> src/java.base/share/classes/sun/net/www/http/KeepAliveCache.java line 330:
>
>> 328:
On Fri, 30 Sep 2022 10:39:37 GMT, Claes Redestad wrote:
> Move a simple utility method from `URL` to the shared `sun.net.util.URLUtil`
> class, rename it for clarity and enhance it so that it returns the string
> literal if the protocol matches one of the tested variants. This helps reduce
> d
On Fri, 30 Sep 2022 10:39:37 GMT, Claes Redestad wrote:
> Move a simple utility method from `URL` to the shared `sun.net.util.URLUtil`
> class, rename it for clarity and enhance it so that it returns the string
> literal if the protocol matches one of the tested variants. This helps reduce
> d
On Fri, 30 Sep 2022 10:59:09 GMT, Alan Bateman wrote:
>> test/jdk/java/net/vthread/HttpALot.java line 26:
>>
>>> 24: /**
>>> 25: * @test
>>> 26: * @bug 8294610
>>
>> is this tag valid for a test fix -- afaik it is for a "product code fix"
>> i.e. the test is for a fix in the product code ide
On Fri, 30 Sep 2022 10:53:10 GMT, Mark Sheppard wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> test comment review
>
> test/jdk/java/net/vthread/HttpALot.java line 26:
>
>> 24: /**
>> 25: * @test
>> 26: * @bug
Move a simple utility method from `URL` to the shared `sun.net.util.URLUtil`
class, rename it for clarity and enhance it so that it returns a string
literal. This helps reduce dependencies from bootstrap code on `Locale` while
improving the performance and allocation pressure in certain applicat
On Fri, 30 Sep 2022 10:39:37 GMT, Claes Redestad wrote:
> Move a simple utility method from `URL` to the shared `sun.net.util.URLUtil`
> class, rename it for clarity and enhance it so that it returns the string
> literal if the protocol matches one of the tested variants. This helps reduce
> d
On Fri, 30 Sep 2022 10:20:50 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this test-only change which proposes to
>> improve the test run duration of `java/net/vthread/HttpALot.java` test, on
>> Linux? This relates to https://bugs.openjdk.org/browse/JDK-8294610
>>
>> Experiments h
On Wed, 28 Sep 2022 17:31:46 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes sure KeepAliveCache does not block all
>> threads while closing sockets.
>>
>> Changes:
>> - get operation no longer closes sockets; if there's no socket that is
>> recent enough, get returns null a
On Fri, 30 Sep 2022 09:11:30 GMT, KIRIYAMA Takuya wrote:
>> I fixed sun.net.www.ParseUtil.decode().
>>
>> ParseUtil.decode() always tries to decode after parsing '%', so if '%' is
>> located at the end of the String, IndexOutOfBoundsException is thrown. Also,
>> if '%' is shown after decodable
On Fri, 30 Sep 2022 10:20:50 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this test-only change which proposes to
>> improve the test run duration of `java/net/vthread/HttpALot.java` test, on
>> Linux? This relates to https://bugs.openjdk.org/browse/JDK-8294610
>>
>> Experiments h
On Fri, 30 Sep 2022 10:09:14 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update test comment to address review comments
>
> test/jdk/java/net/vthread/HttpALot.java line 34:
>
>> 32: * @comme
> Can I please get a review for this test-only change which proposes to improve
> the test run duration of `java/net/vthread/HttpALot.java` test, on Linux?
> This relates to https://bugs.openjdk.org/browse/JDK-8294610
>
> Experiments have shown that on Linux, due to delayed TCP ACKs from the cli
On Fri, 30 Sep 2022 09:57:32 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this test-only change which proposes to
>> improve the test run duration of `java/net/vthread/HttpALot.java` test, on
>> Linux? This relates to https://bugs.openjdk.org/browse/JDK-8294610
>>
>> Experiments h
> Can I please get a review for this test-only change which proposes to improve
> the test run duration of `java/net/vthread/HttpALot.java` test, on Linux?
> This relates to https://bugs.openjdk.org/browse/JDK-8294610
>
> Experiments have shown that on Linux, due to delayed TCP ACKs from the cli
On Fri, 30 Sep 2022 09:38:37 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update test comment to address review comments
>
> test/jdk/java/net/vthread/HttpALot.java line 32:
>
>> 30: * @libra
On Fri, 30 Sep 2022 09:10:05 GMT, Jaikiran Pai wrote:
> Can I please get a review for this test-only change which proposes to improve
> the test run duration of `java/net/vthread/HttpALot.java` test, on Linux?
> This relates to https://bugs.openjdk.org/browse/JDK-8294610
>
> Experiments have s
On Fri, 30 Sep 2022 09:10:05 GMT, Jaikiran Pai wrote:
> Can I please get a review for this test-only change which proposes to improve
> the test run duration of `java/net/vthread/HttpALot.java` test, on Linux?
> This relates to https://bugs.openjdk.org/browse/JDK-8294610
>
> Experiments have s
Can I please get a review for this test-only change which proposes to improve
the test run duration of `java/net/vthread/HttpALot.java` test, on Linux? This
relates to https://bugs.openjdk.org/browse/JDK-8294610
Experiments have shown that on Linux, due to delayed TCP ACKs from the client
(for
> I fixed sun.net.www.ParseUtil.decode().
>
> ParseUtil.decode() always tries to decode after parsing '%', so if '%' is
> located at the end of the String, IndexOutOfBoundsException is thrown. Also,
> if '%' is shown after decodable string and following string is not decodable
> (e.g: "%25%s%G1
On Thu, 29 Sep 2022 10:26:14 GMT, Daniel Fuchs wrote:
>> You can use `Throwable::initCause`
>
> var mfue = new MalformedURLException(e.getMessage());
> mfue.initCause(e);
> throw mfue;
Thank you for your advice, I could fix it.
-
PR: https://git.openjdk.org/jdk/pull/8155
41 matches
Mail list logo
