On Sat, 5 Nov 2022 00:01:15 GMT, Johnny Lim wrote:
> This PR removes a duplicate space in `ProtocolException` message.
This pull request has now been integrated.
Changeset: 5dcaf6cc
Author:Johnny Lim
Committer: Jaikiran Pai
URL:
On Mon, 28 Nov 2022 14:21:01 GMT, Darragh Clarke wrote:
>> Currently if a `HttpResonseInputStream` gets interrupted while reading it
>> will just swallow the exception and continue,
>>
>> This PR changes it to close the stream and throw an IOException, I added a
>> test to cover this which
On Tue, 29 Nov 2022 16:46:43 GMT, Per Minborg wrote:
> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>
> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
> improvement areas were identified including:
>
> * Replacing duplicate code segments
> *
On Tue, 29 Nov 2022 05:48:26 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to enhance an
> exception message in `java.net.HostPortrange::toLowerCase`, as requested in
> https://bugs.openjdk.org/browse/JDK-8297311?
>
> The commit here includes (only) the
On Tue, 29 Nov 2022 12:56:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to enhance an
>> exception message in `java.net.HostPortrange::toLowerCase`, as requested in
>> https://bugs.openjdk.org/browse/JDK-8297311?
>>
>> The commit here includes (only)
On Tue, 29 Nov 2022 19:23:21 GMT, Michal Karm Babacek wrote:
>> This PR adds a missing MIME: application/wasm and unifies the file format on
>> tabs, as that seemed to be the winning side of the tabs/spaces war in this
>> file.
>>
>> # How to reproduce
>>
>> You will need to compile a `.c`
On Tue, 29 Nov 2022 21:06:52 GMT, Michal Karm Babacek wrote:
> ```
> I: Configuring ca-certificates...
> W: Failure while configuring base packages. This will be re-attempted up to
> five times.
> W: See /home/runner/work/jdk/jdk/sysroot/debootstrap/debootstrap.log for
> details (possibly the
On Tue, 29 Nov 2022 11:44:25 GMT, Johnny Lim wrote:
>> Hello @izeye, for this pull request to be officially reviewed, the process
>> requires a JBS issue to be filed and linked against this PR. I have created
>> https://bugs.openjdk.org/browse/JDK-8297749 to track this change.
>>
>> Please
On Tue, 29 Nov 2022 13:21:19 GMT, Johnny Lim wrote:
>> This PR removes a duplicate space in `ProtocolException` message.
>
> Johnny Lim has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the
On Mon, 28 Nov 2022 08:58:29 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes the typos in the test
> packages? @mernst submitted this as a separate PR
> https://github.com/openjdk/jdk/pull/10029 but given the number of areas and
> files that other PR touches,
On Mon, 28 Nov 2022 10:02:47 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes the typos in the test
>> packages? @mernst submitted this as a separate PR
>> https://github.com/openjdk/jdk/pull/10029 but given the number of areas and
>> files that other PR
On Tue, 29 Nov 2022 17:50:07 GMT, Daniel Fuchs wrote:
> Please find here a fix that drops the HttpClient TckDiriver test. This test
> has been useful when developing the HTTP client APIs. However, it has become
> a burden to run this test, which is now the longest running HttpClient test.
>
On Tue, 29 Nov 2022 19:23:21 GMT, Michal Karm Babacek wrote:
>> This PR adds a missing MIME: application/wasm and unifies the file format on
>> tabs, as that seemed to be the winning side of the tabs/spaces war in this
>> file.
>>
>> # How to reproduce
>>
>> You will need to compile a `.c`
On Tue, 29 Nov 2022 19:24:14 GMT, Roger Riggs wrote:
> There could be more sharing of the unsupported implementation if SctpChannel
> was not abstract and its method bodies threw the exception. There would less
> duplication for unsupported platforms.
I think this is accident of history. As I
On Tue, 29 Nov 2022 19:52:16 GMT, Daniel Fuchs wrote:
> Commits will be automatically squashed by the bot when you /integrate - so
> there's no need to force-push.
Ack. Thanks :)
-
PR: https://git.openjdk.org/jdk/pull/11284
On Tue, 29 Nov 2022 13:06:37 GMT, Jaikiran Pai wrote:
>> @jaikiran Thanks.
>
> Hello @Karm, we have an existing test in the JDK which verifies the expected
> mime types for some well known extensions. It resides at
> `test/jdk/java/nio/file/Files/probeContentType/Basic.java`. Could you update
On Tue, 29 Nov 2022 16:46:43 GMT, Per Minborg wrote:
> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>
> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
> improvement areas were identified including:
>
> * Replacing duplicate code segments
> *
On Tue, 29 Nov 2022 13:06:37 GMT, Jaikiran Pai wrote:
> Could you update that test's main method to include a test for this new mime
> type that this PR adds?
Ack.
The test fails when I put something random in there and it passes with wasm now:
$ make run-test
> This PR adds a missing MIME: application/wasm and unifies the file format on
> tabs, as that seemed to be the winning side of the tabs/spaces war in this
> file.
>
> # How to reproduce
>
> You will need to compile a `.c` file to a `.wasm` binary. Use [Emscripten
>
On Tue, 29 Nov 2022 16:46:43 GMT, Per Minborg wrote:
> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>
> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
> improvement areas were identified including:
>
> * Replacing duplicate code segments
> *
On Tue, 29 Nov 2022 09:40:58 GMT, Per Minborg wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed
On Tue, 29 Nov 2022 17:50:07 GMT, Daniel Fuchs wrote:
> Please find here a fix that drops the HttpClient TckDiriver test. This test
> has been useful when developing the HTTP client APIs. However, it has become
> a burden to run this test, which is now the longest running HttpClient test.
>
Please find here a fix that drops the HttpClient TckDiriver test. This test has
been useful when developing the HTTP client APIs. However, it has become a
burden to run this test, which is now the longest running HttpClient test. This
change proposes to drop the test from the non regression
On Tue, 29 Nov 2022 16:46:43 GMT, Per Minborg wrote:
> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>
> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
> improvement areas were identified including:
>
> * Replacing duplicate code segments
> *
On Mon, 28 Nov 2022 14:21:01 GMT, Darragh Clarke wrote:
>> Currently if a `HttpResonseInputStream` gets interrupted while reading it
>> will just swallow the exception and continue,
>>
>> This PR changes it to close the stream and throw an IOException, I added a
>> test to cover this which
This PR proposes a variety of modernisations to the `jdk.sctp` module.
During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
improvement areas were identified including:
* Replacing duplicate code segments
* Making certain fields final
* Using enhanced switch
* Using
On Tue, 29 Nov 2022 09:40:58 GMT, Per Minborg wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed
On Tue, 29 Nov 2022 12:56:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to enhance an
>> exception message in `java.net.HostPortrange::toLowerCase`, as requested in
>> https://bugs.openjdk.org/browse/JDK-8297311?
>>
>> The commit here includes (only)
On Tue, 29 Nov 2022 12:56:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to enhance an
>> exception message in `java.net.HostPortrange::toLowerCase`, as requested in
>> https://bugs.openjdk.org/browse/JDK-8297311?
>>
>> The commit here includes (only)
On Tue, 29 Nov 2022 09:40:58 GMT, Per Minborg wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed
On Tue, 29 Nov 2022 13:21:19 GMT, Johnny Lim wrote:
>> This PR removes a duplicate space in `ProtocolException` message.
>
> Johnny Lim has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the
On Tue, 29 Nov 2022 12:44:12 GMT, Daniel Fuchs wrote:
>> Johnny Lim has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new
> This PR removes a duplicate space in `ProtocolException` message.
Johnny Lim has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains one new
On Tue, 22 Nov 2022 10:43:42 GMT, Michal Karm Babacek wrote:
> This PR adds a missing MIME: application/wasm and unifies the file format on
> tabs, as that seemed to be the winning side of the tabs/spaces war in this
> file.
>
> # How to reproduce
>
> You will need to compile a `.c` file to
On Fri, 25 Nov 2022 13:23:30 GMT, Michal Karm Babacek wrote:
>> Hello @Karm, to officially initiate a review of this change, the review
>> process (backed by bots) requires a JBS issue to be created and linked
>> against this PR. I have created https://bugs.openjdk.org/browse/JDK-8297609
>>
On Tue, 29 Nov 2022 12:35:36 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review comment
>
> src/java.base/share/classes/java/net/HostPortrange.java line 189:
>
>> 187:
On Tue, 29 Nov 2022 12:52:35 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to enhance an
>> exception message in `java.net.HostPortrange::toLowerCase`, as requested in
>> https://bugs.openjdk.org/browse/JDK-8297311?
>>
>> The commit here includes (only)
> Can I please get a review of this change which proposes to enhance an
> exception message in `java.net.HostPortrange::toLowerCase`, as requested in
> https://bugs.openjdk.org/browse/JDK-8297311?
>
> The commit here includes (only) the character, which was found to be invalid,
> in the
On Sat, 5 Nov 2022 00:01:15 GMT, Johnny Lim wrote:
> This PR removes a duplicate space in `ProtocolException` message.
src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java
line 1999:
> 1997: } while (redirects < maxRedirects);
> 1998:
> 1999:
On Tue, 22 Nov 2022 17:24:40 GMT, Daniel Fuchs wrote:
> The java/net/httpclient/SpecialHeadersTest.java test has been observed
> failing once, due to a selector thread still running after all operations had
> terminated. This change slightly alter the test logic to check the shared
> client
On Wed, 23 Nov 2022 19:38:50 GMT, Daniel Fuchs wrote:
> The `ResponseSubscribers.HttpResponseInputStream` class has an assert that
> has been observed firing (rarely) when running the
> `java/net/httpclient/AsyncExecutorShutdown.java` test.
>
> After a thorough analysis of the code and the
On Tue, 29 Nov 2022 05:48:26 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to enhance an
> exception message in `java.net.HostPortrange::toLowerCase`, as requested in
> https://bugs.openjdk.org/browse/JDK-8297311?
>
> The commit here includes (only) the
On Tue, 29 Nov 2022 07:21:45 GMT, Jaikiran Pai wrote:
>> This PR removes a duplicate space in `ProtocolException` message.
>
> Hello @izeye, for this pull request to be officially reviewed, the process
> requires a JBS issue to be filed and linked against this PR. I have created
>
On Sat, 5 Nov 2022 00:01:15 GMT, Johnny Lim wrote:
> This PR removes a duplicate space in `ProtocolException` message.
Hello @izeye, for this pull request to be officially reviewed, the process
requires a JBS issue to be filed and linked against this PR. I have created
This PR removes a duplicate space in `ProtocolException` message.
-
Commit messages:
- Remove duplicate space in ProtocolException message
Changes: https://git.openjdk.org/jdk/pull/11002/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=11002=00
Issue:
On Tue, 22 Nov 2022 11:10:14 GMT, Conor Cleary wrote:
> Proposed changes to reduce the default Keep Alive Timeout value in
> `jdk/internal/net/http/HttpClientImpl.java` from 1200 seconds to 30 seconds.
> The current default value of 1200s is needlessly high and in remote
> connections that
On Mon, 28 Nov 2022 17:57:52 GMT, Daniel Fuchs wrote:
>> The java/net/httpclient/SpecialHeadersTest.java test has been observed
>> failing once, due to a selector thread still running after all operations
>> had terminated. This change slightly alter the test logic to check the
>> shared
On Fri, 18 Nov 2022 13:50:51 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following doc change reviewed please? It documents the
> system/networking properties used by the java.net.http HTTP client in its
> module-info. (CSR to follow)
>
> Thanks,
> Michael
This pull request has
We hear you Mike :-)
I have logged https://bugs.openjdk.org/browse/JDK-8297755 to update the
links in java.net / java.net.http API documentation.
best regards,
-- daniel
On 29/11/2022 03:14, Michael StJohns wrote:
Hi -
I need to repeat again. Please avoid using www.ietf.org as the URL base
Hi -
I need to repeat again. Please avoid using www.ietf.org as the URL base
for referencing RFCs. The appropriate location is www.rfc-editor.org
and is going to be more stable in the long run than any reference to an
RFC that runs through the IETF's website. These two websites have
On Tue, 29 Nov 2022 09:40:58 GMT, Per Minborg wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed
> This PR proposes the introduction of **guarding** of the use of
> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
> Function and Memory access, it is possible to derive Buffer instances that
> are backed by native memory that, in turn, can be closed asynchronously
52 matches
Mail list logo
