Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-17 Thread snake66
On Mon, 17 Mar 2025 06:41:31 GMT, David Holmes wrote: >> @magicus why can't we just use `-pthread` everywhere? My recollection is >> that `-pthread` both sets compiler directives needed for pthread programming >> and links to libpthread, so it seems to be what we should be using. ?? > >> Anothe

Re: RFR: 8351339: WebSocket::sendBinary assume that user supplied buffers are BIG_ENDIAN [v3]

2025-03-17 Thread Volkan Yazici
On Fri, 14 Mar 2025 15:13:52 GMT, Mark Sheppard wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Make method name changes backport-friendly > > persisting with method nomenclature (or painting the bikeshed again).

Re: RFR: 8351339: WebSocket::sendBinary assume that user supplied buffers are BIG_ENDIAN [v4]

2025-03-17 Thread Volkan Yazici
> Fixes endian handling `jdk.internal.net.http.websocket.Frame.Masker`. > > ### Implementation notes > > I deleted the `Frame` clone in tests, and rewired the test code depending on > it to the actual `Frame`. To enable this, I relaxed the visibility of the > actual `Frame`. I guess the `Frame`