RFR: 8357013: Optimize response code parsing in HttpURLConnection

Avoid allocating a substring to parse the response code in HttpURLConnection#getResponseCode, but instead use the Integer.parseInt overload that accepts String indices. - Commit messages: - Optimize response code parsing in HttpURLConnection Changes: https://git.openjdk.org/jdk/pu

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v12]

On Tue, 13 May 2025 13:37:18 GMT, Weijun Wang wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Missed one review comment > > src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1682: > >> 1680

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v12]

On Tue, 13 May 2025 13:25:21 GMT, Weijun Wang wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Missed one review comment > > src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1650: > >> 1648

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v12]

On Tue, 13 May 2025 17:13:03 GMT, Artur Barashev wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Missed one review comment > > test/jdk/javax/net/ssl/ExtendedSSLSession/ExportKeyingMaterialTests.java line > 62

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v13]

On Thu, 15 May 2025 00:23:56 GMT, Bradford Wetmore wrote: >> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1583: >> >>> 1581: // Calculations are primarily based on protocol version. >>> 1582: switch (protocolVersion) { >>> 1583: case TLS13: // HK

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v15]

On Wed, 14 May 2025 20:13:36 GMT, Artur Barashev wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Merged with changes for JDK-8353578 > > src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 172

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v12]

On Tue, 13 May 2025 13:23:16 GMT, Weijun Wang wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Missed one review comment > > src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1598: > >> 1596

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v13]

On Tue, 13 May 2025 21:44:21 GMT, Artur Barashev wrote: >> Bradford Wetmore has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into JDK-8341346 >> - Missed one review comment >> - More cod

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v15]

On Wed, 14 May 2025 21:42:06 GMT, Bradford Wetmore wrote: >> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 329: >> >>> 327: */ >>> 328: >>> 329: SSLSessionImpl(HandshakeContext hc, ByteBuffer buf) throws >>> IOException { >> >> this constructor is used for ses

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v12]

On Tue, 13 May 2025 12:16:37 GMT, Sean Mullan wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Missed one review comment > > src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java line 189: > >> 187:

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v15]

On Wed, 14 May 2025 19:17:15 GMT, Daniel Jeliński wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Merged with changes for JDK-8353578 > > src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 32

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v15]

On Wed, 14 May 2025 04:03:44 GMT, Bradford Wetmore wrote: >> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE >> respectively. >> >> CSR is underway. >> >> Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK >> API (jck:api/java_security jck:

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v15]

On Wed, 14 May 2025 04:03:44 GMT, Bradford Wetmore wrote: >> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE >> respectively. >> >> CSR is underway. >> >> Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK >> API (jck:api/java_security jck:

Re: RFR: 8353113: Peer supported certificate signature algorithms are not being checked with default SunX509 key manager [v4]

> When the deafult SunX509KeyManagerImpl is being used we are in violation of > TLSv1.3 RFC spec because we ignore peer supported certificate signatures sent > to us in "signature_algorithms"/"signature_algorithms_cert" extensions: > https://datatracker.ietf.org/doc/html/rfc8446#section-4.4.2.2 >

Re: [External] : Re: The default HttpServer Executor

> > Yes. An application (handler's implementations) may depend on that. Aside from that filter bug Ethan mentioned, have you seen such cases? I usually see people take it as a given that the default impl can serve multiple requests and have to tell them to use an executor. If we decide against c

Re: [External] : Re: The default HttpServer Executor

Hi Josiah, On 13/05/2025 20:24, Josiah Noel wrote: The HttpServer doesn't use any default executor I know what you mean by this, but I have to point out that the class used is quite literally called DefaultExecutor

Re: RFR: 8351347: HttpClient Improve logging of response headers [v2]

On Wed, 14 May 2025 09:31:07 GMT, Volkan Yazici wrote: >> Includes request method, request URI, response status code, and HTTP/2 >> stream ID while logging response headers in the HTTP Client. >> >> ### Demonstration >> >> Snippets from running JTreg against >> `test/jdk/java/net/httpclient/H

Re: RFR: 8351347: HttpClient Improve logging of response headers

On Tue, 13 May 2025 13:53:05 GMT, Daniel Fuchs wrote: >> Includes request method, request URI, response status code, and HTTP/2 >> stream ID while logging response headers in the HTTP Client. >> >> ### Demonstration >> >> Snippets from running JTreg against >> `test/jdk/java/net/httpclient/He

Re: RFR: 8351347: HttpClient Improve logging of response headers [v2]

> Includes request method, request URI, response status code, and HTTP/2 stream > ID while logging response headers in the HTTP Client. > > ### Demonstration > > Snippets from running JTreg against > `test/jdk/java/net/httpclient/HeadTest.java`: > > **Before:** > > INFO: HEADERS: RESPONSE HEA