Re: RFR: 8294626: Improve URL protocol lower casing [v3]

2022-09-30 Thread Claes Redestad
On Fri, 30 Sep 2022 12:36:10 GMT, Сергей Цыпанов wrote: >> Claes Redestad has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Cleanups >> - Revert accidental import mangling > > src/java.base/share/classes/java/net/URL.java line 1388: >

Re: RFR: 8294626: Improve URL protocol lower casing [v3]

2022-09-30 Thread Сергей Цыпанов
On Fri, 30 Sep 2022 11:46:39 GMT, Claes Redestad wrote: >> Move a simple utility method from `URL` to the shared `sun.net.util.URLUtil` >> class, rename it for clarity and enhance it so that it returns the string >> literal if the protocol matches one of the tested variants. This helps >> redu

Re: RFR: 8294626: Improve URL protocol lower casing [v3]

2022-09-30 Thread Daniel Fuchs
On Fri, 30 Sep 2022 11:46:39 GMT, Claes Redestad wrote: >> Move a simple utility method from `URL` to the shared `sun.net.util.URLUtil` >> class, rename it for clarity and enhance it so that it returns the string >> literal if the protocol matches one of the tested variants. This helps >> redu

Re: RFR: 8294626: Improve URL protocol lower casing [v3]

2022-09-30 Thread Claes Redestad
> Move a simple utility method from `URL` to the shared `sun.net.util.URLUtil` > class, rename it for clarity and enhance it so that it returns the string > literal if the protocol matches one of the tested variants. This helps reduce > dependencies from bootstrap code on `Locale` while improvin

Re: RFR: 8294626: Improve URL protocol lower casing [v3]

2022-09-30 Thread Daniel Fuchs
On Fri, 30 Sep 2022 11:43:15 GMT, Claes Redestad wrote: >> Move a simple utility method from `URL` to the shared `sun.net.util.URLUtil` >> class, rename it for clarity and enhance it so that it returns the string >> literal if the protocol matches one of the tested variants. This helps >> redu

Re: RFR: 8294626: Improve URL protocol lower casing [v3]

2022-09-30 Thread Claes Redestad
On Fri, 30 Sep 2022 11:31:00 GMT, Daniel Fuchs wrote: >> Claes Redestad has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Cleanups >> - Revert accidental import mangling > > src/java.base/share/classes/java/net/URL.java line 35: > >> 3