On Sun, 1 Dec 2024 05:50:47 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests to make the constructor of
>> `java.net.InterfaceAddress` private.
>>
>> This constructor is only accessed by native code via the `NetworkInterface`
>> class. Making it private would express the inte
On Sun, 1 Dec 2024 05:50:47 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests to make the constructor of
>> `java.net.InterfaceAddress` private.
>>
>> This constructor is only accessed by native code via the `NetworkInterface`
>> class. Making it private would express the inte
On Sun, 1 Dec 2024 05:50:47 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests to make the constructor of
>> `java.net.InterfaceAddress` private.
>>
>> This constructor is only accessed by native code via the `NetworkInterface`
>> class. Making it private would express the inte
> Please review this PR which suggests to make the constructor of
> `java.net.InterfaceAddress` private.
>
> This constructor is only accessed by native code via the `NetworkInterface`
> class. Making it private would express the intent of this class as being
> non-subclassable.
>
> The commen
On Sun, 1 Dec 2024 01:32:31 GMT, Chen Liang wrote:
> We should word like "this constructor is called via JNI in
> NetworkInterface.c" so we know what care we need to take when we update this
> constructor.
Thanks! Yes, simpler to just say where the constructor is called from. It
folllows from
On Sat, 30 Nov 2024 18:18:29 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which suggests to make the constructor of
> `java.net.InterfaceAddress` private.
>
> This constructor is only accessed by native code via the `NetworkInterface`
> class. Making it private would express the intent o
On Sat, 30 Nov 2024 18:18:29 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which suggests to make the constructor of
> `java.net.InterfaceAddress` private.
>
> This constructor is only accessed by native code via the `NetworkInterface`
> class. Making it private would express the intent o
Please review this PR which suggests to make the constructor of
`java.net.InterfaceAddress` private.
This constructor is only accessed by native code via the `NetworkInterface`
class. Making it private would express the intent of this class as being
non-subclassable.
The comment of the constru
