Re: jdk.httpserver 101 status code closing connection

2025-09-04 Thread Josiah Noel
I've been playing around with it, and it looks like the interim problem of 1xx requests can be resolved if sendResponseHeaders is modified so that the sentHeaders is not set to true for 1xx status codes. The fix would be: - Check for 1xx status code - If so, do not close the streams - fl

Re: jdk.httpserver 101 status code closing connection

2025-09-03 Thread Josiah Noel
> > Unfortunately I can't look at that PR until the OCA > has been signed and processed. Yeah, I put it in draft for now until that goes through. I had signed for helidon and not OpenJDK I guess - if HttpServer::stop is called before the connection is >closed, what happens? Testing locally

Re: jdk.httpserver 101 status code closing connection

2025-09-03 Thread Daniel Fuchs
Hi Josia, Unfortunately I can't look at that PR until the OCA has been signed and processed. That said I'd be worried about several potential issues: - will the server keep a reference to the connection/socket so that it can be closed if HttpServer::close is called? - how will the server know

Re: jdk.httpserver 101 status code closing connection

2025-09-03 Thread Josiah Noel
> The current code has some provision for some one hundred > codes but sendResponseHeaders appears not to have been > designed to send interim responses A new method to send interim response codes might be better than trying to shoehorn sending one hundreds with the current API, but we haven't

Re: jdk.httpserver 101 status code closing connection

2025-09-03 Thread Daniel Fuchs
Hi Josiah, This is a feature that is currently not supported by the jdk.httpserver. Part of a larger problem that support for sending interim responses (1xx) is currently missing. The current code has some provision for some one hundred codes but sendResponseHeaders appears not to have been desi