Re: RFR 8162521, java/net/Authenticator/B4933582.sh fails intermittently with BindException

2016-12-01 Thread Felix Yang
Hi Daniel, please review the new webrev: http://cr.openjdk.java.net/~xiaofeya/8162521/webrev.01/ Thanks, Felix On 2016/12/1 18:58, Daniel Fuchs wrote: Hi Felix, Good to see one more script converted to java. I wonder if the fact that the test use to run two separate JVMs was significant.

Re: RFR 8162521, java/net/Authenticator/B4933582.sh fails intermittently with BindException

2016-12-01 Thread Daniel Fuchs
On 01/12/16 14:40, Felix Yang wrote: Hi Daniel, please review the new webrev: http://cr.openjdk.java.net/~xiaofeya/8162521/webrev.01/ Looks good Felix! -- daniel Thanks, Felix On 2016/12/1 18:58, Daniel Fuchs wrote: Hi Felix, Good to see one more script converted to java. I wonder

Re: RFR: 8170544: Fix code scan findings in libnet

2016-12-01 Thread Michael McMahon
Okay. I'll run the three patches through jprt again Michael On 01/12/2016, 11:53, Langer, Christoph wrote: Hi Michael, I have just updated http://cr.openjdk.java.net/~clanger/webrevs/8170544.0/ in place. The old version caused a

RE: RFR: 8170544: Fix code scan findings in libnet

2016-12-01 Thread Langer, Christoph
Hi Michael, I have just updated http://cr.openjdk.java.net/~clanger/webrevs/8170544.0/ in place. The old version caused a compile warning on Linux. Best regards Christoph From: Langer, Christoph Sent: Mittwoch, 30. November 2016 19:01 To: 'Michael McMahon' Cc:

RFR 8162521, java/net/Authenticator/B4933582.sh fails intermittently with BindException

2016-12-01 Thread Felix Yang
Hi, please review the following patch. The code was converted from shell script to plain Java. Since it is by-design to bind on a prior-used port, add a few of re-tries for possible BindException. Bug: https://bugs.openjdk.java.net/browse/JDK-8162521 Webrev:

Re: RFR 8162521, java/net/Authenticator/B4933582.sh fails intermittently with BindException

2016-12-01 Thread Daniel Fuchs
Hi Felix, Good to see one more script converted to java. I wonder if the fact that the test use to run two separate JVMs was significant. Hopefully it's not. The changes in TestHttpServer seem OK - this class is shared by many other tests - so any modifications here is to be taken with care. I