Hi Gary,
> Here's a revised webrev
>
>http://cr.openjdk.java.net/~gadams/8080990/webrev.01/index.html
>
> Still testing ...
>
> Using shutdown() fixed problems reported by the
> java/nio/channelSocketChannel tests.
The fix looks good. I would think we should rename dbgsysInetAddr to dbgsysP
Roger,
On 01/02/18 21:29, Roger Riggs wrote:
Hi Chris,
Thanks for the review and suggestion.
Webrev updated:
http://cr.openjdk.java.net/~rriggs/webrev-net-cleanup-8195059/
This looks good to me, just a few small comments:
1) windows SocketImpl.c in the comments:
java_net_AbstractPlainS
Hi Chris,
Updated in place.
http://cr.openjdk.java.net/~rriggs/webrev-net-cleanup-8195059/
Thanks, Roger
On 2/2/2018 11:30 AM, Chris Hegarty wrote:
Roger,
On 01/02/18 21:29, Roger Riggs wrote:
Hi Chris,
Thanks for the review and suggestion.
Webrev updated:
http://cr.openjdk.java.net/~rr
On 02/02/18 17:07, Roger Riggs wrote:
Hi Chris,
Updated in place.
http://cr.openjdk.java.net/~rriggs/webrev-net-cleanup-8195059/
Looks good to me.
Trivially ( no need to re-generate the webrev ), in windows
SocketImpl.c java*_net*_java_net_SocketCleanable
-Chris.
Hi Roger,
Nice separation of concerns (io vs. net).
Is JavaIOFileDescriptorAccess.registerCleanup(FileDescriptor) currently
used at all?
Although not necessary for this patch, but to make code more symmetric,
FileDecriptor.FDCleaner could also be extracted into a package-private
top class a
Hi Peter,
I filed a new issue for the cleanup:
https://bugs.openjdk.java.net/browse/JDK-8196716
On 2/2/2018 1:16 PM, Peter Levart wrote:
Hi Roger,
Nice separation of concerns (io vs. net).
Is JavaIOFileDescriptorAccess.registerCleanup(FileDescriptor)
currently used at all?
I have not gott
