Re: [PATCH] SOCK_CLOEXEC for opening sockets

2018-07-16 Thread Alan Bateman
On 12/07/2018 08:21, Andrew Luo wrote: Thanks, I can refactor it.  I’m not as familiar with the OpenJDK architecture – should I just duplicate the function into libnio or is there some common utility library that I should move it into?  Also, let me know what in net_util_* needs cleanup. 

Re: [PATCH] SOCK_CLOEXEC for opening sockets

2018-07-16 Thread Chris Hegarty
Andrew, I filed the following issue to track this: https://bugs.openjdk.java.net/browse/JDK-8207335 Once you produce an updated patch, I can review and sponsor this for you. -Chris. On 12/07/18 08:21, Andrew Luo wrote: Thanks, I can refactor it.  I’m not as familiar with the OpenJDK

Re: RFR [11] 8207265: Bad HTML in {@link} in HttpResponse.BodySubscribers.ofPublisher

2018-07-16 Thread Michael McMahon
Looks fine Chris. - Michael. On 16/07/2018, 12:10, Chris Hegarty wrote: This is a review request for a small doc-only change to fix a "bad" use of angle brackets ( for a parameterized type ) as the target of an @link [*]. The simplest solution is to just replace the link with @code, since the

RFR [11] 8207265: Bad HTML in {@link} in HttpResponse.BodySubscribers.ofPublisher

2018-07-16 Thread Chris Hegarty
This is a review request for a small doc-only change to fix a "bad" use of angle brackets ( for a parameterized type ) as the target of an @link [*]. The simplest solution is to just replace the link with @code, since the built javadoc contains the appropriate links in the method declaration.