Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-08 Thread Roger Riggs
On Tue, 8 Mar 2022 05:51:21 GMT, Xue-Lei Andrew Fan wrote: >> src/java.base/share/classes/sun/security/ssl/ECDHKeyExchange.java line 204: >> >>> 202: } catch (GeneralSecurityException | java.io.IOException e) >>> { >>> 203: throw new SSLHandshakeException( >>> 204:

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v3]

2022-03-08 Thread zzambers
On Tue, 8 Mar 2022 14:21:19 GMT, zzambers wrote: >> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was >> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / >> Socket.shutdownOutput() and InputStream.close() / OutputStream.close() >> performed

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v4]

2022-03-08 Thread zzambers
> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed half-close of TLS-1.3 connection. However this behaviour

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v7]

2022-03-08 Thread Mark Sheppard
On Mon, 7 Feb 2022 09:14:51 GMT, Daniel Jeliński wrote: >> Clean up of various issues related to error handling and memory management > > Daniel Jeliński has updated the pull request incrementally with one > additional commit since the last revision: > > Initialize return value in all cases

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]

2022-03-08 Thread zzambers
On Mon, 7 Mar 2022 21:01:12 GMT, Bradford Wetmore wrote: >> @bradfordwetmore Sure if more changes are desired I can pull your changes. >> When It comes to CSR I am not fully familiar with the process. Is action >> expected from my side? > >> Sure if more changes are desired I can pull your

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]

2022-03-08 Thread zzambers
On Mon, 7 Mar 2022 21:01:12 GMT, Bradford Wetmore wrote: >> @bradfordwetmore Sure if more changes are desired I can pull your changes. >> When It comes to CSR I am not fully familiar with the process. Is action >> expected from my side? > >> Sure if more changes are desired I can pull your

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v3]

2022-03-08 Thread zzambers
> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed half-close of TLS-1.3 connection. However this behaviour

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v7]

2022-03-08 Thread Daniel Fuchs
On Mon, 7 Feb 2022 09:14:51 GMT, Daniel Jeliński wrote: >> Clean up of various issues related to error handling and memory management > > Daniel Jeliński has updated the pull request incrementally with one > additional commit since the last revision: > > Initialize return value in all cases

Re: RFR: 8280494: (D)TLS signature schemes [v19]

2022-03-08 Thread Sean Mullan
On Sun, 6 Mar 2022 05:40:59 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support signature schemes customization for individual >> (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 >> RFE:

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v4]

2022-03-08 Thread Bradford Wetmore
On Tue, 8 Mar 2022 15:03:57 GMT, zzambers wrote: >> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was >> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / >> Socket.shutdownOutput() and InputStream.close() / OutputStream.close() >> performed

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]

2022-03-08 Thread Bradford Wetmore
On Tue, 8 Mar 2022 15:23:13 GMT, zzambers wrote: >>> Sure if more changes are desired I can pull your changes. When It comes to >>> CSR I am not fully familiar with the >> process. Is action expected from my side? >> >> One of us needs to get the CSR approved. Why don't you pull the changes

Integrated: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments

2022-03-08 Thread Daniel Jeliński
On Sat, 23 Oct 2021 10:26:34 GMT, Daniel Jeliński wrote: > Clean up of various issues related to error handling and memory management This pull request has now been integrated. Changeset: 2549e550 Author:Daniel Jeliński Committer: Daniel Fuchs URL:

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v5]

2022-03-08 Thread Xue-Lei Andrew Fan
> Please review this small API enhancement to add the usual constructors taking > a cause to javax.net.ssl exceptions. The use of initCause in the JSSE > implementation code is updated to use the new constructors accordingly. > > Please review the CSR: