Hello team,
Could you please review below fix for:
BugID: https://bugs.openjdk.java.net/browse/JDK-8166285
Webrev: http://cr.openjdk.java.net/~skovalev/8166285/webrev.00/
Issue: Several regression tests from java/net package failing on
execution in case an option "--limi-modules java/base" pro
Hi team,
Could you please review small fix for regression tests.
BugID: https://bugs.openjdk.java.net/browse/JDK-8166791
WebRev: http://cr.openjdk.java.net/~skovalev/8166791/webrev.00/
Issue: Severl network related tests failed in case of using
"--limit-modules java.base" command line option.
Resending this for review
27.09.16 18:44, Sergei Kovalev wrote:
Hi team,
Could you please review small fix for regression tests.
BugID: https://bugs.openjdk.java.net/browse/JDK-8166791
WebRev: http://cr.openjdk.java.net/~skovalev/8166791/webrev.00/
Issue: Severl network related tests failed
Hi Chris,
Thank you for looking this.
03.10.16 16:05, Chris Hegarty wrote:
Sergei,
On 03/10/16 11:08, Sergei Kovalev wrote:
Resending this for review
27.09.16 18:44, Sergei Kovalev wrote:
Hi team,
Could you please review small fix for regression tests.
BugID: https
Fixed
http://cr.openjdk.java.net/~skovalev/8166791/webrev.02/
03.10.16 16:36, Alan Bateman wrote:
On 03/10/2016 14:33, Sergei Kovalev wrote:
SSL engin requires security provider. Its implementation located in
jdk.security.auth. In case no jdk module added we getting an exception:
test
With best regards,
Sergei
03.10.16 16:59, Chris Hegarty wrote:
On 03/10/16 14:43, Sergei Kovalev wrote:
Fixed
http://cr.openjdk.java.net/~skovalev/8166791/webrev.02/
java.compiler already exports javax.tools so no need for the
explicit export in the @modules tag. Otherwise this is fine.
-Chris.
Changed
http://cr.openjdk.java.net/~skovalev/8166791/webrev.03/
03.10.16 17:07, Alan Bateman wrote:
On 03/10/2016 15:05, Sergei Kovalev wrote:
Such notation (module/package) helps to jtreg to understand that the
module required on compilation stage. Jtreg adding "--add-exports
m
Ok. Will do
03.10.16 17:22, Chris Hegarty wrote:
On 03/10/16 15:19, Sergei Kovalev wrote:
Changed
http://cr.openjdk.java.net/~skovalev/8166791/webrev.03/
This looks fine. Reviewed.
No need to generate the webrev, but can you please check that you list
the java.* modules before the jdk
Hello all,
Please review a small fix for tests.
BugID: https://bugs.openjdk.java.net/browse/JDK-8169002
WebRev: http://cr.openjdk.java.net/~skovalev/8169002/webrev.00/
Issue: Several tests from java/net/httpclient folder have undeclared
dependency on java.logging module. This issue leads the t
.sun.net.httpserver"); />>>>/671 ConsoleHandler ch = new ConsoleHandler(); />>>>/672 logger.setLevel(Level.ALL); />>>>/673 ch.setLevel(Level.ALL); />>>>/674 logger.addHandler(ch); />>>>//>>>>/It's recommended t
Hi Team,
Please review one more small fix for module dependencies issue.
Bug ID: https://bugs.openjdk.java.net/browse/JDK-8169196
WebRev: http://cr.openjdk.java.net/~skovalev/8169196/webrev.00/index.html
Added missed dependency on jdk.httpserver. Also shell test converted to
pure java test.
est should have @modules jdk.security.auth
as the test is precisely supposed to be able to run without it
(+ lines 218-223 are probably obsolete and I suspect they should
be removed - but that is for another day).
best regards,
-- daniel
On 03/11/16 13:48, Sergei Kovalev wrote:
Hi Team,
Please
Hi Team,
Please review a very small fix for test suite.
BugID: https://bugs.openjdk.java.net/browse/JDK-8169316
WebRev: http://cr.openjdk.java.net/~skovalev/8169316/webrev.00/
Issue: bunch of tests have undeclared dependency on java.logging module.
This leads the test to fail in case no module
bugs.openjdk.java.net/browse/JDK-8038079
pointing to this test and mentioning that a better
entry point to figure out whether NTLM is supported or not
might be desirable.
best regards,
-- daniel
On 03/11/16 15:43, Sergei Kovalev wrote:
Daniel,
I case I remove lines 218-223 and disable jdk.sec
Hi Daniel,
Thank you for feedback.
Fixed and verified locally.
http://cr.openjdk.java.net/~skovalev/8169196/webrev.02/
--
With best regards,
Sergei
08.11.16 20:38, Daniel Fuchs wrote:
Hi Sergey,
This looks good now - except for line 223:
221 Field ntlmSupportedField =
ntlmPr
Hi Team,
Please review a simple fix for networking test.
BugID: https://bugs.openjdk.java.net/browse/JDK-8170864
WebRev: http://cr.openjdk.java.net/~skovalev/8170864/webrev.00/
Issue: One of networking tests fails in case using a command line option
"--limit-module".
Root cause: there is unde
Hi Colleagues,
Thank you for review.
Issue: One of networking tests fails in case using a command line
option "--limit-module".
Root cause: there is undeclared dependency on java.logging.
Are you sure of this? The test does not use logging directly, and the
HTTP
server no longer uses jdk.ut
Hi All,
Please review a small fix for tests.
BugID: https://bugs.openjdk.java.net/browse/JDK-8173475
WebRev: http://cr.openjdk.java.net/~skovalev/8173475/webrev.00/
Issue: Two tests fail in case of usage '--limit-module' command line option.
Root cause: One of the files HTTPTest.java has depend
18 matches
Mail list logo