Re: [11] RFR: 8197849: Misc improvements to URL parsing

2018-02-14 Thread Claes Redestad
Thanks for reviewing, Roger /Claes On 2018-02-14 17:50, Roger Riggs wrote: Hi Claes, Looks fine, Roger On 2/14/2018 11:36 AM, Claes Redestad wrote: Right, I expanded the range as much as possible given the constraint provided by L_ENCODED minus '/'. I will think of a better comment to thi

Re: [11] RFR: 8197849: Misc improvements to URL parsing

2018-02-14 Thread Roger Riggs
Hi Claes, Looks fine, Roger On 2/14/2018 11:36 AM, Claes Redestad wrote: Right, I expanded the range as much as possible given the constraint provided by L_ENCODED minus '/'. I will think of a better comment to this effect. /Claes Daniel Fuchs skrev: (14 februari 2018 17:25:20 CET)

Re: [11] RFR: 8197849: Misc improvements to URL parsing

2018-02-14 Thread Claes Redestad
Right, I expanded the range as much as possible given the constraint provided by L_ENCODED minus '/'. I will think of a better comment to this effect. /Claes Daniel Fuchs skrev: (14 februari 2018 17:25:20 CET) >Hi Claes, > >Your proposed changes to ParseUtil look reasonable >to me, though I had

Re: [11] RFR: 8197849: Misc improvements to URL parsing

2018-02-14 Thread Daniel Fuchs
Hi Claes, Your proposed changes to ParseUtil look reasonable to me, though I had to carefully compare the characters in the range (c >= '&' && c <= ':') with the L_ENCODED / H_ENCODED masks to convince myself that there was no behavior change to ParseUtil::firstEncodeIndex. I wonder whether this

[11] RFR: 8197849: Misc improvements to URL parsing

2018-02-14 Thread Claes Redestad
Hi, as a means to improve startup in some applications, please review this set of small improvements to improve both interpreted and compiled performance of creating and handling certain jar URLs. Some of the changes in sun.net.www.ParseUtil::encodePath have a small, positive effect when deal