Hi Pallavi, this change looks good to me. The only thing left to mention is that you will need to update the copyright years - I guess you would have done it on submit anyway.
Best regards Christoph From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Pallavi Sonal Sent: Freitag, 2. März 2018 02:55 To: net-dev@openjdk.java.net Subject: RFR: JDK-8144300 : Java does not honor http.nonProxyHosts value having wildcard * both at end and start Hi, Please review the following change to fix JDK-8144300. Bug : https://bugs.openjdk.java.net/browse/JDK-8144300 Webrev : http://cr.openjdk.java.net/~rpatil/8144300/webrev.00/ Whenever there is a wildcard(*) at either the beginning or the end of a hostname specified in the list of http.nonProxyHosts , the code works as expected and DIRECT connection is used for them. But in scenarios, where there is a wildcard both at the beginning and end of the hostname, proxy is used instead of DIRECT connection. All the tier1 and tier2 Mach 5 tests have passed. Thanks, Pallavi Sonal