Hi Daniel,
thanks for the review, i pushed the change(https://hg.openjdk.java.net/jdk/jdk/rev/ca2dcaf37fad).
Thanks,
Vyom
- Original message -From: Daniel Fuchs To: Vyom Tewari26 Cc: core-libs-...@openjdk.java.net, net-dev@openjdk.java.net, vyomm...@gmail.comSubject: [EXTERNAL] Re:
Hi Daniel,
Thanks for the review i need a favor , as my OpenJDK(vtewari) id is not working so i can not push the code.
Can you please push the code once review is done.
Thanks,
Vyom
- Original message -From: Daniel Fuchs To: Vyom Tewari26 Cc: core-libs-...@openjdk.java.net,
Hi Vyom,
I tried out your patch and got no suspicious failures so
you have my review :-)
best regards,
-- daniel
On 15/02/2020 04:14, Vyom Tewari26 wrote:
I'll get back to you when I have managed to find some
cycles to do so.
best regards,
-- daniel
On 14/02/2020 04:57, Vyom Tiwari wrote:
Sounds good
Thanks,
Vyom
- Original message -From: Daniel Fuchs Sent by: "net-dev" To: Vyom Tiwari , net-dev , core-libs-dev Cc:Subject: [EXTERNAL] Re: RFR 8238579: HttpsURLConnection drops the timeout and hangs forever in readDate: Sat, Feb 15, 2020 1:11 AM
Hi Vyom,On the surface, your
Hi Vyom,
On the surface, your patch seems reasonable.
I would be more confident if there was a test, but I understand
it might well be one of these noreg-hard issues.
I've put it on my TODO list to import your patch and
try to test it in our test system.
I'll get back to you when I have
Hi Felix,
Thanks for review, writing a test case is not straight forward.
we have to manually inject the write failure, if you see the attached reproducer with the issue it hacks the send native API and inject on the client side which simulates a transient network failure.
Even i was not
