On 2018/4/18 14:07, vyom tewari wrote:
Hi Felix,
latest code looks good to me, personally i prefer to throw exception
instead returning null, but i can see that old code was also returning
null.
Yes, that was initial version, but it will make the test failing on host
without IPv6 configure
Hi Felix,
latest code looks good to me, personally i prefer to throw exception
instead returning null, but i can see that old code was also returning
null. Hopping the code which invokes getFirstLocalIPv4Address,
getFirstLocalIPv6Addres already taken care of null.
Thanks,
Vyom
On Wednesda
> On 18 Apr 2018, at 06:35, Felix Yang wrote:
>
> Hi Chris and Wyom,
>
> fixed as commented. Updated webrev:
>
> http://cr.openjdk.java.net/~xiaofeya/8194260/webrev.01/
Looks good,
-Chris.
> Thanks,
> Felix
> On 2018/4/17 16:25, Chris Hegarty wrote:
>>> On 17 Apr 2018, at 04:34, Fe
Hi Chris and Wyom,
fixed as commented. Updated webrev:
http://cr.openjdk.java.net/~xiaofeya/8194260/webrev.01/
Thanks,
Felix
On 2018/4/17 16:25, Chris Hegarty wrote:
On 17 Apr 2018, at 04:34, Felix Yang wrote:
...
http://cr.openjdk.java.net/~xiaofeya/8194260/webrev.00/
Thanks f
> On 17 Apr 2018, at 04:34, Felix Yang wrote:
> ...
> http://cr.openjdk.java.net/~xiaofeya/8194260/webrev.00/
Thanks for doing this Felix. Mainly looks good. Just a few comments.
The old test runs on systems without IPv4 or IPv6 configured. So
I think the Optional `get` should be replaced wi
Hi Felix,
Looks good to me, minor bit, please fix the tag order in all the tests,
@summary should come immediately after @bug. In Tests.java there are
unused imports(import java.net.*, java.io.*) can you please change it to
use explicit classes.
Thanks,
Vyom
On Tuesday 17 April 2018 09:04 A
