Re: RFR: 8344188: Cleanup sun.net.www.protocol.jar.JarFileFactory after JEP 486 integration
On Fri, 15 Nov 2024 07:56:15 GMT, Eirik Bjørsnøs wrote: > Please review this PR which removes SM permission checking from > `s.n.w.p.j.JarFileFactory`. > > This removes the permission checking happening in > `JarFileFactory::getCachedJarFile` and also removes the associated private > `getPermission` method, (sadly including the cute `// gulp`). The import of > `java.security.Permission` is also removed. > > Testing: `test/jdk/sun/net/www/protocol/jar` runs green, GHA results pending. I ran tier2 in our CI too and didn't spot any failure - Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22135#pullrequestreview-2438432135
Re: RFR: 8344188: Cleanup sun.net.www.protocol.jar.JarFileFactory after JEP 486 integration
On Fri, 15 Nov 2024 09:50:17 GMT, Daniel Fuchs wrote: > Changes look good, but since this is linked to JarURLConnection it would be > good to run tier1,tier2 to validate. Ran tests `jtreg:test/jdk:tier2`, results look okay: * `VerifyJimage` fail with the same error as in the `FtpClient` PR * `AsynchronousChannelGroup/Unbounded` fails with a timeout, probably intermittent * `NamedGroupsWithCipherSuite` fails with a timeout, probably intermittent - PR Comment: https://git.openjdk.org/jdk/pull/22135#issuecomment-2478674704
Re: RFR: 8344188: Cleanup sun.net.www.protocol.jar.JarFileFactory after JEP 486 integration
On Fri, 15 Nov 2024 07:56:15 GMT, Eirik Bjørsnøs wrote: > Please review this PR which removes SM permission checking from > `s.n.w.p.j.JarFileFactory`. > > This removes the permission checking happening in > `JarFileFactory::getCachedJarFile` and also removes the associated private > `getPermission` method, (sadly including the cute `// gulp`). The import of > `java.security.Permission` is also removed. > > Testing: `test/jdk/sun/net/www/protocol/jar` runs green, GHA results pending. Marked as reviewed by jpai (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/22135#pullrequestreview-2438268884
Re: RFR: 8344188: Cleanup sun.net.www.protocol.jar.JarFileFactory after JEP 486 integration
On Fri, 15 Nov 2024 07:56:15 GMT, Eirik Bjørsnøs wrote: > Please review this PR which removes SM permission checking from > `s.n.w.p.j.JarFileFactory`. > > This removes the permission checking happening in > `JarFileFactory::getCachedJarFile` and also removes the associated private > `getPermission` method, (sadly including the cute `// gulp`). The import of > `java.security.Permission` is also removed. > > Testing: `test/jdk/sun/net/www/protocol/jar` runs green, GHA results pending. Changes look good, but since this is linked to JarURLConnection it would be good to run tier1,tier2 to validate. - PR Comment: https://git.openjdk.org/jdk/pull/22135#issuecomment-2478387503
RFR: 8344188: Cleanup sun.net.www.protocol.jar.JarFileFactory after JEP 486 integration
Please review this PR which removes SM permission checking from `s.n.w.p.j.JarFileFactory`. This removes the permission checking happening in `JarFileFactory::getCachedJarFile` and also removes the associated private `getPermission` method, (sadly including the cute `// gulp`). The import of `java.security.Permission` is also removed. Testing: `test/jdk/sun/net/www/protocol/jar` runs green, GHA results pending. - Commit messages: - Remove SecurityManager permission checking from JarFileFactory Changes: https://git.openjdk.org/jdk/pull/22135/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22135&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344188 Stats: 42 lines in 1 file changed: 0 ins; 41 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/22135.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22135/head:pull/22135 PR: https://git.openjdk.org/jdk/pull/22135
