mfd mib2c comments for Robert

2005-12-02 Thread Wes Hardaker
So, first off let me start by saying this is the first time in probably 6 months or more that I ran the mfd mib2c file. I was quite shocked at the extremely well written set of prompts it led me through for generating the code. Very nice work Robert! Kudos! I do, of course, have a few minor

Invoking external commands

2005-12-02 Thread Dave Shield
I've just applied a patch to 'utilities/execute.c' so that it uses the library routine 'copy_nword' when tokenizing commands for execution, rather than handling this internally. This means that it'll parse quoted strings in the natural manner, rather than breaking on internal spaces. The reason

Re: Invoking external commands

2005-12-02 Thread Thomas Anders
Dave Shield wrote: I would like to: a) Convert these remaining directives to use 'run_exec_command' directly, and b) Convert 'get_exec_output' to be a simple wrapper round 'run_exec_command' (to catch any other private uses of this routine) But I'm not sure

Re: Invoking external commands

2005-12-02 Thread Dave Shield
On Fri, 2005-12-02 at 17:14 +0100, Thomas Anders wrote: Sounds fine. Are there any drawbacks (=change in behaviour other than bug fixing) of this approach? I don't think so - assuming everything works correctly, of course!The most likely area would be caching. The 'run_exec_command'

Re: Invoking external commands

2005-12-02 Thread Dave Shield
On Fri, 2005-12-02 at 17:14 +0100, Thomas Anders wrote: Are there any drawbacks (=change in behaviour other than bug fixing) of this approach? OK - there's one other drawback that I've only just twigged. The 'get_exec_output' routine directs the output from the external command to a temporary

Re: Problem with ownership of agent persistent stores in v5.2.2

2005-12-02 Thread Robert Story
On Thu, 01 Dec 2005 12:52:48 -0500 [EMAIL PROTECTED] wrote: CRC The agentgroup has been processed, but that only 'remembers' the CRC value. It isn't used until later, and unfortunately 'later' is CRC after it has done the initial persistent store save, which is CRC why you see the current