RE: rfv: stop looking for config dirs when done

2007-07-04 Thread Bruce Shaw
+1 On ons, 2007-07-04 at 15:25 -0400, Robert Story wrote: > By sheer chance, I found a bug in read_config. I was checking to see what > files an agent was reading, and saw lots of 'directory not present' messages > logged for weird name (some including control characters). A short debugging > s

RE: [Fwd: [sfwnv-discuss] net-snmp 5.4.1 pre3 released]

2007-07-04 Thread Bruce Shaw
OK, I found the ZFS 1 Tb bug. I'm cross posting this to sfwvn-discuss and net-snmp-coders for the widest possible distribution. As you noticed earlier (http://groups.google.com/group/mailing.unix.net-snmp-users/msg/57a1f8db 7387d8a3), it has to do with statvfs. If we compile without LARGEFILE

Re: rfv: snmpNotifyFilterTable

2007-07-04 Thread Thomas Anders
Marcus Rueckert wrote: > i still remember the problems with subversion releases and certain tar > implementations. Why is that in any way specific to *subversion* releases? *Our* earlier problem (at CVS time) was with non-portable archives produced by GNU tar (causing problem when unpacking with

Re[2]: REVERSE_ASNENCODING and bug in snmp_pdu_realloc_rbuild()

2007-07-04 Thread Aleksandr Lomanov
Magnus Fromreide wrote: > Could you please provide an example that shows the problem as I fail to > reproduce it. > > /MF I am sorry, I made bad conclusions, I understood wrongly. for (vp = pdu->variables, i = VPCACHE_SIZE - 1; vp; vp = vp->next_variable, i--) { // i thought that

Re: rfv: snmpNotifyFilterTable

2007-07-04 Thread Marcus Rueckert
On 2007-07-04 23:02:55 +0100, Dave Shield wrote: > On 04/07/07, Robert Story <[EMAIL PROTECTED]> wrote: > > Have you tried Thomas' suggestion of using zip instead of tar? > > I hadn't had the chance, no. Hold on > > > I'm interested if that works. > > Yes - a zip archive seems to unpack cor

Re: rfv: snmpNotifyFilterTable

2007-07-04 Thread Dave Shield
On 04/07/07, Robert Story <[EMAIL PROTECTED]> wrote: > Have you tried Thomas' suggestion of using zip instead of tar? I hadn't had the chance, no. Hold on > I'm interested if that works. Yes - a zip archive seems to unpack correctly. >If so, I'm much more inclined to do that for 5.4.1,

Re: REVERSE_ASNENCODING and bug in snmp_pdu_realloc_rbuild()

2007-07-04 Thread Magnus Fromreide
On ons, 2007-07-04 at 12:48 +0400, Aleksandr Lomanov wrote: > Hello, all! > > For what used reverse asn encoding ? The point is that if you forward encode snmp packages then you have to guess the size of the the content and might end up getting it wrong. By coding the package from the last, inner

Re: rfv: remove asserts with undefined string comparisons

2007-07-04 Thread Thomas Anders
Marcus Rueckert wrote: > here we go. the final one. i hope :) +1 (on v3 of this patch) +Thomas - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of you

Re: rfv: stop looking for config dirs when done

2007-07-04 Thread Thomas Anders
Robert Story wrote: > By sheer chance, I found a bug in read_config. I was checking to see what > files an agent was reading, and saw lots of 'directory not present' messages > logged for weird name (some including control characters). A short debugging > session later, I found that if the last dir

Re: rfv: stop looking for config dirs when done

2007-07-04 Thread Marcus Rueckert
On 2007-07-04 15:25:01 -0400, Robert Story wrote: > By sheer chance, I found a bug in read_config. I was checking to see what > files an agent was reading, and saw lots of 'directory not present' messages > logged for weird name (some including control characters). A short debugging > session later

Re: rfv: remove asserts with undefined string comparisons

2007-07-04 Thread Marcus Rueckert
On 2007-07-04 15:50:46 -0400, Robert Story wrote: > On Wed, 4 Jul 2007 20:15:27 +0100 Dave wrote: > DS> On 04/07/07, Marcus Rueckert <[EMAIL PROTECTED]> wrote: > DS> > ok after another discussion on irc with robert and thomas, we got v2 of > DS> > the patch. instead of removing the asserts we make

Re: rfv: stop looking for config dirs when done

2007-07-04 Thread Magnus Fromreide
On ons, 2007-07-04 at 15:25 -0400, Robert Story wrote: > By sheer chance, I found a bug in read_config. I was checking to see what > files an agent was reading, and saw lots of 'directory not present' messages > logged for weird name (some including control characters). A short debugging > session

Re: rfv: remove asserts with undefined string comparisons

2007-07-04 Thread Robert Story
On Wed, 4 Jul 2007 20:15:27 +0100 Dave wrote: DS> On 04/07/07, Marcus Rueckert <[EMAIL PROTECTED]> wrote: DS> > ok after another discussion on irc with robert and thomas, we got v2 of DS> > the patch. instead of removing the asserts we make the conditions static DS> > strings. the compiler shuts up

Re: rfv: snmpNotifyFilterTable

2007-07-04 Thread Robert Story
On Wed, 4 Jul 2007 20:30:29 +0100 Dave wrote: DS> I'd naively hoped that by minimising the changes in this way, DS> this suggestion might have some chance of being received DS> favourably. Foolish of me Note that nobody else has chimed in yet, so it's just me being difficult, as usual. ;-)

Re: rfv: stop looking for config dirs when done

2007-07-04 Thread Dave Shield
On 04/07/07, Robert Story <[EMAIL PROTECTED]> wrote: > This patch adds an extra condition to the while check, instead of > relying on a break inside the loop. Seems sensible (and safe). +1 Dave - This SF.net email is sponso

Re: rfv: snmpNotifyFilterTable

2007-07-04 Thread Dave Shield
On 04/07/07, Robert Story <[EMAIL PROTECTED]> wrote: > If you're really keen to > eliminate one of the the notification directories, what about moving > notification/* to snmp-notification-mib/? I've always found it odd (and confusing) that this one MIB is split over tw

rfv: stop looking for config dirs when done

2007-07-04 Thread Robert Story
By sheer chance, I found a bug in read_config. I was checking to see what files an agent was reading, and saw lots of 'directory not present' messages logged for weird name (some including control characters). A short debugging session later, I found that if the last directory in the config list do

Re: rfv: remove asserts with undefined string comparisons

2007-07-04 Thread Dave Shield
On 04/07/07, Marcus Rueckert <[EMAIL PROTECTED]> wrote: > ok after another discussion on irc with robert and thomas, we got v2 of > the patch. instead of removing the asserts we make the conditions static > strings. the compiler shuts up and robert still gets his debug message. Why is the first as

Re: Memory leak in agent code using mfd

2007-07-04 Thread Robert Story
On Mon, 2 Jul 2007 17:37:27 +0100 Graeme wrote: GW> Ok, as per my previous email, I've been looking at a table which uses GW> row-creation, and this is causing a couple of problems - although this GW> could be related to my implementation because I'm a little unsure about GW> a couple of things. M

Re: Getbulk maximum message size

2007-07-04 Thread Robert Story
On Wed, 4 Jul 2007 11:24:06 -0400 Del wrote: DBGA> I am using Net-SNMP 5.3.0.1, and I am having problems with the size of the packets returned by getbulk. DBGA> [...] DBGA> However, it seems that when the msgMaxSize of the originator is exceeded, Net-SNMP agent doesn't respond at all Eeek. Tha

Re: rfv: snmpNotifyFilterTable

2007-07-04 Thread Robert Story
On Wed, 4 Jul 2007 17:01:48 +0100 Dave wrote: DS> On 04/07/07, Robert Story <[EMAIL PROTECTED]> wrote: DS> > What about simply shortening the name of the leaf files? i.e. : DS> > DS> > cd agent/mibgroup/snmp-notification-mib/snmpNotifyFilterTable/* DS> > rename snmpNotifyFilterTable sNFT snmpNoti

Re: Duplicate trap sent out by snmpd

2007-07-04 Thread Robert Story
On Wed, 4 Jul 2007 09:11:14 -0700 Navaneetham wrote: N>I suspected that timeout and I set the timeout(agentXTimeout 10) to N> 10. Even the behavior is same. N> N>We are facing lot of issue because of this notification duplication. N> Can you please help us on the same? Do you really need

Re: rfv: remove asserts with undefined string comparisons

2007-07-04 Thread Robert Story
On Wed, 4 Jul 2007 18:32:42 +0200 Marcus wrote: MR> ok after another discussion on irc with robert and thomas, we got v2 of MR> the patch. instead of removing the asserts we make the conditions static MR> strings. the compiler shuts up and robert still gets his debug message. +1 -

Re: rfv: remove asserts with undefined string comparisons

2007-07-04 Thread Thomas Anders
Marcus Rueckert wrote: > ok after another discussion on irc with robert and thomas, we got v2 of > the patch. instead of removing the asserts we make the conditions static > strings. the compiler shuts up and robert still gets his debug message. +1 with remark: Could you add the "always false/fail

Re: rfv: remove asserts with undefined string comparisons

2007-07-04 Thread Marcus Rueckert
On 2007-07-04 17:42:57 +0200, Marcus Rueckert wrote: > all the asserts removed in this patch use != or == for string > comparison, which is undefined in C. after a discussion on irc with Wes > and Robert, i followed Wes' suggestion and removed the offending > asserts. > > Can we still apply it for

Re: Duplicate trap sent out by snmpd

2007-07-04 Thread Navaneetham
Hi Robert, I suspected that timeout and I set the timeout(agentXTimeout 10) to 10. Even the behavior is same. We are facing lot of issue because of this notification duplication. Can you please help us on the same? On Wed, 2007-07-04 at 09:40 -0400, Robert Story wrote: > On Tue, 3 Jul 20

Re: rfv: snmpNotifyFilterTable

2007-07-04 Thread Dave Shield
On 04/07/07, Robert Story <[EMAIL PROTECTED]> wrote: > What about simply shortening the name of the leaf files? i.e. : > > cd agent/mibgroup/snmp-notification-mib/snmpNotifyFilterTable/* > rename snmpNotifyFilterTable sNFT snmpNotifyFilterTable* I wondered about that, but decided against it - fo

Re: rfv: snmpNotifyFilterTable

2007-07-04 Thread Robert Story
On Wed, 04 Jul 2007 16:12:48 +0200 Thomas wrote: TA> Dave Shield wrote: TA> > The latest tarball does not unpack cleanly on Windows systems TA> > (at least when using WinZip) - leaving certain files at the top TA> > level of the file tree, rather than in their intended locations. TA> TA> Until we'

rfv: remove asserts with undefined string comparisons

2007-07-04 Thread Marcus Rueckert
hi, all the asserts removed in this patch use != or == for string comparison, which is undefined in C. after a discussion on irc with Wes and Robert, i followed Wes' suggestion and removed the offending asserts. Can we still apply it for 5.4.1?:) darix -- openSUSE - SUSE Linux is

Re: rfv: install embedded perl files with mode 644

2007-07-04 Thread Marcus Rueckert
On 2007-07-03 21:26:08 +0200, Thomas Anders wrote: > I'm calling for votes to apply this to 5.4.1. as it is all my "fault": +1 :) darix -- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org -

Getbulk maximum message size

2007-07-04 Thread Del Blanco Gabriel-AGD019
I am using Net-SNMP 5.3.0.1, and I am having problems with the size of the packets returned by getbulk. According to RFC 3416 (section 4.2.3): " (1) If the size of the message encapsulating the Response-PDU containing the requested number of variable bindings would be

Re: rfv: snmpNotifyFilterTable

2007-07-04 Thread Thomas Anders
Dave Shield wrote: > The latest tarball does not unpack cleanly on Windows systems > (at least when using WinZip) - leaving certain files at the top > level of the file tree, rather than in their intended locations. Until we've figured out the reason and/or have decided about a consistent way to r

Re: rfv: snmpNotifyFilterTable

2007-07-04 Thread Robert Story
On Wed, 4 Jul 2007 13:53:31 +0100 Dave wrote: DS> Proposal: DS> The contents of 'snmp-notification-mib/snmpNotifyFilterTable/*' DS> should be moved into 'notification' (alongside the other tables DS> from the same MIB).This allows these files to be extracted DS> from the tarball correctly,

Re: Duplicate trap sent out by snmpd

2007-07-04 Thread Robert Story
On Tue, 3 Jul 2007 17:25:34 -0700 Navaneetham wrote: N> Looks like some one else was faced this kind of issue before. Please N> refer following link for more information. N> N> http://sourceforge.net/mailarchive/message.php?msg_id=469EA306409F764EB1BE30336A18F3BC081352%40psimail02.usa.ccu.clearch

rfv: snmpNotifyFilterTable

2007-07-04 Thread Dave Shield
The latest tarball does not unpack cleanly on Windows systems (at least when using WinZip) - leaving certain files at the top level of the file tree, rather than in their intended locations. Among the files affected are snmpNotifyFilterTable* (part of the 'snmp-notification-mib' tree), which is i

REVERSE_ASNENCODING and bug in snmp_pdu_realloc_rbuild()

2007-07-04 Thread Aleksandr Lomanov
Hello, all! For what used reverse asn encoding ? And in snmp_pdu_realloc_rbuild() i found bug. It works okay when count of pdu->variables is less than 50. When count of variables is more than 50, it repeates first 50 variables twice and exits. Code in snmp_pdu_realloc_rbuild() from: DEBUGMSGTL

Re: rfv: install embedded perl files with mode 644

2007-07-04 Thread Dave Shield
On 03/07/07, Thomas Anders <[EMAIL PROTECTED]> wrote: > The attached trivial patch makes sure these files get installed with > mode 644 instead of 755 > I'm calling for votes to apply this to 5.4.1. +1 Dave - This SF.net em