Re: CVF: don't assume the process status is still available.

2010-09-01 Thread Bart Van Assche
On Wed, Sep 1, 2010 at 9:53 PM, Wes Hardaker < [email protected]> wrote: > > On Wed, 1 Sep 2010 21:01:02 +0200, Bart Van Assche < > [email protected]> said: > > BVA> The above patch only addresses one of the two fopen() calls in the > BVA> loop. What about the second fopen() ca

Re: CVF: don't assume the process status is still available.

2010-09-01 Thread Wes Hardaker
> On Wed, 1 Sep 2010 21:01:02 +0200, Bart Van Assche > said: BVA> The above patch only addresses one of the two fopen() calls in the BVA> loop. What about the second fopen() call ? Why not to check its BVA> return value too ? Well, you're right I didn't check the second one. BVA> And,

Re: CVF: don't assume the process status is still available.

2010-09-01 Thread Bart Van Assche
On Tue, Aug 31, 2010 at 1:52 AM, Wes Hardaker < [email protected]> wrote: > > The following patch ensures that the status file still exists. I > watched a process disappear in the middle of debugging and actually saw > this error live (when looking for something totally unrelated).

Re: CFV: Call the debug statement before returning from the function

2010-09-01 Thread Magnus Fromreide
On Wed, 2010-09-01 at 12:48 +0200, Bart Van Assche wrote: > On Wed, Sep 1, 2010 at 8:05 AM, Magnus Fromreide > wrote: > I'd like to add this pretty obvious patch. > It calls DEBUGMSG before returning instead of after... > > +1 > > Good catch. Just out of curiosity, did you find t

Re: CFV: Re: Odd code

2010-09-01 Thread Magnus Fromreide
On Wed, 2010-09-01 at 07:22 -0700, Wes Hardaker wrote: > > On Wed, 01 Sep 2010 08:00:44 +0200, Magnus Fromreide > > said: > > MF> if ((rc = > netsnmp_sess_config_transport(in_session->transport_configuration, > MF> transport)) != SNMPERR_SUCCESS) { > MF> return rc; > in_session-> s_snmp

net-snmp tables

2010-09-01 Thread Brad Lira
Hello, I am trying to understand how tables work in net-snmp, there seems to be many different APIs, and different examples have different codes to demonstrate table usage. I created the template by using mib2c that should have cache support, but need more information to understand what the code i

Re: CFV: Re: Odd code

2010-09-01 Thread Robert Story
On Wed, 01 Sep 2010 07:22:09 -0700 Wes wrote: WH> Whoops; good catch. It should be the second so the tools print the WH> right error message when an error is encountered. WH> WH> The obvious patch is: +1 -- This SF.net

Re: CVF: don't assume the process status is still available.

2010-09-01 Thread Wes Hardaker
> On Mon, 30 Aug 2010 16:52:48 -0700, Wes Hardaker > said: WH> The following patch ensures that the status file still exists. I WH> watched a process disappear in the middle of debugging and actually saw WH> this error live (when looking for something totally unrelated). And... this i

Re: CFV: don't do wildcards if exact match exists

2010-09-01 Thread Wes Hardaker
> On Tue, 31 Aug 2010 16:21:33 -0400, Robert Story > said: RS> The net-snmp-cert utility script currently does wildcard matching on RS> any input when searching for certificates. e.g. 'joe' would match RS> 'joe', 'joel' and 'joe bob'. With this patch (from Joe Marzot, who RS> wrote the s

Re: undefined symbol: smux_listen_sd

2010-09-01 Thread Wes Hardaker
> On Wed, 1 Sep 2010 11:20:45 +0530, "Prakash" > said: P> Starting snmpd/usr/sbin/snmpd: symbol lookup error: /usr/sbin/snmpd: P> undefined symbol: smux_listen_sd P> startproc: exit status of parent of /usr/sbin/snmpd: 127 That's likely from a application that is linked against the wr

CFV: Re: Odd code

2010-09-01 Thread Wes Hardaker
> On Wed, 01 Sep 2010 08:00:44 +0200, Magnus Fromreide > said: MF> if ((rc = netsnmp_sess_config_transport(in_session->transport_configuration, MF> transport)) != SNMPERR_SUCCESS) { MF> return rc; in_session-> s_snmp_errno = rc; in_session-> s_errno = 0; MF> return rc; MF> } Whoops; goo

Re: CFV: Call the debug statement before returning from the function

2010-09-01 Thread Robert Story
On Wed, 01 Sep 2010 08:05:42 +0200 Magnus wrote: MF> I'd like to add this pretty obvious patch. MF> It calls DEBUGMSG before returning instead of after... +1 -- This SF.net Dev2Dev email is sponsored by: Show off your pa

Re: CFV: Call the debug statement before returning from the function

2010-09-01 Thread Thomas Anders
Magnus Fromreide wrote: > I'd like to add this pretty obvious patch. > It calls DEBUGMSG before returning instead of after... The obvious ones are the hardest to find. +1. +Thomas -- This SF.net Dev2Dev email is sponsor

Re: CFV: Call the debug statement before returning from the function

2010-09-01 Thread Bart Van Assche
On Wed, Sep 1, 2010 at 8:05 AM, Magnus Fromreide wrote: > I'd like to add this pretty obvious patch. > It calls DEBUGMSG before returning instead of after... > +1 Good catch. Just out of curiosity, did you find this through manual inspection or via a static source code analysis tool ? Bart. --