Re: Summary of meeting between NET-SNMP devs and ICEI

On Sun, 13 May 2018 18:15:16 -0700 Keith wrote: KM> On Sun, May 13, 2018, at 3:41 PM, Bart Van Assche wrote: KM> > Should a list of to-do items be added to the Net-SNMP wiki? KM> KM> I think a to-do wiki page on github would be a good idea to KM> deal with what needs to be done. Then, as each

Re: [PATCH 01/15] Cygwin64: Fix winExtDLL build

On Sun, 13 May 2018 14:31:39 -0700 Bart wrote: BVA> The winExtDLL code assumes that sizeof(oid) == 4. Hence define BVA> the 'oid' type as unsigned int when building with MSVC, MinGW BVA> or Cygwin. This patch avoids that building winExtDLL with BVA> Cygwin64 fails on the following statement: BVA>

Re: [PATCH 00/15] Clean up Net-SNMP public header files

On Sun, 13 May 2018 14:31:38 -0700 Bart wrote: BVA> Since Net-SNMP version 5.8 will be released soon and since no BVA> prior version has been released from the v5.8 (master) branch BVA> yet this is a good time to review the public header files and BVA> verify whether any potentially backwards

Re: Summary of meeting between NET-SNMP devs and ICEI

On Sun, May 13, 2018, at 3:41 PM, Bart Van Assche wrote: > On 04/12/18 08:31, Ian Bruene wrote: > > This morning we (Keith, Ian) met with an assortment of the NET-SNMP > > developers / contributors (primarily Bart Van Assche) to discuss how we > > could best help the project. The meeting went

Re: 5.8.rc1 is available

On Thu, 10 May 2018 08:46:17 -0700 Bart wrote: BVA> On 05/06/18 17:32, Robert Story wrote: BVA> > The first release candidate for the next release of Net-SNMP BVA> > is available for testing [1]. [...] BVA> [...] BVA> Since we are preparing the first v5.8 release, do you think BVA> this is a good

Re: [PATCH] install openbsd6.h header

On Fri, 11 May 2018 21:48:52 +0100 Stuart wrote: SH> From 216f6e4e5c600dc82c27fe67a01bb8f4304d0ddb Mon Sep 17 SH> 00:00:00 2001 From: Stuart Henderson SH> Date: Fri, 11 May 2018 21:48:22 +0100 SH> Subject: [PATCH] Install missing system header files Thanks again. Applied

Re: removed USM_{AUTH,PRIV}_PROTO_*_LEN macros

On Sat, 12 May 2018 12:38:10 +0100 Stuart wrote: SH> The USM_*_PROTO_*_LEN constant macros removed in 329a9d3c9 are SH> used in other programs using Net-SNMP libraries. I noticed a SH> problem building PHP against 5.8.rc1 but looking at SH> codesearch.debian.net I find a few other programs that

Re: Summary of meeting between NET-SNMP devs and ICEI

On 04/12/18 08:31, Ian Bruene wrote: This morning we (Keith, Ian) met with an assortment of the NET-SNMP developers / contributors (primarily Bart Van Assche) to discuss how we could best help the project. The meeting went well, at least form our perspective. The pain points we identified

[PATCH 15/15] : Reduce the number of #include directives further

No symbols from , nor are used in . Hence stop including these files in . --- include/net-snmp/types.h | 19 --- include/net-snmp/varbind_api.h | 1 + 2 files changed, 1 insertion(+), 19 deletions(-) diff --git a/include/net-snmp/types.h b/include/net-snmp/types.h index

[PATCH 02/15] : Add a missing #include directive

Since PATH_MAX and MAXPATHLEN are used in this header file, include the header file that defines these constants. --- include/net-snmp/library/tools.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/net-snmp/library/tools.h b/include/net-snmp/library/tools.h index

[PATCH 06/15] win32/config.h.borland: Remove this header file

The latest Borland C++ compiler version was released in 1999. Since no new versions of that compiler were released after that date, remove support for the Borland compiler. --- win32/config.h.borland | 772 - 1 file changed, 772 deletions(-) delete

[PATCH 04/15] : Add a missing forward declaration

This change allows this header file to be included before . --- include/net-snmp/session_api.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/net-snmp/session_api.h b/include/net-snmp/session_api.h index e99305a664b9..a471ab7169e4 100644 --- a/include/net-snmp/session_api.h +++

[PATCH 10/15] libsnmp: Remove ONE_SEC definition

Since the ONE_SEC constant is only used in a few places, remove the definition of this constant and expand the constant where it was used. --- agent/mibgroup/agentx/agentx_config.c | 2 +- agent/mibgroup/agentx/client.c| 6 +++--- include/net-snmp/definitions.h| 2 --

[PATCH 14/15] : Stop including from

Add #include and/or #include where necessary. --- include/net-snmp/library/snmp_api.h | 2 +- include/net-snmp/library/snmp_transport.h | 2 ++ include/net-snmp/types.h | 2 -- snmplib/cert_util.c | 1 + snmplib/snmp-tc.c | 1

[PATCH 00/15] Clean up Net-SNMP public header files

Hello, Since Net-SNMP version 5.8 will be released soon and since no prior version has been released from the v5.8 (master) branch yet this is a good time to review the public header files and verify whether any potentially backwards incompatible changes should be made. The patches in this series

[PATCH 13/15] : Remove this header file

Since this header file is not included from any other source file, remove it. --- include/net-snmp/library/libsnmp.h | 174 - win32/dist/installer/net-snmp.nsi | 1 - 2 files changed, 175 deletions(-) delete mode 100644 include/net-snmp/library/libsnmp.h

[PATCH 05/15] : Add a missing #include directive

Since the snmp_agent.h header file uses the definitions from snmp_api.h, include that header file. --- include/net-snmp/agent/snmp_agent.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/net-snmp/agent/snmp_agent.h b/include/net-snmp/agent/snmp_agent.h index

[PATCH 07/15] include/net-snmp/system/*: Remove unused preprocessor symbols

Several preprocessor symbols are defined or undefined in system header files but are not used anywhere in the Net-SNMP code base. Hence remove the #define and #undef directives for these symbols from the system header files. --- include/net-snmp/system/aix.h | 2 +-

[PATCH 01/15] Cygwin64: Fix winExtDLL build

The winExtDLL code assumes that sizeof(oid) == 4. Hence define the 'oid' type as unsigned int when building with MSVC, MinGW or Cygwin. This patch avoids that building winExtDLL with Cygwin64 fails on the following statement: netsnmp_static_assert(sizeof(oid) == sizeof(UINT)); ---

[PATCH 11/15] libsnmp: Define MAX_OID_LEN once instead of three times

--- include/net-snmp/definitions.h | 6 -- include/net-snmp/library/asn1.h | 2 -- include/net-snmp/types.h| 1 + 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/include/net-snmp/definitions.h b/include/net-snmp/definitions.h index e79aa5d05c6a..1dfca03ab572 100644 ---

[PATCH 08/15] Darwin: Move SNMP_CFRelease() definition

Define the SNMP_CFRelease() macro once instead of multiple times. --- agent/mibgroup/host/data_access/swinst_darwin.c | 3 +++ include/net-snmp/system/darwin10.h | 5 - include/net-snmp/system/darwin11.h | 5 - include/net-snmp/system/darwin12.h | 5

[PATCH 03/15] : Add missing #include directives

Make sure that the struct timeval definition is included when it is used inside this header file. --- include/net-snmp/library/snmp_api.h | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/include/net-snmp/library/snmp_api.h b/include/net-snmp/library/snmp_api.h