Re: Test code review request

2018-09-16 Thread Anders Wallin
One more thing; I think it would make sense to add tests for the usage of "-s $localhost" since this was introduced in 5.8 e.g T184.. #!/bin/sh . ../support/simple_eval_tools.sh HEADER Agent uses clientaddr for trapsink source SKIPIF NETSNMP_DISABLE_SNMPV2C . ./S180trapaddrinfra INITV4

Re: Test code review request

2018-09-16 Thread Anders Wallin
Hi Bill, On Ubuntu using dash as default shell you get # ./RUNFULLTESTS -g default -r T180 Agent uses clientaddr for trapsink source .. /root/net-snmp/testing/fulltests/support/simple_run: 21: [: unexpected operator Agent uses clientaddr for trapsink source .. ok All tests successful. Files=1,

Re: Test code review request

2018-09-16 Thread Bill Fenner
On Sun, Sep 16, 2018 at 12:11 AM Bart Van Assche wrote: > On 09/13/18 10:55, Bill Fenner wrote: > > I wrote some tests for traps and clientaddr, since there were a bunch of > > changes between 5.7 and 5.8 in this area. I did a couple of unusual > things: > > > > 1. I factored a ton of the test